From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Marvin Liu <yong.liu@intel.com>,
maxime.coquelin@redhat.com, tiwei.bie@intel.com
Cc: zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx
Date: Mon, 2 Jul 2018 17:52:13 +0100 [thread overview]
Message-ID: <c9baecde-a056-ba3b-8c03-58f6a433011d@intel.com> (raw)
In-Reply-To: <7ab59556-5719-e05b-ea1f-f94867d90b24@intel.com>
On 7/2/2018 5:41 PM, Ferruh Yigit wrote:
> On 7/2/2018 2:56 PM, Marvin Liu wrote:
>> IN_ORDER Rx function depends on merge-able feature. Descriptors
>> allocation and free will be done in bulk.
>>
>> Virtio dequeue logic:
>> dequeue_burst_rx(burst mbufs)
>> for (each mbuf b) {
>> if (b need merge) {
>> merge remained mbufs
>> add merged mbuf to return mbufs list
>> } else {
>> add mbuf to return mbufs list
>> }
>> }
>> if (last mbuf c need merge) {
>> dequeue_burst_rx(required mbufs)
>> merge last mbuf c
>> }
>> refill_avail_ring_bulk()
>> update_avail_ring()
>> return mbufs list
>>
>> IN_ORDER Tx function can support offloading features. Packets which
>> matched "can_push" option will be handled by simple xmit function. Those
>> packets can't match "can_push" will be handled by original xmit function
>> with in-order flag.
>>
>> Virtio enqueue logic:
>> xmit_cleanup(used descs)
>> for (each xmit mbuf b) {
>> if (b can inorder xmit) {
>> add mbuf b to inorder burst list
>> continue
>> } else {
>> xmit inorder burst list
>> xmit mbuf b by original function
>> }
>> }
>> if (inorder burst list not empty) {
>> xmit inorder burst list
>> }
>> update_avail_ring()
>>
>> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> <...>
>
>> @@ -150,6 +188,83 @@ virtio_xmit_cleanup(struct virtqueue *vq, uint16_t num)
>> }
>> }
>>
>> +/* Cleanup from completed inorder transmits. */
>> +static void
>> +virtio_xmit_cleanup_inorder(struct virtqueue *vq, uint16_t num)
>> +{
>> + uint16_t i, used_idx, desc_idx, last_idx;
>
>
> Getting following build error [1], from code it looks like false positive, but
> to get rid of the build error would it be OK to set initial value to "desc_idx"?
I applied this while merging, if this is wrong please let me know, we can fix in
next-net, Thanks.
>
>
> [1]
> .../dpdk/drivers/net/virtio/virtio_rxtx.c:195:24: error: ‘desc_idx’ may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
>
>
> uint16_t i, used_idx, desc_idx, last_idx;
>
>
>
> ^~~~~~~~
>
next prev parent reply other threads:[~2018-07-02 16:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 13:56 [dpdk-dev] [PATCH v5 0/9] support in-order feature Marvin Liu
2018-07-02 8:33 ` Maxime Coquelin
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 1/9] vhost: advertise " Marvin Liu
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 2/9] net/virtio: add in-order feature bit definition Marvin Liu
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 3/9] net/virtio-user: add unsupported features mask Marvin Liu
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 4/9] net/virtio-user: add mrg-rxbuf and in-order vdev parameters Marvin Liu
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 5/9] net/virtio: free in-order descriptors before device start Marvin Liu
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 6/9] net/virtio: extract common part for in-order functions Marvin Liu
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx Marvin Liu
2018-07-02 16:41 ` Ferruh Yigit
2018-07-02 16:52 ` Ferruh Yigit [this message]
2018-07-02 16:53 ` Maxime Coquelin
2018-07-02 16:57 ` Ferruh Yigit
2018-07-03 1:36 ` Liu, Yong
2018-07-03 10:36 ` Ferruh Yigit
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 8/9] net/virtio: add in-order Rx/Tx into selection Marvin Liu
2018-07-02 11:24 ` Maxime Coquelin
2018-07-02 12:41 ` Maxime Coquelin
2018-07-02 15:18 ` Maxime Coquelin
2018-07-03 1:40 ` Liu, Yong
2018-07-02 13:56 ` [dpdk-dev] [PATCH v5 9/9] net/virtio: advertise support in-order feature Marvin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9baecde-a056-ba3b-8c03-58f6a433011d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).