From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Cc: konstantin.ananyev@intel.com, jingjing.wu@intel.com,
santosh.shukla@caviumnetworks.com
Subject: Re: [dpdk-dev] [PATCH v9 0/9] Policy Based Power Control for Guest
Date: Thu, 12 Oct 2017 01:23:48 +0100 [thread overview]
Message-ID: <c9fdd86a-4c3b-7e92-020e-374b0a8be0ef@intel.com> (raw)
In-Reply-To: <1507738735-24879-1-git-send-email-david.hunt@intel.com>
On 10/11/2017 5:18 PM, David Hunt wrote:
> Policy Based Power Control for Guest
>
> This patchset adds the facility for a guest VM to send a policy down to the
> host that will allow the host to scale up/down cpu frequencies
> depending on the policy criteria independently of the DPDK app running in
> the guest. This differs from the previous vm_power implementation where
> individual scale up/down requests were send from the guest to the host via
> virtio-serial.
>
> V9 patchset changes:
> * Rebased on top of the tip of the master branch
> * changed port_id from uint8 to uint16 due to changes elsewhere
>
> V8 patchset changes:
> * Added Ack's and Reviewed-by's to individual patches in the set so as to
> keep patchwork A/R/T flags properly in sync.
>
> V7 patchset changes:
> * Changed return code of rte_pmd_i40e_query_vfid_by_mac() from an
> int64_t to int
>
> V6 patchset changes:
> * Fixed comments in header for rte_pmd_i40e_query_vfid_by_mac.
> * changed rte_pmd_i40e_query_vfid_by_mac return code from uint to int
> as it can return negative error codes.
> * Removed bool enum from channel_commands.h, including stdbool.h instead.
> * Added #define VM_MAX_NAME_SZ 32 to channel_commands.h
> * Renamed a few variables to be more readable.
> * Added returns in a few places if failed to get info on domain.
> * Fixed power_manager_init to keep track of num_freqs for each core.
> * In power_manager_scale_core_med(), changed a hardcoded '5' to instead
> be calculated from the centre of the frequency list
> (global_core_freq_info[core_num].num_freqs / 2)
>
> V5 patchset changes:
> * Removed most of the #ifdef I40_PMD as it will be applicable to
> other PMDs in the future.
> * Changed the parameter of rte_pmd_i40e_query_vfid_by_mac from a uint64
> to a const struct ether_addr *, rather than casting it later in the
> function.
>
> V4 patchset changes:
> * None, re-post to mailing list under the correct email thread.
>
> V3 patchset changes:
> * Changed to using is_same_ether_addr() instead of looping through
> the mac address bytes to compare them.
> * Tweaked some comments and working in the i40e patch after review.
> * Added a patch to the set to add new i40e function to map file, so
> as to allow shared library builds. The power library API needs a cleanup
> in next release, so will add API/ABI warning for this cleanup in a
> separate patch.
>
> V2 patchset changes:
> * Removed API's in ethdev layer.
> * Now just a single new API in the i40e driver for mapping VF MAC to
> VF index.
> * Moved new function from rte_rxtx.c to rte_pmd_i40e.c
> * Removed function for reading i40e register, moved to using the
> standard stats API.
> * Renamed i40e function to rte_pmd_i40e_query_vfid_by_mac
> * Cleaned up policy generation code.
>
> It's a modification of the vm_power_manager app that runs in the host, and
> the guest_vm_power_app example app that runs in the guest. This allows the
> guest to send down a policy to the host via virtio-serial, which then allows
> the host to scale up/down based on the criteria in the policy, resulting in
> quicker scale up/down than individual requests coming from the guest.
> It also means that the DPDK application running in the guest does not need
> to be modified in any way, it is unaware that it's cores are being scaled
> up/down, reducing the effort in implementing a power-aware infrastructure.
>
> The usage model is as follows:
> 1. Set up the VF's and assign to the guest in the usual way.
> 2. run vm_power_manager on the host, creating a channel to the guest.
> 3. Start the guest_vm_power_mgr app on the guest, which establishes
> a virtio-serial channel to the host.
> 4. Send down the profile for the guest using the "send_profile now" command.
> There is an example profile hard-coded into guest_vm_power_mgr.
> 5. Stop the guest_vm_power_mgr and run your normal power-unaware application.
> 6. Send traffic into the VFs at varying traffic rates.
> Observe the frequency change on the host (turbostat -i 1)
>
> The sequence of code changes are as follows:
>
> A new function has been aded to the i40e driver to allow mapping of
> a VF MAC to VF index.
>
> Next we make an addition to librte_power that adds an extra command to allow
> the passing of a policy structure from the guest to the host. This struct
> contains information like busy/quiet hour, packet throughput thresholds, etc.
>
> The next addition adds functionality to convert the virtual CPU (vcpU0 IDs to
> physical CPU (pcpu) IDs so that the host can scale up/down the cores used
> in the guest.
>
> The remaining patches are functionality to process the policy, and take action
> when the relevant trigger occurs to cause a frequency change.
Applied to dpdk/master, thanks.
next prev parent reply other threads:[~2017-10-12 0:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 16:11 [dpdk-dev] [PATCH v1 0/4] add per-core Turbo Boost capability David Hunt
2017-08-22 16:11 ` [dpdk-dev] [PATCH v1 1/4] lib/librte_power: add per-core turbo capability David Hunt
2017-09-13 10:44 ` [dpdk-dev] [PATCH v2 0/4] add per-core Turbo Boost capability David Hunt
2017-09-13 10:44 ` [dpdk-dev] [PATCH v2 1/4] lib/librte_power: add turbo boost API David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 0/9] Policy Based Power Control for Guest David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 1/9] net/i40e: add API to convert VF MAC to VF id David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 2/9] lib/librte_power: add extra msg type for policies David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 3/9] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 4/9] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 5/9] examples/vm_power_mgr: add policy to channels David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 6/9] examples/vm_power_mgr: add port initialisation David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 7/9] power: add send channel msg function to map file David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 8/9] examples/guest_cli: add send policy to host David Hunt
2017-10-03 14:08 ` [dpdk-dev] [PATCH v3 9/9] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 0/9] Policy Based Power Control for Guest David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 1/9] net/i40e: add API to convert VF MAC to VF id David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 2/9] lib/librte_power: add extra msg type for policies David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 3/9] examples/vm_power_mgr: add vcpu to pcpu mapping David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 4/9] examples/vm_power_mgr: add scale to medium freq fn David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 5/9] examples/vm_power_mgr: add policy to channels David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 6/9] examples/vm_power_mgr: add port initialisation David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 7/9] power: add send channel msg function to map file David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 8/9] examples/guest_cli: add send policy to host David Hunt
2017-10-11 16:18 ` [dpdk-dev] [PATCH v9 9/9] examples/vm_power_mgr: set MAC address of VF David Hunt
2017-10-12 0:23 ` Ferruh Yigit [this message]
2017-09-13 10:44 ` [dpdk-dev] [PATCH v2 2/4] examples/vm_power_manager: add per-core turbo David Hunt
2017-09-13 10:44 ` [dpdk-dev] [PATCH v2 3/4] examples/vm_power_cli_guest: " David Hunt
2017-09-13 10:44 ` [dpdk-dev] [PATCH v2 4/4] doc/power: add information on per-core turbo APIs David Hunt
2017-09-18 18:20 ` Mcnamara, John
2018-02-06 12:29 ` Mcnamara, John
2017-09-22 14:36 ` [dpdk-dev] [PATCH v2 0/4] add per-core Turbo Boost capability Thomas Monjalon
2017-08-22 16:11 ` [dpdk-dev] [PATCH v1 2/4] examples/vm_power_manager: add per-core turbo David Hunt
2017-08-22 16:11 ` [dpdk-dev] [PATCH v1 3/4] examples/vm_power_cli_guest: " David Hunt
2017-08-22 16:11 ` [dpdk-dev] [PATCH v1 4/4] lib: limit turbo to particular models of CPU David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9fdd86a-4c3b-7e92-020e-374b0a8be0ef@intel.com \
--to=ferruh.yigit@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).