patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>, skhare@vmware.com
Cc: dev@dpdk.org, deepak.k.jain@intel.com, yongwang@vmware.com,
	stable@dpdk.org, Tomasz Kulasek <tomaszx.kulasek@intel.com>
Subject: Re: [dpdk-stable] [PATCH v2] net/vmxnet3: fix dereference before null check
Date: Mon, 2 Oct 2017 22:39:29 +0100	[thread overview]
Message-ID: <ca21412e-a09b-02f3-ec0a-b206c3f2859f@intel.com> (raw)
In-Reply-To: <20170929130402.32196-1-michalx.k.jastrzebski@intel.com>

On 9/29/2017 2:04 PM, Michal Jastrzebski wrote:
> Coverity reports check_after_deref:
> Null-checking rq suggests that it may be null, but it
> has already been dereferenced on all paths leading to
> the check.
> This patch removes NULL checking of "rq" from function
> vmxnet3_dev_rx_queue_reset as it is already checked against NULL
> one level up the callstack (function vmxnet3_dev_clear_queues).
> 
> Coverity issue: 143468
> Fixes: 5aecdc17a97d ("vmxnet3: fix stop/restart")
> Cc: yongwang@vmware.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

  parent reply	other threads:[~2017-10-02 21:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 12:39 [dpdk-stable] [PATCH] " Michal Jastrzebski
2017-09-22 16:39 ` Ferruh Yigit
2017-09-25  9:27   ` Jastrzebski, MichalX K
2017-09-25 10:02     ` Ferruh Yigit
2017-09-29 13:04 ` [dpdk-stable] [PATCH v2] " Michal Jastrzebski
2017-10-02 13:58   ` Jastrzebski, MichalX K
2017-10-02 21:39   ` Ferruh Yigit [this message]
2017-10-02 21:45     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca21412e-a09b-02f3-ec0a-b206c3f2859f@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=michalx.k.jastrzebski@intel.com \
    --cc=skhare@vmware.com \
    --cc=stable@dpdk.org \
    --cc=tomaszx.kulasek@intel.com \
    --cc=yongwang@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).