From: "Brandes, Shai" <shaibran@amazon.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v3 00/33] net/ena: v2.9.0 driver release
Date: Fri, 8 Mar 2024 20:26:39 +0000 [thread overview]
Message-ID: <cbe500fa-1b5e-455f-b3d0-04b13a86bf54@email.android.com> (raw)
In-Reply-To: <b2e98132-862b-4c21-bc41-babc2d5ba03d@amd.com>
[-- Attachment #1: Type: text/plain, Size: 3157 bytes --]
Sure, will upload a new seried, thanks!
בתאריך 8 במרץ 2024 19:36, Ferruh Yigit <ferruh.yigit@amd.com> כתב:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
On 3/6/2024 12:24 PM, shaibran@amazon.com wrote:
> From: Shai Brandes <shaibran@amazon.com>
>
> Hi all, the ena v2.9.0 release introduces:
> 1. HAL upgrade:
> - renamed the 'base' folder to be 'hal'
> - separated the HAL patches instead of a bulk update.
> 2. Restructured ena stats and metrics.
> 3. Restructured the LLQ configuration:
> - configurable via devarg.
> - support device recommendation.
> - restructure the logic in driver.
> 4. Added support for the admin queue to work only in poll-mode
> - configurable via devarg.
> - allows to bind ports to uio_pci_generic kernel driver.
> 5. Reworked the device close to exhaust interrupt callbacks and alarms.
> 6. Fixed a bug in fast mbuf free.
> Best regards.
>
> ---
> v3:
> * Fixed missing admin queue missing intialization in patch 0032
>
> v2:
> * Fixed minor spelling issues from checkpatch
>
>
> Shai Brandes (33):
> net/ena: rework the metrics multi-process functions
> net/ena: report new supported link speed capabilities
> net/ena: update imissed stat with Rx overruns
> net/ena: sub-optimal configuration notifications support
> net/ena: fix fast mbuf free
> net/ena: rename base folder to hal
> net/ena: restructure the llq policy setting process
> net/ena/hal: exponential backoff exp limit
> net/ena/hal: add a new csum offload bit
> net/ena/hal: added a bus parameter to ena memcpy macro
> net/ena/hal: optimize Rx ring submission queue
> net/ena/hal: rename fields in completion descriptors
> net/ena/hal: use correct read once on u8 field
> net/ena/hal: add completion descriptor corruption check
> net/ena/hal: malformed Tx descriptor error reason
> net/ena/hal: phc feature modifications
> net/ena/hal: restructure interrupt handling
> net/ena/hal: add unlikely to error checks
> net/ena/hal: missing admin interrupt reset reason
> net/ena/hal: check for existing keep alive notification
> net/ena/hal: modify memory barrier comment
> net/ena/hal: rework Rx ring submission queue
> net/ena/hal: remove operating system type enum
> net/ena/hal: handle command abort
> net/ena/hal: add support for device reset request
> net/ena: cosmetic changes
> net/ena/hal: modify customer metrics memory management
> net/ena/hal: cosmetic changes
> net/ena: update device-preferred size of rings
> net/ena: exhaust interrupt callbacks in device close
> net/ena: support max large llq depth from the device
> net/ena: control path pure polling mode
> net/ena: upgrade driver version to 2.9.0
>
Hi Shai,
I did review only first 10 patches, there are some common patterns to
address in the perspective and commit logs.
Can you please update whole series according to comments? I will review
remaining patches in the new version.
Thanks,
Ferruh
[-- Attachment #2: Type: text/html, Size: 4653 bytes --]
next prev parent reply other threads:[~2024-03-08 20:26 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:24 shaibran
2024-03-06 12:24 ` [PATCH v3 01/33] net/ena: rework the metrics multi-process functions shaibran
2024-03-06 12:24 ` [PATCH v3 02/33] net/ena: report new supported link speed capabilities shaibran
2024-03-06 12:24 ` [PATCH v3 03/33] net/ena: update imissed stat with Rx overruns shaibran
2024-03-06 12:24 ` [PATCH v3 04/33] net/ena: sub-optimal configuration notifications support shaibran
2024-03-08 17:23 ` Ferruh Yigit
2024-03-10 14:43 ` Brandes, Shai
2024-03-13 11:18 ` Ferruh Yigit
2024-03-06 12:24 ` [PATCH v3 05/33] net/ena: fix fast mbuf free shaibran
2024-03-08 17:23 ` Ferruh Yigit
2024-03-10 14:58 ` Brandes, Shai
2024-03-13 11:28 ` Ferruh Yigit
2024-03-06 12:24 ` [PATCH v3 06/33] net/ena: rename base folder to hal shaibran
2024-03-08 17:23 ` Ferruh Yigit
2024-03-10 14:23 ` Brandes, Shai
2024-03-06 12:24 ` [PATCH v3 07/33] net/ena: restructure the llq policy setting process shaibran
2024-03-08 17:24 ` Ferruh Yigit
2024-03-10 14:29 ` Brandes, Shai
2024-03-13 11:21 ` Ferruh Yigit
2024-03-06 12:24 ` [PATCH v3 08/33] net/ena/hal: exponential backoff exp limit shaibran
2024-03-08 17:24 ` Ferruh Yigit
2024-03-10 14:53 ` Brandes, Shai
2024-03-12 16:53 ` Brandes, Shai
2024-03-13 11:25 ` Ferruh Yigit
2024-03-06 12:24 ` [PATCH v3 09/33] net/ena/hal: add a new csum offload bit shaibran
2024-03-08 17:24 ` Ferruh Yigit
2024-03-06 12:24 ` [PATCH v3 10/33] net/ena/hal: added a bus parameter to ena memcpy macro shaibran
2024-03-08 17:25 ` Ferruh Yigit
2024-03-10 15:08 ` Brandes, Shai
2024-03-13 11:27 ` Ferruh Yigit
2024-03-06 12:24 ` [PATCH v3 11/33] net/ena/hal: optimize Rx ring submission queue shaibran
2024-03-06 12:24 ` [PATCH v3 12/33] net/ena/hal: rename fields in completion descriptors shaibran
2024-03-06 12:24 ` [PATCH v3 13/33] net/ena/hal: use correct read once on u8 field shaibran
2024-03-06 12:24 ` [PATCH v3 14/33] net/ena/hal: add completion descriptor corruption check shaibran
2024-03-06 12:24 ` [PATCH v3 15/33] net/ena/hal: malformed Tx descriptor error reason shaibran
2024-03-06 12:24 ` [PATCH v3 16/33] net/ena/hal: phc feature modifications shaibran
2024-03-06 12:24 ` [PATCH v3 17/33] net/ena/hal: restructure interrupt handling shaibran
2024-03-06 12:24 ` [PATCH v3 18/33] net/ena/hal: add unlikely to error checks shaibran
2024-03-06 12:24 ` [PATCH v3 19/33] net/ena/hal: missing admin interrupt reset reason shaibran
2024-03-06 12:24 ` [PATCH v3 20/33] net/ena/hal: check for existing keep alive notification shaibran
2024-03-06 12:24 ` [PATCH v3 21/33] net/ena/hal: modify memory barrier comment shaibran
2024-03-06 12:24 ` [PATCH v3 22/33] net/ena/hal: rework Rx ring submission queue shaibran
2024-03-06 12:24 ` [PATCH v3 23/33] net/ena/hal: remove operating system type enum shaibran
2024-03-06 12:24 ` [PATCH v3 24/33] net/ena/hal: handle command abort shaibran
2024-03-06 12:24 ` [PATCH v3 25/33] net/ena/hal: add support for device reset request shaibran
2024-03-06 12:24 ` [PATCH v3 26/33] net/ena: cosmetic changes shaibran
2024-03-08 11:17 ` Ferruh Yigit
2024-03-08 13:19 ` Brandes, Shai
2024-03-08 14:50 ` Ferruh Yigit
2024-03-06 12:24 ` [PATCH v3 27/33] net/ena/hal: modify customer metrics memory management shaibran
2024-03-06 12:24 ` [PATCH v3 28/33] net/ena/hal: cosmetic changes shaibran
2024-03-08 17:43 ` Ferruh Yigit
2024-03-08 17:44 ` Ferruh Yigit
2024-03-12 17:12 ` Brandes, Shai
2024-03-06 12:24 ` [PATCH v3 29/33] net/ena: update device-preferred size of rings shaibran
2024-03-06 12:24 ` [PATCH v3 30/33] net/ena: exhaust interrupt callbacks in device close shaibran
2024-03-06 12:24 ` [PATCH v3 31/33] net/ena: support max large llq depth from the device shaibran
2024-03-06 12:24 ` [PATCH v3 32/33] net/ena: control path pure polling mode shaibran
2024-03-06 12:24 ` [PATCH v3 33/33] net/ena: upgrade driver version to 2.9.0 shaibran
2024-03-08 17:36 ` [PATCH v3 00/33] net/ena: v2.9.0 driver release Ferruh Yigit
2024-03-08 20:26 ` Brandes, Shai [this message]
2024-03-10 14:21 ` Brandes, Shai
2024-03-13 11:28 ` Ferruh Yigit
2024-03-13 13:38 ` Brandes, Shai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbe500fa-1b5e-455f-b3d0-04b13a86bf54@email.android.com \
--to=shaibran@amazon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).