From: Kevin Traynor <ktraynor@redhat.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
Chaoyong He <chaoyong.he@corigine.com>,
dev@dpdk.org
Cc: oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,
stable@dpdk.org, Peng Zhang <peng.zhang@corigine.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH 4/4] net/nfp: fix stop cpp service problem
Date: Tue, 30 Jan 2024 12:17:36 +0000 [thread overview]
Message-ID: <cc8a80a3-6c8a-4d7d-a287-77fd712fd22c@redhat.com> (raw)
In-Reply-To: <f8fe4380-daf0-4aa4-88ae-ee626d8b0e7d@amd.com>
On 30/01/2024 12:07, Ferruh Yigit wrote:
> On 1/24/2024 9:25 AM, Chaoyong He wrote:
>> From: Long Wu <long.wu@corigine.com>
>>
>> Stop cpp service if all representors are closed and cpp service is running.
>>
>> Fixes: bab0e6f48b6d ("net/nfp: fix infinite loop")
>> Cc: chaoyong.he@corigine.com
>> Cc: stable@dpdk.org
>>
>
> This fix is using a new function that is introduced in previous patches
> in this set, so this fix can't be backported.
>
> Can you please change the order of the patches in this set, make this
> patch first patch in the set and update it to use old version of
> functions, so it can be backported?
> Later you can update old function with new one in the patch that
> introduces the new functions.
>
Agree, it makes sense to put fixes at the start of the series to make
the backport easier. If it's not possible for some reason, then you can
also send a rebased revision of the fix to the stable mailing list with
the correct prefix
(http://doc.dpdk.org/guides/contributing/patches.html#backporting-patches-for-stable-releases)
>
> Also instead of saying "cpp service problem" in the title, can you
> please describe the problem, I guess the problem you are referring is
> something like, "CPP service is consuming resources even there is no
> device remaining that requires it" ? Or is it something else?
>
+1
>> Signed-off-by: Long Wu <long.wu@corigine.com>
>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>> ---
>> drivers/net/nfp/flower/nfp_flower_representor.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
>> index bf67dc3ba2..2e8eb13e4e 100644
>> --- a/drivers/net/nfp/flower/nfp_flower_representor.c
>> +++ b/drivers/net/nfp/flower/nfp_flower_representor.c
>> @@ -400,6 +400,9 @@ nfp_flower_repr_dev_close(struct rte_eth_dev *dev)
>> /* Stop flower service first */
>> nfp_flower_service_stop(app_fw_flower);
>>
>> + /* Disable cpp service if need */
>> + nfp_service_disable(&pf_dev->cpp_service_info);
>> +
>> /* Now it is safe to free all PF resources */
>> nfp_uninit_app_fw_flower(pf_dev);
>> nfp_pf_uninit(pf_dev);
>
prev parent reply other threads:[~2024-01-30 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240124092541.2011874-1-chaoyong.he@corigine.com>
2024-01-24 9:25 ` Chaoyong He
2024-01-30 12:07 ` Ferruh Yigit
2024-01-30 12:17 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc8a80a3-6c8a-4d7d-a287-77fd712fd22c@redhat.com \
--to=ktraynor@redhat.com \
--cc=bluca@debian.org \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).