From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: edwin.brossette@6wind.com, dev@dpdk.org
Cc: ferruh.yigit@amd.com, olivier.matz@6wind.com, stable@dpdk.org
Subject: Re: [PATCH] net/virtio: fix duplicated rxq xstats
Date: Tue, 6 Feb 2024 15:56:55 +0100 [thread overview]
Message-ID: <cdb229c9-f40c-4907-ad48-63731fab7eab@redhat.com> (raw)
In-Reply-To: <20231124135235.1831304-1-edwin.brossette@6wind.com>
On 11/24/23 14:52, edwin.brossette@6wind.com wrote:
> From: Edwin Brossette <edwin.brossette@6wind.com>
>
> The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while
> moving queue stats from 'struct rte_eth_stats' to the individual pmds,
> as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass
> auto-filled queue xstats").
>
> This flag was added so every pmd would keep its original behavior until
> the change was implemented. However, this flag was not removed
> afterwards in the virtio pmd and as a result, some queue stats are
> displayed twice when trying to get them: once in lib_rte_ethdev, and a
> second time in the virtio pmd.
>
> Remove this flag so stats are printed only once.
>
> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats")
> Cc: stable@dpdk.org
>
> Signed-off-by: Edwin Brossette <edwin.brossette@6wind.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
Applied to next-virtio tree.
Thanks,
Maxime
prev parent reply other threads:[~2024-02-06 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANDF9xARG2SvzRRK_3+8RK2SCP_Zj7DggOtPmnNDR9sWmr-j5Q@mail.gmail.com>
2023-11-24 13:52 ` edwin.brossette
2023-11-27 10:20 ` Ferruh Yigit
2024-02-06 14:56 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdb229c9-f40c-4907-ad48-63731fab7eab@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=edwin.brossette@6wind.com \
--cc=ferruh.yigit@amd.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).