From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc: support loopback mode configuration
Date: Mon, 9 Apr 2018 15:01:31 +0300 [thread overview]
Message-ID: <ce444482-d828-1496-1059-ad77c7eddb41@solarflare.com> (raw)
In-Reply-To: <92e30c65-2db8-db43-5f52-4a2af865f44a@intel.com>
On 04/06/2018 03:09 PM, Ferruh Yigit wrote:
> On 4/4/2018 12:10 PM, Andrew Rybchenko wrote:
>> All loopback modes are listed in efx_loopback_type_t.
>> Available loopback modes are listed per link speed in
>> the enc_loopback_types member of the efx_nic_cfg_t.
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> Reviewed-by: Andy Moreton <amoreton@solarflare.com>
>> Reviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Getting following build error with clang, can you please check?
>
>
> .../dpdk/drivers/net/sfc/base/efx_port.c:122:6: error: comparison of constant 64
> with expression of type 'efx_loopback_type_t' (aka 'enum efx_loopback_type_e')
> is always true [-Werror,-Wtautological-constant-out-of-range-compare]
> if (EFX_TEST_QWORD_BIT(encp->enc_loopback_types[link_mode],
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../dpdk/drivers/net/sfc/base/efx_types.h:1590:28: note: expanded from macro
> 'EFX_TEST_QWORD_BIT'
> #define EFX_TEST_QWORD_BIT EFX_TEST_QWORD_BIT64
> ^
> .../dpdk/drivers/net/sfc/base/efx_types.h:1412:22: note: expanded from macro
> 'EFX_TEST_QWORD_BIT64'
> __CPU_TO_LE_64(EFX_SHIFT64(_bit, FIX_LINT(0)))) != 0)
> ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../dpdk/drivers/net/sfc/base/efx_types.h:1290:32: note: expanded from macro
> 'EFX_SHIFT64'
> (((_bit) >= (_base) && (_bit) < (_base) + 64) ? \
> ^
> .../dpdk/drivers/net/sfc/base/efx_types.h:269:50: note: expanded from macro
> '__CPU_TO_LE_64'
> #define __CPU_TO_LE_64(_x) ((uint64_t)__NOSWAP64(_x))
> ~~~~~~~~~~~^~~
> .../dpdk/drivers/net/sfc/base/efx_types.h:238:26: note: expanded from macro
> '__NOSWAP64'
> #define __NOSWAP64(_x) (_x)
> ^~
> 1 error generated.
Thanks, I've added patch to fix the problem.
Andrew.
next prev parent reply other threads:[~2018-04-09 12:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 11:10 Andrew Rybchenko
2018-04-04 11:10 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add commands to set loopback mode Andrew Rybchenko
2018-04-06 12:09 ` Ferruh Yigit
2018-04-06 12:09 ` [dpdk-dev] [PATCH 1/2] net/sfc: support loopback mode configuration Ferruh Yigit
2018-04-09 12:01 ` Andrew Rybchenko [this message]
2018-04-09 11:58 ` [dpdk-dev] [PATCH v2 0/3] " Andrew Rybchenko
2018-04-09 11:58 ` [dpdk-dev] [PATCH v2 1/3] net/sfc/base: fix comparison always true warning Andrew Rybchenko
2018-04-09 11:58 ` [dpdk-dev] [PATCH v2 2/3] net/sfc: support loopback mode configuration Andrew Rybchenko
2018-04-09 11:58 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: add commands to set loopback mode Andrew Rybchenko
2018-04-10 17:23 ` [dpdk-dev] [PATCH v2 0/3] net/sfc: support loopback mode configuration Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce444482-d828-1496-1059-ad77c7eddb41@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).