From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Cheng Jiang <cheng1.jiang@intel.com>, chenbo.xia@intel.com
Cc: dev@dpdk.org, jiayu.hu@intel.com, xuan.ding@intel.com,
wenwux.ma@intel.com, yuanx.wang@intel.com,
xingguang.he@intel.com
Subject: Re: [PATCH v2 1/3] vhost: remove redundant copy for packed shadow used ring
Date: Thu, 2 Feb 2023 10:13:31 +0100 [thread overview]
Message-ID: <ceb7c7d7-d25a-2a02-3e11-b2c605e67358@redhat.com> (raw)
In-Reply-To: <20230113025653.16583-2-cheng1.jiang@intel.com>
On 1/13/23 03:56, Cheng Jiang wrote:
> In the packed ring enqueue data path of the current asynchronous
> Vhost design, the shadow used ring is first copied to the sync
> shadow used ring, and then it will be moved to the async shadow
> used ring for some historical reasons. This is completely unnecessary.
> This patch removes redundant copy for the shadow used ring. The async
> shadow used ring will be updated directly.
>
> Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
> ---
> lib/vhost/virtio_net.c | 66 ++++++++++++++++++++----------------------
> 1 file changed, 31 insertions(+), 35 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-02-02 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 0:44 [PATCH 0/3] Async vhost packed ring optimization Cheng Jiang
2022-12-20 0:44 ` [PATCH 1/3] vhost: remove redundant copy for packed shadow used ring Cheng Jiang
2022-12-20 0:44 ` [PATCH 2/3] vhost: add batch enqueue in async vhost packed ring Cheng Jiang
2022-12-20 0:44 ` [PATCH 3/3] vhost: add batch dequeue " Cheng Jiang
2023-01-13 2:56 ` [PATCH v2 0/3] Async vhost packed ring optimization Cheng Jiang
2023-01-13 2:56 ` [PATCH v2 1/3] vhost: remove redundant copy for packed shadow used ring Cheng Jiang
2023-02-02 9:13 ` Maxime Coquelin [this message]
2023-01-13 2:56 ` [PATCH v2 2/3] vhost: add batch enqueue in async vhost packed ring Cheng Jiang
2023-02-02 9:31 ` Maxime Coquelin
2023-01-13 2:56 ` [PATCH v2 3/3] vhost: add batch dequeue " Cheng Jiang
2023-02-02 10:07 ` Maxime Coquelin
2023-02-03 14:59 ` [PATCH v2 0/3] Async vhost packed ring optimization Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb7c7d7-d25a-2a02-3e11-b2c605e67358@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=wenwux.ma@intel.com \
--cc=xingguang.he@intel.com \
--cc=xuan.ding@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).