From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>,
Chengfeng Ye <cyeaa@connect.ust.hk>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5] net/mlx5: fix mutex unlock in txpp cleanup
Date: Thu, 11 Nov 2021 11:25:24 +0000 [thread overview]
Message-ID: <ceba0c08-f05a-9969-f456-46737381ffb4@intel.com> (raw)
In-Reply-To: <DM6PR12MB37538F39D11C26EFA9F5F486DF949@DM6PR12MB3753.namprd12.prod.outlook.com>
On 11/11/2021 7:06 AM, Slava Ovsiienko wrote:
> Hi, Ferruh
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Wednesday, November 10, 2021 18:57
>> To: Chengfeng Ye <cyeaa@connect.ust.hk>; david.marchand@redhat.com;
>> Slava Ovsiienko <viacheslavo@nvidia.com>; Shahaf Shuler
>> <shahafs@nvidia.com>; Matan Azrad <matan@nvidia.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v5] net/mlx5: fix mutex unlock in txpp
>> cleanup
>>
>> On 10/12/2021 11:02 AM, Chengfeng Ye wrote:
>>> The lock sh->txpp.mutex was not correctly released on one path of
>>> cleanup function return, potentially causing the deadlock.
>>>
>>> Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
>>> ---
>>> drivers/net/mlx5/mlx5_txpp.c | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/mlx5/mlx5_txpp.c
>>> b/drivers/net/mlx5/mlx5_txpp.c index 4f6da9f2d1..0ece788a84 100644
>>> --- a/drivers/net/mlx5/mlx5_txpp.c
>>> +++ b/drivers/net/mlx5/mlx5_txpp.c
>>> @@ -961,8 +961,12 @@ mlx5_txpp_stop(struct rte_eth_dev *dev)
>>> MLX5_ASSERT(!ret);
>>> RTE_SET_USED(ret);
>>> MLX5_ASSERT(sh->txpp.refcnt);
>>> - if (!sh->txpp.refcnt || --sh->txpp.refcnt)
>>> + if (!sh->txpp.refcnt || --sh->txpp.refcnt) {
>>> + ret = pthread_mutex_unlock(&sh->txpp.mutex);
>>> + MLX5_ASSERT(!ret);
>>> + RTE_SET_USED(ret);
>>
>> Is this 'RTE_SET_USED()' need to be used multiple times for same variable?
> mmm, It seems "claim_zero()" macro would be better here:
>
> claim_zero(pthread_mutex_lock(&sh->txpp.mutex));
>
> I will provide the cleanup patch, thank you for noticing that
>
>> This usage looks ugly, I can see why it is used but I wonder if this can be
>> solved differently, what about something like following:
>>
>> #ifdef RTE_LIBRTE_MLX5_DEBUG
>> #define MLX5_ASSERT(exp) RTE_VERIFY(exp)
>> #else
>> #ifdef RTE_ENABLE_ASSERT
>> #define MLX5_ASSERT(exp) RTE_ASSERT(exp)
>> #else
>> #define MLX5_ASSERT(exp) RTE_SET_USED(exp)
>> #endif
>> #endif
> It would directly replace MLX5_ASSERT(exp) with RTE_SET_USED(exp)
> if there is neither RTE_ENABLE_ASSERT nor RTE_LIBRTE_MLX5_DEBUG.
> We would not like to drop the "not used" check functionality at all , right?
>
The suggestion was to prevent following kind of usage:
MLX5_ASSERT(!ret);
RTE_SET_USED(ret);
I assume you need above usage when a variable is used only in the 'MLX5_ASSERT',
if there is a way to prevent warning in that case without 'RTE_SET_USED' that
may be better.
prev parent reply other threads:[~2021-11-11 11:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 10:02 [dpdk-stable] " Chengfeng Ye
2021-11-02 7:55 ` Slava Ovsiienko
2021-11-09 11:08 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
2021-11-10 16:57 ` Ferruh Yigit
2021-11-11 7:06 ` Slava Ovsiienko
2021-11-11 8:47 ` [PATCH] net/mlx5: remove redundant "set used" Viacheslav Ovsiienko
2021-11-11 8:59 ` Slava Ovsiienko
2021-11-11 12:08 ` Ferruh Yigit
2021-11-11 12:27 ` Slava Ovsiienko
2021-11-11 16:07 ` YE Chengfeng
2021-11-11 16:47 ` Slava Ovsiienko
2021-11-11 18:31 ` YE Chengfeng
2021-11-16 14:52 ` 回复: " YE Chengfeng
2021-11-11 11:25 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceba0c08-f05a-9969-f456-46737381ffb4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cyeaa@connect.ust.hk \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).