DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5
Date: Wed, 15 Mar 2017 14:28:01 +0000	[thread overview]
Message-ID: <cefea552-45ae-03c3-6520-ce3583c8a606@intel.com> (raw)
In-Reply-To: <20170310231334.2457-2-yskoh@mellanox.com>

On 3/10/2017 11:13 PM, Yongseok Koh wrote:
> ConnectX-5 supports enhanced version of multi-packet send (MPS). An MPS Tx
> descriptor can carry multiple packets either by including pointers of
> packets or by inlining packets. Inlining packet data can be helpful to
> better utilize PCIe bandwidth. In addition, Enhanced MPS supports hybrid
> mode - mixing inlined packets and pointers in a descriptor. This feature is
> enabled by default if supported by HW.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
<...>

> +		uintptr_t addr;

<...>

> +			addr = htonll(addr);
> +			*dseg = (rte_v128u32_t) {
> +				htonl(length),
> +				txq_mp2mr(txq, txq_mb2mp(buf)),
> +				addr,
> +				addr >> 32,

This creates build error for 32bit target:

...drivers/net/mlx5/mlx5_rxtx.c: In function ‘mlx5_tx_burst_empw’:
...drivers/net/mlx5/mlx5_rxtx.c:1630:10:
error: right shift count >= width of type [-Werror=shift-count-overflow]
     addr >> 32,
          ^~

  parent reply	other threads:[~2017-03-15 14:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 23:13 [dpdk-dev] [PATCH v2 0/2] " Yongseok Koh
2017-03-10 23:13 ` [dpdk-dev] [PATCH v2 1/2] " Yongseok Koh
2017-03-15  7:28   ` Shahaf Shuler
2017-03-15 10:39   ` Nélio Laranjeiro
2017-03-15 10:44     ` Nélio Laranjeiro
2017-03-15 14:28   ` Ferruh Yigit [this message]
2017-03-10 23:13 ` [dpdk-dev] [PATCH v2 2/2] doc: update PMD options for mlx5 Yongseok Koh
2017-03-15  7:30   ` Shahaf Shuler
2017-03-15 23:55 ` [dpdk-dev] [PATCH v3 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5 Yongseok Koh
2017-03-15 23:55   ` [dpdk-dev] [PATCH v3 1/2] " Yongseok Koh
2017-03-15 23:55   ` [dpdk-dev] [PATCH v3 2/2] doc: update PMD options for mlx5 Yongseok Koh
2017-03-16  0:01   ` [dpdk-dev] [PATCH v3 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5 Yongseok Koh
2017-03-16 13:47   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cefea552-45ae-03c3-6520-ce3583c8a606@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).