From: "lihuisong (C)" <lihuisong@huawei.com>
To: Samina Arshad <samina.arshad@intel.com>, <dev@dpdk.org>
Cc: <ciara.power@intel.com>, <tadhg.kearney@intel.com>
Subject: Re: [PATCH v3] usertools/telemetry: fix unused parameter
Date: Fri, 26 May 2023 11:41:15 +0800 [thread overview]
Message-ID: <cf347025-d48e-7c29-cad9-0df70a394259@huawei.com> (raw)
In-Reply-To: <20230525155048.523875-1-samina.arshad@intel.com>
在 2023/5/25 23:50, Samina Arshad 写道:
> This bug fix ensures that the runtime socket path is generated
> correctly, based on the user-specified file_prefix value,
> resolving the issue that occurred in the previous implementation.
>
> Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> Cc: lihuisong@huawei.com
>
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> Acked-by: Ciara Power <ciara.power@intel.com>
> ---
> v2:
> Made changes for previous commit to be efficient. Removed
> "args" from "args.file_prefix".
> ---
> v3:
> Edit commit body by removing stable@dpdk.org from cc as
> the fix is not needed to be backported to 21.11 or 22.11.
> ---
> ---
> usertools/dpdk-telemetry-client.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
> index d6718ca5b0..e3bb1c9ee0 100755
> --- a/usertools/dpdk-telemetry-client.py
> +++ b/usertools/dpdk-telemetry-client.py
> @@ -55,8 +55,8 @@ def getFilepath(self, file_path):
> # Gets arguments from Command-Line and assigns to instance of client
> self.file_path = file_path
>
> - def setRunpath(self, file_path):
> - self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
> + def setRunpath(self, file_prefix):
> + self.run_path = os.path.join(get_dpdk_runtime_dir(file_prefix),
> RUNTIME_SOCKET_NAME)
Apologise for the mistake.
Acked-by: lihuisong@huawei.com
>
> def register(self):
next prev parent reply other threads:[~2023-05-26 3:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 13:47 [PATCH v1] " Samina Arshad
2023-05-22 9:29 ` Burakov, Anatoly
2023-05-23 14:38 ` [PATCH v2] " Samina Arshad
2023-05-25 13:34 ` Power, Ciara
2023-06-01 14:42 ` Thomas Monjalon
2023-06-01 14:52 ` Power, Ciara
2023-05-25 15:50 ` [PATCH v3] " Samina Arshad
2023-05-26 3:41 ` lihuisong (C) [this message]
2023-06-01 14:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf347025-d48e-7c29-cad9-0df70a394259@huawei.com \
--to=lihuisong@huawei.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=samina.arshad@intel.com \
--cc=tadhg.kearney@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).