From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 14/14] bnxt: add device ID for Stratus VF
Date: Tue, 17 Apr 2018 19:29:11 +0100 [thread overview]
Message-ID: <cf5cac2d-10bf-9671-6990-480721c32f85@intel.com> (raw)
In-Reply-To: <CACZ4nhv47P=m8WdSYWqi-unzkdgv2XtPm_=etUNCo6S492USbQ@mail.gmail.com>
On 4/17/2018 7:25 PM, Ajit Khaparde wrote:
> No Ferruh. It is not a new product family.
> Just adding a device ID (for a VF) for a skew of already existing product.
> So a documentation update is not required.
OK, thanks for clarification.
>
> Thanks
> Ajit
>
> On Tue, Apr 17, 2018 at 11:20 AM, Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
>
> On 4/17/2018 2:11 AM, Ajit Khaparde wrote:
> > From: Somnath Kotur <somnath.kotur@broadcom.com
> <mailto:somnath.kotur@broadcom.com>>
> >
>
> This is adding new device id to driver.
> Does it require any change in documentation?
> Do you want to announce new hw support in release notes?
>
> > Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device")
> > Cc: ajit.khaparde@broadcom.com <mailto:ajit.khaparde@broadcom.com>
> > Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com
> <mailto:somnath.kotur@broadcom.com>>
> > ---
> > drivers/net/bnxt/bnxt_ethdev.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> > index 3cf845089..7632c326b 100644
> > --- a/drivers/net/bnxt/bnxt_ethdev.c
> > +++ b/drivers/net/bnxt/bnxt_ethdev.c
> > @@ -34,7 +34,8 @@ int bnxt_logtype_driver;
> >
> > #define PCI_VENDOR_ID_BROADCOM 0x14E4
> >
> > -#define BROADCOM_DEV_ID_STRATUS_NIC_VF 0x1609
> > +#define BROADCOM_DEV_ID_STRATUS_NIC_VF1 0x1606
> > +#define BROADCOM_DEV_ID_STRATUS_NIC_VF2 0x1609
> > #define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
> > #define BROADCOM_DEV_ID_57414_VF 0x16c1
> > #define BROADCOM_DEV_ID_57301 0x16c8
> > @@ -75,7 +76,9 @@ int bnxt_logtype_driver;
> >
> > static const struct rte_pci_id bnxt_pci_id_map[] = {
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> > - BROADCOM_DEV_ID_STRATUS_NIC_VF) },
> > + BROADCOM_DEV_ID_STRATUS_NIC_VF1) },
> > + { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> > + BROADCOM_DEV_ID_STRATUS_NIC_VF2) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_STRATUS_NIC) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
> > @@ -3063,7 +3066,8 @@ static bool bnxt_vf_pciid(uint16_t id)
> > id == BROADCOM_DEV_ID_5731X_VF ||
> > id == BROADCOM_DEV_ID_5741X_VF ||
> > id == BROADCOM_DEV_ID_57414_VF ||
> > - id == BROADCOM_DEV_ID_STRATUS_NIC_VF)
> > + id == BROADCOM_DEV_ID_STRATUS_NIC_VF1 ||
> > + id == BROADCOM_DEV_ID_STRATUS_NIC_VF2)
> > return true;
> > return false;
> > }
> >
>
>
next prev parent reply other threads:[~2018-04-17 18:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 1:11 [dpdk-dev] [PATCH 00/14] bnxt patchset Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 01/14] net/bnxt: set default log level to informational Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 02/14] net/bnxt: set padding flags in Rx descriptor Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 03/14] net/bnxt: fix bnxt_hwrm_vnic_alloc Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 04/14] net/bnxt: fix incorrect ntuple flag setting Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 05/14] net/bnxt: fix Rx checksum flags for tunnel frames Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 06/14] net/bnxt: fix L2 filter cleanup Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 07/14] net/bnxt: fix bnxt_flow_destroy Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 08/14] net/bnxt: add code to determine the Tx COS queue Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 09/14] net/bnxt: maintain rx_mbuf_alloc_fail per RxQ Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 10/14] net/bnxt: reset l2_filter_id once filter is freed Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 11/14] net/bnxt: free memory allocated for VF filters Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 12/14] net/bnxt: use UINT64_MAX to initialize filter ids Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 13/14] net/bnxt: avoid freeing mem_zone multiple times Ajit Khaparde
2018-04-17 1:11 ` [dpdk-dev] [PATCH 14/14] bnxt: add device ID for Stratus VF Ajit Khaparde
2018-04-17 18:20 ` Ferruh Yigit
2018-04-17 18:25 ` Ajit Khaparde
2018-04-17 18:29 ` Ferruh Yigit [this message]
2018-04-17 18:19 ` [dpdk-dev] [PATCH 00/14] bnxt patchset Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf5cac2d-10bf-9671-6990-480721c32f85@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).