From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Allain Legacy <allain.legacy@windriver.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit
Date: Wed, 5 Apr 2017 11:08:11 +0100 [thread overview]
Message-ID: <cf7fa9e8-644a-5b73-33cf-1bf83aee5b54@intel.com> (raw)
In-Reply-To: <20170405082308.GA19612@bricha3-MOBL3.ger.corp.intel.com>
On 4/5/2017 9:23 AM, Bruce Richardson wrote:
> On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote:
>> On 4/4/2017 5:36 PM, Allain Legacy wrote:
>>> The AVP devices are only supported on Intel 64-bit architectures so
>>> adjusting the defconfig attributes accordingly.
>>>
>>> Fixes: c5ab4707ba97 ("net/avp: support driver registration")
>>>
>>> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
>>> ---
>>> config/common_linuxapp | 1 -
>>> config/defconfig_i686-native-linuxapp-gcc | 5 -----
>>> config/defconfig_i686-native-linuxapp-icc | 5 -----
>>> config/defconfig_x86_64-native-linuxapp-clang | 5 +++++
>>
>> Right now compiler config files only have compiler and architecture
>> configs, although it is OK to update them, to be consistent with what
>> other PMDs did, what do you think:
>>
>> Keep AVP config enabled in "common_linuxapp"
>>
>> Disable AVP in following configs:
>> defconfig_arm64-armv8a-linuxapp-gcc
>> defconfig_arm-armv7a-linuxapp-gcc
>> defconfig_ppc_64-power8-linuxapp-gcc
>>
>
> I actually disagree with that, and I think the approach proposed is
> better, given that it's only one target type that is supported.
Agree that it is better, but other PMDs are doing what I suggested, so I
am for AVP follow the same, and fix them all later when required.
>
> However, I think we should have an AVP config option in common base, set
> to "n", so that we at least there have an entry to indicate it exists.
>
> /Bruce
>
next prev parent reply other threads:[~2017-04-05 10:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 16:36 Allain Legacy
2017-04-04 17:12 ` Ferruh Yigit
2017-04-04 17:17 ` Legacy, Allain
2017-04-04 17:20 ` Ferruh Yigit
2017-04-05 8:23 ` Bruce Richardson
2017-04-05 8:58 ` Thomas Monjalon
2017-04-05 10:08 ` Ferruh Yigit [this message]
2017-04-04 17:37 ` [dpdk-dev] [PATCH v2] " Allain Legacy
2017-04-07 11:13 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf7fa9e8-644a-5b73-33cf-1bf83aee5b54@intel.com \
--to=ferruh.yigit@intel.com \
--cc=allain.legacy@windriver.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).