From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH] net: update licence for network headers
Date: Mon, 11 Dec 2017 09:56:40 -0800 [thread overview]
Message-ID: <cf86b313-5e9b-c8c0-ccb8-31afc77c2139@intel.com> (raw)
In-Reply-To: <448cfe74-224b-8a25-6be3-42c70c6ac514@nxp.com>
On 12/10/2017 9:27 PM, Hemant Agrawal wrote:
> On 12/8/2017 11:52 PM, Andrew Rybchenko wrote:
>> On 12/08/2017 08:29 PM, Ferruh Yigit wrote:
>>> On 12/8/2017 2:28 AM, Olivier Matz wrote:
>>>> To be compliant with the DPDK licensing guidelines, switch to
>>>> BSD-3-Clause. It can be done safely since the BSD headers from which
>>>> these files derive also exist as a BSD-3-Clause license in FreeBSD.
>>>>
>>>> Link:
>>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/ip_icmp.h
>>>>
>>>> Link:
>>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/ip.h
>>>>
>>>> Link:
>>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/sctp.h
>>>>
>>>> Link:
>>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/tcp.h
>>>>
>>>> Link:
>>>> https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/sys/netinet/udp.h
>>>>
>>>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>>> <...>
>>>
>>>> + * SPDX-License-Identifier: BSD-3-Clause
>>>> *
>>>> - * @(#)in.h 8.3 (Berkeley) 1/3/94
>>>> - * $FreeBSD: src/sys/netinet/in.h,v 1.82 2003/10/25 09:37:10 ume Exp $
>>>> + * Copyright(c) 1982, 1986, 1990, 1993
>>>> + * The Regents of the University of California.
>>>> + * Copyright(c) 2013 6WIND S.A.
>>>> + * All rights reserved.
>>>> */
>>> Not sure how much it matters but in the document Hemant put, order is
>>> different,
>>> it starts with Copyright line instead of SPDX line:
>>>
>>> "
>>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER
>>> SPDX-License-Identifier: BSD-3-Clause
>>> "
>>>
>>> So I assume for multiple Copyright holder:
>>>
>>> "
>>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER
>>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-2
>>> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-3
>>> SPDX-License-Identifier: BSD-3-Clause
>>> "
>>>
>>> And do we still need "All rights reserved." ?
>>>
>>>
>>> I am for following same syntax in all files (whichever is chosen),
>>> this may
>>> helps us in the future for scripting licensing checks.
>>>
>>> <...>
>>
>> License text example in [1] starts from Copyright and has All rights
>> reserved.
>> I agree that template should be clearly specified from the very beginning.
>>
>> [1] https://spdx.org/licenses/BSD-3-Clause#licenseText
>>
> Hi all,
> Most templates are showing copyright first and SPDX later i.e. the
> typical way for writing the license.
>
> However some projects has followed it other way around to make it easy
> for tools i.e. the TOP line.
>
> I agree with Ferruh that we shall follow single convention. I will
> prefer to do it in following way to make it consistent. (I will also fix
> my change patches).
>
> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER
> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-2
> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-3
> >> SPDX-License-Identifier: BSD-3-Clause
Stephen mentioned Linux already has a defined syntax for this, unless there is a
good reason to change I think we can follow same syntax, what do you think?
>
>
> Regards,
> Hemant
>
>
next prev parent reply other threads:[~2017-12-11 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 10:28 Olivier Matz
2017-12-08 17:29 ` Ferruh Yigit
2017-12-08 18:04 ` Stephen Hemminger
2017-12-08 18:22 ` Andrew Rybchenko
2017-12-11 5:27 ` Hemant Agrawal
2017-12-11 8:58 ` Olivier MATZ
2017-12-11 17:56 ` Ferruh Yigit [this message]
2017-12-12 16:57 ` Olivier MATZ
2017-12-13 5:13 ` Hemant Agrawal
2017-12-14 11:33 ` Hemant Agrawal
2017-12-14 12:58 ` Thomas Monjalon
2017-12-15 10:54 ` Hemant Agrawal
2017-12-22 15:59 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2017-12-28 11:42 ` Hemant Agrawal
2018-01-05 10:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf86b313-5e9b-c8c0-ccb8-31afc77c2139@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).