From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>, dev@dpdk.org
Cc: byron.marohn@intel.com, reshma.pattan@intel.com,
pablo.de.lara.guarch@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] lib/efd: fix to free tail queue entry after use
Date: Fri, 23 Nov 2018 14:30:08 +0100 [thread overview]
Message-ID: <cf939ded-7945-1fa7-b693-60774ee774db@redhat.com> (raw)
In-Reply-To: <1542194265-16156-1-git-send-email-hari.kumarx.vemula@intel.com>
On 11/14/18 12:17 PM, Hari Kumar Vemula wrote:
> In rte_efd_create() allocated memory for tail queue entry but
> not freed.
> Added freeing the tail queue entry.
>
> Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
>
> ---
> v2: Updated commit message.
> ---
>
> lib/librte_efd/rte_efd.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c
> index a780e2fe8..f8c6c447f 100644
> --- a/lib/librte_efd/rte_efd.c
> +++ b/lib/librte_efd/rte_efd.c
> @@ -739,17 +739,38 @@ void
> rte_efd_free(struct rte_efd_table *table)
> {
> uint8_t socket_id;
> + struct rte_efd_list *efd_list = NULL;
NULL init seems useless here.
> + struct rte_tailq_entry *te;
>
> if (table == NULL)
> return;
>
> + efd_list = RTE_TAILQ_CAST(rte_efd_tailq.head, rte_efd_list);
> +
> for (socket_id = 0; socket_id < RTE_MAX_NUMA_NODES; socket_id++)
> rte_free(table->chunks[socket_id]);
>
> + rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
> +
> + /* find our tailq entry */
> + TAILQ_FOREACH(te, efd_list, next) {
> + if (te->data == (void *) table)
> + break;
> + }
> +
> + if (te == NULL) {
> + rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
> + return;
> + }
> +
> + TAILQ_REMOVE(efd_list, te, next);
> + rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
Wouldn't this be simpler by using TAILQ_FOREACH_SAFE() instead?
The element could removed from the list and freed within the loop.
> +
> rte_ring_free(table->free_slots);
> rte_free(table->offline_chunks);
> rte_free(table->keys);
> rte_free(table);
> + rte_free(te);
> }
>
> /**
>
next prev parent reply other threads:[~2018-11-23 13:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 11:45 [dpdk-stable] [PATCH] lib: fix to free trail " Hari Kumar Vemula
2018-11-13 16:43 ` Pattan, Reshma
2018-11-14 11:17 ` [dpdk-stable] [PATCH v2] lib/efd: fix to free tail " Hari Kumar Vemula
2018-11-18 14:57 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-11-23 13:30 ` Maxime Coquelin [this message]
2018-11-23 14:39 ` Maxime Coquelin
2019-01-11 11:49 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-01-14 22:30 ` Thomas Monjalon
2019-01-14 22:39 ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
2019-01-17 13:36 ` [dpdk-stable] [PATCH v4] " Hari Kumar Vemula
2019-01-17 16:41 ` De Lara Guarch, Pablo
2019-01-18 7:40 ` [dpdk-stable] [PATCH v5] " Hari Kumar Vemula
2019-01-18 18:21 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf939ded-7945-1fa7-b693-60774ee774db@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=byron.marohn@intel.com \
--cc=dev@dpdk.org \
--cc=hari.kumarx.vemula@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).