Re: [RFC 2/2] recheck: Add a recheck parser for patchwork comments

[Thomas Monjalon <thomas@monjalon.net>]

02/11/2023 14:03, Aaron Conole:
> Thomas Monjalon <thomas@monjalon.net> writes:
> 
> > 01/11/2023 20:16, Aaron Conole:
> >> Michael Santana <msantana@redhat.com> writes:
> >> > I like this workflow. The only thing that I do not like is that you
> >> > have to check every comment on every patch. That seems like an
> >> > expensive operation, but honestly I do not think there is a better way
> >> > to accomplish this. So if there is no better way to do it then it's
> >> > okay, let's move forward with it
> >> 
> >> There isn't a different way to do it for now, but I hope to switch to
> >> using the events API which should mean we only look at the most recent
> >> events that come in.
> >
> > What prevent us to use the events API?
> 
> Ideally we could use it everywhere, but the pw-ci project is used for
> other patchwork instances.  Events API for comments is a recent change,
> and not every patchwork instance is upgraded to support it (for example,
> both ozlabs and kernel.org patchwork instances don't have support).
> 
> I do have some detection code, and am planning on hooking that up so
> that we can detect whether events API supports comment events based on
> the filters offered, but that takes some time to test and validate.
> 
> So it becomes a question of which is more important - having something
> working now, or spending time with the detection code.  Either way, we
> need it for older patchworks that haven't upgraded to the just released
> version (some projects are still on 2.2.0).

I agree better to work on general availability first.

> If you think it is better to do the events path first, I can go with
> that but then we severely limit which projects get support for rechecks,
> and I've already gotten the feature request for both OVS and OVN - so
> we'd either need to support comments polling anyway, or do the massive
> work of upgrading ozlabs instance.

Events API is an optimization. It can come later.