DPDK CI discussions
 help / color / mirror / Atom feed
From: zhoumin <zhoumin@loongson.cn>
To: Patrick Robb <probb@iol.unh.edu>
Cc: ci@dpdk.org, Aaron Conole <aconole@redhat.com>,
	David Marchand <david.marchand@redhat.com>,
	"Brandes, Shai" <shaibran@amazon.com>
Subject: Re: Email based retests for the Loongarch lab
Date: Tue, 17 Jun 2025 12:15:12 +0800	[thread overview]
Message-ID: <123907a4-bfa2-180d-7abd-fe4c498c5381@loongson.cn> (raw)
In-Reply-To: <CAJvnSUB79G2-p3yjdqbtFzHrmFCQ87QkizHDJr1JbxCJro8u8g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2605 bytes --]

Hi Patrick Robb,

Thanks for you efforts on retest framework! The get_reruns.py script is 
really helpful. We will support the rebase argument this week.

On 2025/6/12 5:05AM, Patrick Robb wrote:
> Hi Min Zhou,
>
> Thanks for the response and for getting some retest support online! I 
> agree the next reasonable steps are to continue to align out 
> processes, in part so that the lab behavior is predictable according 
> to what is documented on dpdk.org 
> <https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fdpdk.org&tid=_____8AxfeHf8EloUBoUAQ--.8230S3&rcpt=zhoumin@loongson.cn&ifnotice=1&rindex=0>. 
>
>
> On Sat, Jun 7, 2025 at 8:50 PM zhoumin <zhoumin@loongson.cn 
> <mailto:zhoumin@loongson.cn>> wrote:
>
>     Yes, we don't support the rebase argument. Meanwhile, for the sake
>     of simplicity, the rechecking behavior at Loongson lab is a little
>     different from the default behavior. we recheck the patches on the
>     latest HEAD of the branch selected by pw_maintainers_cli.py
>     script. This behavior is same to that of the first testing for the
>     commit at Loongson lab. It's ok to be consistent with the defualt
>     behavior. Maybe we can support both it and rebase argument after
>     you have synced some infrastructures.
>
> Good point, we need to make sure the support for the rebase={branch} 
> argument is integrated into the get_reruns.py script in dpdk-ci. The 
> UNH team made that addition and it is available for patch review: 
> https://patchwork.dpdk.org/project/ci/patch/20250611205849.72165-1-probb@iol.unh.edu/
>
> Maybe you can apply it, give it a run and add a tested by tag to the 
> patch if it is working for you?
Yes, I have tested it and it is working for me. This patch has a little 
changes in the inputs and outputs to get_reruns.py, and I need to make 
corresponding changes to our current implementation of retest.
> In order to make sure it was working I submitted a placeholder 
> loongson recheck request with the rebase argument (requesting the main 
> branch) included on the DPDK mailing list. Right now if I run the 
> script with the following args it produces this json:
>
> python3 tools/get_reruns.py -ts 2025-06-10 --contexts 
> loongarch-compilation
>
> output json:
>
> {
>     "retests": {
>         "34851": {
>             "contexts": [
>                 "loongarch-compilation"
>             ],
>             "arguments": {
>                 "rebase": "main"
>             }
>         }
>     },
>     "last_comment_timestamp": "2025-06-11T20:29:39.327426"
> }

[-- Attachment #2: Type: text/html, Size: 5171 bytes --]

      reply	other threads:[~2025-06-17  4:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  5:55 Patrick Robb
2024-02-22 13:54 ` Patrick Robb
2024-02-28  5:34   ` zhoumin
2024-02-29  6:09     ` Patrick Robb
2024-03-01 10:19       ` zhoumin
2025-05-28 19:36         ` Patrick Robb
2025-06-08  0:49           ` zhoumin
2025-06-11 21:05             ` Patrick Robb
2025-06-17  4:15               ` zhoumin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=123907a4-bfa2-180d-7abd-fe4c498c5381@loongson.cn \
    --to=zhoumin@loongson.cn \
    --cc=aconole@redhat.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=probb@iol.unh.edu \
    --cc=shaibran@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).