From: David Marchand <david.marchand@redhat.com>
To: ci@dpdk.org
Cc: thomas@monjalon.net, alialnu@mellanox.com
Subject: [dpdk-ci] [PATCH] Revert "tools: fix tree detection for orphan files"
Date: Mon, 20 Jan 2020 16:31:38 +0100 [thread overview]
Message-ID: <20200120153138.24817-1-david.marchand@redhat.com> (raw)
The problem with this patch is that some files were with no git tree in
MAINTAINERS on purpose: some files are maintained in the main repository,
but we leave subtrees touch them like release notes or makefile/meson
files.
So reverting it, and adding a comment to document the reason.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
tools/guess_git_tree.py | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/guess_git_tree.py b/tools/guess_git_tree.py
index bc63674..c9eef39 100755
--- a/tools/guess_git_tree.py
+++ b/tools/guess_git_tree.py
@@ -146,11 +146,10 @@ class Maintainers(object):
tree_list = []
for _file in files:
_tree = self._get_tree(_file)
- # No identified tree for a file means that it should go through
- # the main repository.
- if not _tree:
- _tree = 'dpdk'
- tree_list.append(_tree)
+ # Having no tree means that we accept those changes going through a
+ # subtree (e.g. release notes).
+ if _tree:
+ tree_list.append(_tree)
tree = self.get_common_denominator(tree_list)
if tree == '':
tree = 'dpdk'
--
2.23.0
next reply other threads:[~2020-01-20 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 15:31 David Marchand [this message]
2020-01-21 18:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120153138.24817-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=alialnu@mellanox.com \
--cc=ci@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).