From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 022FCA0C43 for ; Mon, 18 Oct 2021 09:46:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F00D740683; Mon, 18 Oct 2021 09:46:24 +0200 (CEST) Received: from AZHDRRW-EX01.nvidia.com (azhdrrw-ex01.nvidia.com [20.51.104.162]) by mails.dpdk.org (Postfix) with ESMTP id C2FA440141 for ; Mon, 18 Oct 2021 09:46:23 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by mxs.oss.nvidia.com (10.13.234.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Mon, 18 Oct 2021 00:46:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DPLsMeaFZ9AFHikyHAEnZQIn3vsviLvBwtZxUmVgO9eFv8cqPrb4RI2MbqDZB7vKLaTTE9OMYJFODXt8zBHjMVFD+lAiMw4TkL4FGLB3F3Tu5SeoMdUk4TYsivJLv1Fvf+W+27q7ilvFWoTb9srzsbV2AhxMFmhhXXDGXDNZbPFhpYab9aY94kEpLHXrLr3MBp7TUXoSaQYQLzjaZHhUCtUcQ/AOAyGXpQwhWvCzbRuSse8A6YkvsivRJePJVPg6+V5a2RSSi90ulgTybi0ZPAKivUBVCHNzugifu2CX70ChjAbvOLKC7tHuUYwwGoBWZ9CyAAwM02ItQtngP5RLYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x7pxIxyCL7s//KE43gND4YxwTM+1KHmOmL2pXx5mm90=; b=TzrwZF4efaLcOib/MXdOZ8oGSuo5+zL36ZiNpvYoCXIRAq+G0V1kTHaMbu5HqLtOT1wEEkobZl4JjL/6wwbe9qa31O6abe8jd2Co2huLNedOGXRWPIqULa9rN6x/7x6H6zMMUrx53z+QzjtLfCC6XoEz8sxl6PWn+x1wTZTHmuESa+QcTUJVI8zECNyzoxuvHXNZHZip4eFMYFsnqplC2qhCnkyv1VrEcYELr7/6vgvsTBgjzPm2Oh6fnLtPfeqgreqYD3KbKuyYbMN3rHiWCacZcJhYY776lka173ElsOi27U4OVfmx9ia7V17JlcPvwDG6S3d7NZt4YCO0RgEUXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x7pxIxyCL7s//KE43gND4YxwTM+1KHmOmL2pXx5mm90=; b=uAlrs3hZhXTGPwSHIRezcZuNtaoyigbJC/t16dSw7DQT0556Uw3HtyXaQS4OX+bSwe6SS4lm694DMwDMoFOZIoT+ZzZiTdPxor7f3Vj5IwkFy0GZRp/T5XUjZl1HuQbkKIfypeWQmJyjuXrvlvM6rRa6FxMGgdnLpztalS58eISXbr6jiugewEkh1xMj5Ln/UOCRF6l8CtxPWeHvyz7RGglc1xmkl6a7TTbRXyFRnjvQ114zMaM2eAhPjpe+RF1tmk29ju+H7dSq102u16MYwsOJM2eOZxGgbfNvs5F2OHdX5K5BNq7yWG//8ek39VM3EsEjvvk/d+Y6S35QuP2VDg== Received: from MW3PR05CA0021.namprd05.prod.outlook.com (2603:10b6:303:2b::26) by SN6PR12MB2640.namprd12.prod.outlook.com (2603:10b6:805:6c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct 2021 07:46:21 +0000 Received: from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::ca) by MW3PR05CA0021.outlook.office365.com (2603:10b6:303:2b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.13 via Frontend Transport; Mon, 18 Oct 2021 07:46:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 07:46:21 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 18 Oct 2021 07:46:16 +0000 From: Ali Alnubani To: CC: , , , , Date: Mon, 18 Oct 2021 10:44:55 +0300 Message-ID: <20211018074500.16199-6-alialnu@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211018074500.16199-1-alialnu@nvidia.com> References: <20211018074500.16199-1-alialnu@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c6d41ed-fda6-4a7a-974c-08d9920b609b X-MS-TrafficTypeDiagnostic: SN6PR12MB2640: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-Transport-Forked: True X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NqWYJ1I/YtKjDlxfdzRE5tq1gePMOJtMRW+2MVU6xjy5qjQf+L+AoFu63r43/P5HsQFw5dGhvEN8UBVITOHb8wfQO0meaR9Faj2vhaPIaHxlz2/0zAt3DkkW91/4HZ7aLJWqQqm67fS6rMuwxPxOur7lt8BBotQcfG8l63NJCyHoM/QdbPg7Tq/vhv8zOIHvZJZKVO/k0tsb7BPQiM98ag4DM7F8SIVUXMnmZH/sNU0zfX9tDUFqG5crcOkkp1WP5OzWy3TI7t62uTcLIs0TbyZPnE2/43MAn//aEoC3idnzLx3thODMSejV2skPtc0sKW4qzKdFH/E9463fmLduwAeDNlWFXsEFj6DsOHH+dRqCvC4RVNJuw29h/MxwVJpRqpy4ONmd7nRlp5nDS+yPk2wysgueqAi9moeEPnKrkUzzYxDEhhql4VciYMlzMgJV3oa3vLvu97s3ET84RfdnlrvZ3mLQ5BBN0GHB8jUTUfd8026hVT8tREVpJO1/iu2puzEXaeiE0TfnVKFHqezMvHRuzFP8arcsmGXOiQm1cDoyH9zKF9YHVKoDuyWji90WFLebzjI6U27qmdriU0CCBorQ2EaijG8j4hV3CRlMHs2qPG0CTmo23oxNFIFiw2nxstRAYa2vi4awrowL3AdxZqvIa0dVcBERKnNPOWBj7Ug7Zyp9d8F2gWmd2Zn4vCK5tXjud3nRZadmvWPtYxrbEuB3TmTwvfa3D6p/pNEtAU4wGoa0Uz9XRVUgqvXAfrsXqgw//vF/ZiBLVYtfAlPspikNA5NnwPI7KwTKvJ3hrmA= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(8676002)(5660300002)(2906002)(2616005)(36860700001)(186003)(107886003)(966005)(16526019)(55016002)(70586007)(36756003)(70206006)(356005)(47076005)(6916009)(1076003)(7636003)(26005)(426003)(7696005)(8936002)(336012)(82310400003)(83380400001)(6666004)(508600001)(86362001)(54906003)(4326008)(316002)(6286002); DIR:OUT; SFP:1101; X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 07:46:21.0452 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c6d41ed-fda6-4a7a-974c-08d9920b609b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2640 Subject: [dpdk-ci] [PATCH v3 05/10] tools: add functionality for setting pw delegates X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" A new command was added to set patch delegates in Patchwork based on the emails found in DPDK's MAINTAINERS file. Example usage: $ export MAINTAINERS_FILE_PATH=/path/to/dpdk/MAINTAINERS $ ./pw_maintainers_cli.py --type series set_pw_delegate SERIES_ID Signed-off-by: Ali Alnubani --- Changes in v3: - Added an argument to force overriding delegates (Suggested by Thomas Monjalon). tools/pw_maintainers_cli.py | 57 +++++++++++++++++++++++++++++++++++-- 1 file changed, 54 insertions(+), 3 deletions(-) diff --git a/tools/pw_maintainers_cli.py b/tools/pw_maintainers_cli.py index 4c95755..0e9643f 100755 --- a/tools/pw_maintainers_cli.py +++ b/tools/pw_maintainers_cli.py @@ -14,6 +14,7 @@ from requests.exceptions import HTTPError from git_pw import config from git_pw import api from git_pw import utils +from git_pw import patch as git_pw_patch """ Description: @@ -84,6 +85,33 @@ class GitPW(object): else: raise + def set_delegate(self, patch_list, delegate, force=False): + """Set the delegate for a patch. + If 'force' isn't set to True, only set a delegate for patches that + don't have one set already. + + Reference: + https://github.com/getpatchwork/git-pw/blob/76b79097dc0a57c89b45dd53d9cacb7ff7b31bb2/git_pw/patch.py#L167 + """ + users = api.index('users', [('q', delegate)]) + if len(users) != 1: + # Zero or multiple users found + print('Cannot choose a Patchwork user to delegate to from ' + 'user list ({}). Skipping..'.format(users)) + return + for patch in patch_list: + if patch['delegate'] != None and \ + (patch['delegate'].get('email') == users[0].get('email') or \ + not force): + print('Patch {} is already delegated to {}. ' + 'Skipping..'.format( + patch['id'], patch['delegate']['email'])) + continue + print("Delegating patch {} to {}..".format( + patch['id'], users[0]['email'])) + _ = api.update( + 'patches', patch['id'], [('delegate', users[0]['id'])]) + class Diff(object): @@ -286,16 +314,22 @@ if __name__ == '__main__': default=os.environ.get('PW_TOKEN', utils.git_config('pw.token')), help='Authentication token') + parser.add_argument( + '--force_set_delegate', + action='store_true', required=False, + help='Force setting the PW delegate, ' + 'even if it is already set.') parser.add_argument( 'command', choices=[ - 'list_trees', 'list_maintainers'], + 'list_trees', 'list_maintainers', 'set_pw_delegate'], help='Command to perform') parser.add_argument( 'id', type=int, help='patch/series id') args = parser.parse_args() + force_set_delegate = args.force_set_delegate command = args.command resource_type = args.type _id = args.id @@ -325,5 +359,22 @@ if __name__ == '__main__': if command == 'list_trees': print(tree.split('/')[-1]) - elif command == 'list_maintainers': - print(*maintainers.get_maintainers(tree), sep='\n') + if command in ['list_maintainers', 'set_pw_delegate']: + maintainer_list = maintainers.get_maintainers(tree) + if command == 'list_maintainers': + print(*maintainer_list, sep='\n') + elif command == 'set_pw_delegate': + if len(maintainer_list) > 0: + # Get the email of the first maintainer in the list. + try: + delegate = re.match( + r".*\<(?P.*)\>", + maintainer_list[0]).group('email') + except AttributeError: + print("Unexpected format: '{}'".format(maintainer_list[0])) + sys.exit(1) + _git_pw.set_delegate( + patch_list, delegate, + force=force_set_delegate) + else: + print('No maintainers found. Not setting a delegate.') -- 2.25.1