DPDK CI discussions
 help / color / mirror / Atom feed
From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: David Marchand <david.marchand@redhat.com>,
	David Hunt <david.hunt@intel.com>
Cc: dev <dev@dpdk.org>, ci@dpdk.org, Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-ci] distributor test failure in UNH CI on ARM
Date: Mon, 11 Jan 2021 11:37:13 +0100	[thread overview]
Message-ID: <263e6c13-b87c-2fe0-36ef-ac6aa600c18f@partner.samsung.com> (raw)
In-Reply-To: <CAJFAV8wun5ec_mWHz_5cxLw=PpgApragNxtVK=gP1gZ7YDLRQw@mail.gmail.com>

Hello David,

I took a look at the logs. The issue appeared in testing big burst in 
sanity_test() for burst implementation of distributor.

My guess is that the cyclic buffer for holding packets returned from 
workers might be overflown and dropping some of the packets. It's 
designed this way, to hold only 127 latest packets. Older, not collected 
on time with rte_distributor_returned_pkts(), are lost.

Although it's just a guess until I can confirm it with some tests on my 
machine.

However the guess is possible, so the question is about the 
functionality of collecting the returned packets.
We can:
1) keep it as is and fix tests not to send new packets until old ones 
are returned and collected
2) make changes to the distributor library and change behavior of the 
returned packages queue - however this requires some discussion as any 
solution will have its drawbacks (e.g. blocking workers until there is a 
place to store packets or using more space for the queue)

Write, what do you think about it.

Meanwhile I'll try to reproduce the issue


Best regards

Lukasz

W dniu 11.01.2021 o 09:14, David Marchand pisze:
> Hello guys,
>
> UNH CI is raising failures on a ARM server for the distributor test:
> https://protect2.fireeye.com/v1/url?k=ebf50f8c-b46e3693-ebf484c3-000babdfecba-48457a70d8248142&q=1&e=9f688513-9c17-4e71-a095-953f146ca22a&u=https%3A%2F%2Flab.dpdk.org%2Fresults%2Fdashboard%2Fpatchsets%2F15077%2F
>
> Worker 59 handled 0 packets
> Worker 60 handled 0 packets
> Worker 61 handled 0 packets
> Worker 62 handled 0 packets
> Sanity test with non-zero hashes done
> === testing big burst (burst) ===
> line 258: Missing packets, expected 783
> Test Failed
> RTE>>
> --- stderr ---
>
>
-- 
Lukasz Wojciechowski
Principal Software Engineer

Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com


  reply	other threads:[~2021-01-11 10:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210111081428eucas1p1f5f234cef3e3582ab8ba2726d8d105ea@eucas1p1.samsung.com>
2021-01-11  8:14 ` David Marchand
2021-01-11 10:37   ` Lukasz Wojciechowski [this message]
2021-01-11 13:04     ` David Marchand
2021-01-11 13:08   ` David Marchand
2021-01-11 13:54     ` [dpdk-ci] [dpdk-dev] " Jerin Jacob
2021-01-11 13:56       ` Lincoln Lavoie
2021-01-11 14:04         ` Jerin Jacob
2021-01-11 14:19           ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
2021-01-19  4:02             ` Lukasz Wojciechowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=263e6c13-b87c-2fe0-36ef-ac6aa600c18f@partner.samsung.com \
    --to=l.wojciechow@partner.samsung.com \
    --cc=aconole@redhat.com \
    --cc=ci@dpdk.org \
    --cc=david.hunt@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).