DPDK CI discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Chen, Zhaoyan" <zhaoyan.chen@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
	"ci@dpdk.org" <ci@dpdk.org>, sys_stv <sys_stv@intel.com>
Subject: Re: [dpdk-ci] Failures reported by Intel CI for series 10551
Date: Tue, 30 Jun 2020 09:13:13 +0200	[thread overview]
Message-ID: <3058617.Y82Z3WsNMf@thomas> (raw)
In-Reply-To: <BYAPR11MB33173FC1D474311841EB9E858B6F0@BYAPR11MB3317.namprd11.prod.outlook.com>

I replied in Bugzilla.
Let's not duplicate the discussion please.
At this point, we should continue in Bugzilla.
Thanks

30/06/2020 07:59, Chen, Zhaoyan:
> Hi all,
> 
> I have updated the info for this issue in bugzilla.
> 
> 
> We have re-built the patchset. It was passed. The root cause is that patches in the  series are disorder by patchid. (patch 7/9 and patch 8/9). Usually, we apply patches by the order of patch id in a series. 
> 
> Why the issue is exposed this time?
> 
> Meet 2 conditions,
> - the patches are disorder in the series
> - the disordered patches are modified same file
> 
> Solution
> - Change applying patch order by patch date, rather than patch id in patchwork.
> But we don't know if patch date is unique and ordered for each patch in the series. 
> We need patchwork document to confirm. So far, its good.
> 
> 
> For Thomas' suggestion, "sending the series report only on the last patch of the series", currently, I find all reports iol-* are sent to the first patch in the series. Shall we align? and shall we get feedback from all maintainers or developers in the community?
> 
> 
> 
> Regards,
> Zhaoyan Chen
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Friday, June 26, 2020 6:24 PM
> > To: Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Cc: ci@dpdk.org; sys_stv <sys_stv@intel.com>; David Marchand
> > <david.marchand@redhat.com>
> > Subject: Re: [dpdk-ci] Failures reported by Intel CI for series 10551
> > 
> > 26/06/2020 09:43, David Marchand:
> > > On Fri, Jun 26, 2020 at 5:03 AM Chen, Zhaoyan
> > <zhaoyan.chen@intel.com> wrote:
> > > >
> > > > Hi, David,
> > > >
> > > > For your question, "Is it normal to see all patches with the exact same
> > test report?"
> > > > Yes, we always test a series, rather than a single patch. You can
> > > > see the exact same report on any patch in a series. (it's
> > > > convenient, you don't need backward to search the header of the
> > > > series, then check result)
> > >
> > > Convenience is subject to interpretation :-).
> > > Other CI systems send a single report which is more sane for me.
> > 
> > I think these tests have 2 purposes:
> > 	- sending quick error feedback to the author
> > 	- check that all is green before merging In both cases we don't
> > need to have the same report duplicated, because we check for failures in
> > all patches anyway.
> > 
> > I suggest sending the series report only on the last patch of the series.
> > 
> 
> 






      reply	other threads:[~2020-06-30  7:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23  7:07 David Marchand
2020-06-24 14:19 ` Lincoln Lavoie
2020-06-25 14:20   ` David Marchand
2020-06-26  3:03 ` Chen, Zhaoyan
2020-06-26  7:43   ` David Marchand
2020-06-26 10:23     ` Thomas Monjalon
2020-06-30  5:59       ` Chen, Zhaoyan
2020-06-30  7:13         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3058617.Y82Z3WsNMf@thomas \
    --to=thomas@monjalon.net \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=sys_stv@intel.com \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).