From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ci-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E637FA0A05
	for <public@inbox.dpdk.org>; Wed, 20 Jan 2021 01:06:04 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DC06B140F3B;
	Wed, 20 Jan 2021 01:06:04 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 69997140EDC;
 Wed, 20 Jan 2021 01:06:03 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id CCFAE5C0112;
 Tue, 19 Jan 2021 19:06:01 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Tue, 19 Jan 2021 19:06:01 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 OVqMT4Y6KBMKHlgO5svX4SqJaPmG9IXVupYbrPi6vb0=; b=PfICT5v+Fg25PLg8
 V+7D/TYPTQm+sRGCV9UqXnc2sIFK+l9hgETr35PcZwh5v7eu7XvCGLTw1T+JR3fo
 JPPYDg1h5o6oreGUF4cUI5Tv952BD//IHoe97OmDgL+4IQaYQotXnCTgaJYHELGQ
 ft8+G0SY0asld+uOzyjIDe1YxnpiylDm1UnoZ5puPco11N2f/PLqHSdaiywoxpjd
 2u6mQ5cknqDxMB7UZkNp46RHarA1lWGi1vowc8HACtMVidFjwcjcHmNuE1In/nL1
 uA7EJU3sbudnOLfHNVPYWkwOLZLrYwNk5OSIDWXkPl1dFkjNjKv/LBDnTNWtwoxi
 8lNqFg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=OVqMT4Y6KBMKHlgO5svX4SqJaPmG9IXVupYbrPi6v
 b0=; b=X4f10D+zozCT5/n6HH5B1+opfx1KtvJ1i5rWqSSXpEednAyCW6zDYPn9G
 JZ8XYNC0hLRQNuATHq9MYZBSyKV/TY0UThke0B6y2SC79gMlQjtufn2zZmo5oH3n
 fLn6MiekQL+gxvi+tciGK2QuVeiSBXUtmmZEo4pzjrQfBfMMjxNbK8SefnTeDnl/
 MWKbbwA9GV2d6Vprp2C8UJAM5lSg56h1N0kO6BfJu1htoIitdK2/z82Pp2GxdM5z
 iwh+HahXUPc6wKy4SZv72Wd3BJfuKkDysEqiGr7l0xtRbOteTElPVFNMS5ENcbnd
 OihfTL0A/H0GQnb8hJV+ZbVFgo1Ng==
X-ME-Sender: <xms:6XMHYNI_tEYByrkkbM4Kp-brX_6Z2Uvlrf4V7FRISpagylDwchxCOg>
 <xme:6XMHYCyLQtlpI-o3SOmm28XBRz5dy36LwQIB5iQ9Q9F_-dN0s0xE4AoN-xwIbwr4m
 O43Q0cM1cqhxrQMeg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugddukecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
 frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
 iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
 iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
 nhdrnhgvth
X-ME-Proxy: <xmx:6XMHYFvBwHBQioxPngFghiEgf_hhIVisAO5NgoaU63wveD-OCeNVfg>
 <xmx:6XMHYBseLI7JXqvtdsf5-5qFvfau3vOimqXlsRJsmw_6fwppsQaItQ>
 <xmx:6XMHYCOXgz-_1ZEC49n0bTG7mbY4xglk98HcXZaGUXPt_cybW2NcvA>
 <xmx:6XMHYPGfeHC3NjH86Z1seyh9-rGBsFgm8fxPYm3WriRFeP6weD9t-w>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4953C1080063;
 Tue, 19 Jan 2021 19:06:00 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, ci@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
 David Marchand <david.marchand@redhat.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Aaron Conole <aconole@redhat.com>,
 Bruce Richardson <bruce.richardson@intel.com>, ferruh.yigit@intel.com
Date: Wed, 20 Jan 2021 01:05:59 +0100
Message-ID: <5629972.kJsfQy86Dy@thomas>
In-Reply-To: <20201020174404.28653-3-dmitry.kozliuk@gmail.com>
References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com>
 <20201020174404.28653-1-dmitry.kozliuk@gmail.com>
 <20201020174404.28653-3-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen
X-BeenThere: ci@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK CI discussions <ci.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/ci>,
 <mailto:ci-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/ci/>
List-Post: <mailto:ci@dpdk.org>
List-Help: <mailto:ci-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/ci>,
 <mailto:ci-request@dpdk.org?subject=subscribe>
Errors-To: ci-bounces@dpdk.org
Sender: "ci" <ci-bounces@dpdk.org>

This is now the right timeframe to introduce this change
with the new Python module dependency.
Unfortunately, the ABI check is returning an issue:

'const char mlx5_common_pci_pmd_info[62]' was changed
to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c


Few more comments below:

20/10/2020 19:44, Dmitry Kozlyuk:
> --- a/buildtools/meson.build
> +++ b/buildtools/meson.build
> +if host_machine.system() != 'windows'

You can use "is_windows".


> --- a/doc/guides/linux_gsg/sys_reqs.rst
> +++ b/doc/guides/linux_gsg/sys_reqs.rst
> +*   ``pyelftools`` (version 0.22+)

This requirement is missing in doc/guides/freebsd_gsg/build_dpdk.rst


> --- a/meson.build
> +++ b/meson.build
> -subdir('buildtools/pmdinfogen')

This could be in patch 3 (removing the code).