DPDK CI discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Adam Hassick <ahassick@iol.unh.edu>, Patrick Robb <probb@iol.unh.edu>
Cc: Aaron Conole <aconole@redhat.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	 ci@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: Adding Series Dependency to Patchwork
Date: Fri, 19 Jul 2024 18:40:51 +0100	[thread overview]
Message-ID: <76332523-96ac-407d-b937-c1f8a99808fa@amd.com> (raw)
In-Reply-To: <CAC-YWqhOsjumfsmvuCv=HbA0MrpoKfpj-K7L6fQKUV_tWwPzMg@mail.gmail.com>

On 7/12/2024 9:15 PM, Adam Hassick wrote:
> Hi All,
> 
> We've gotten a review of our initial submission to add the dependency
> parsing to the Patchwork dashboard. Stephen recommends that we change
> our format to use the message ID of patches or cover letters rather
> than the ID of the patch or series in the database. So, instead of
> adding a dependency by adding "Depends-on: series-5678" one would add
> "Depends-on: <20240712120000-1-user@example.com>". We can keep the
> option of using the patchwork web URLs that was discussed in the
> original issue on GitHub.
> 

I wasn't aware that patchwork has target to abstract/hide the integer
IDs, in this case since we want to enable this feature in the patchwork,
it makes sense to follow their path.
No need to push for integer IDs, that was something we thought as an
option, it is not crucial for us, we can change it.

But there is another thing Stephen mentioned, perhaps using URL instead
of message ID.
Even message ID gives more data, it may still require some effort for
someone investigating the patch to access to that dependent
patch/series. But using URL gives instant access.
If using URL doesn't make like harder for the patchwork implementation,
I am for using URL. From patch developer perspective, I think providing
message ID or patchwork URL are similar level of hassle.

If we go with the URL option, does is still required to differentiate as
"patch-xxx" or "series-yyy", previously they were different IDs, but
with URL can patchwork deduce if it is series or patch? If so this can
bring a simplification.


> The main reasoning for this is that our format doesn't make it clear
> exactly what the dependency is or where it's found outside of the
> context of Patchwork. This discussion can be viewed here:
> http://patchwork.ozlabs.org/project/patchwork/patch/20240617221900.156155-3-ahassick@iol.unh.edu/
> 
> Does this change sound reasonable?
> 
> Regards,
> Adam


  parent reply	other threads:[~2024-07-19 17:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 19:51 Adam Hassick
2024-04-04 13:50 ` Patrick Robb
2024-04-05  6:41   ` Thomas Monjalon
2024-04-11 14:18     ` Aaron Conole
2024-04-11 14:33       ` Patrick Robb
2024-07-12 20:15         ` Adam Hassick
2024-07-19 15:32           ` Patrick Robb
2024-07-19 17:43             ` Ferruh Yigit
2024-07-19 17:40           ` Ferruh Yigit [this message]
2024-07-22 16:16             ` Adam Hassick
2024-07-22 16:28               ` Patrick Robb
2024-07-23 12:41                 ` Aaron Conole
     [not found]                 ` <6b425d90-78b2-497b-958c-9d36e2ba6e3b@amd.com>
2024-07-23 15:36                   ` Patrick Robb
2024-07-23 16:08                     ` Ferruh Yigit
2024-07-24 15:07                       ` Adam Hassick
2024-07-25  9:47                         ` Ferruh Yigit
2024-07-25 17:52                           ` Patrick Robb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76332523-96ac-407d-b937-c1f8a99808fa@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=aconole@redhat.com \
    --cc=ahassick@iol.unh.edu \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=probb@iol.unh.edu \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).