From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Patrick Robb <probb@iol.unh.edu>, Adam Hassick <ahassick@iol.unh.edu>
Cc: Aaron Conole <aconole@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
ci@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: Adding Series Dependency to Patchwork
Date: Fri, 19 Jul 2024 18:43:45 +0100 [thread overview]
Message-ID: <7ebbc33f-609f-4dad-8575-bc674a862490@amd.com> (raw)
In-Reply-To: <CAJvnSUCotuHCvqDpaDr5C0MHD29MkF=ayXp4CcC=wQdxTmidZQ@mail.gmail.com>
On 7/19/2024 4:32 PM, Patrick Robb wrote:
> My view is that if the patchwork project is trying to get away from
> integer based series dependencies and use a more authoritative key
> like the message ID when associating series, we should follow suit in
> terms of DPDK submission guidelines. So I think the "Depends-on:
> <20240712120000-1-user@example.com>" format sounds fine.
>
> But, obviously this will require a policy change and update to the
> DPDK submission guidelines, so I'm curious what others outside of UNH
> think.
>
I am not much worried of the changing PDK submission guidelines, this is
not used very actively anyway, so impact will be low.
> I will add it to the discussion list for next Thursday's CI meeting.
>
> Thanks Adam.
>
> On Fri, Jul 12, 2024 at 4:14 PM Adam Hassick <ahassick@iol.unh.edu> wrote:
>>
>> Hi All,
>>
>> We've gotten a review of our initial submission to add the dependency
>> parsing to the Patchwork dashboard. Stephen recommends that we change
>> our format to use the message ID of patches or cover letters rather
>> than the ID of the patch or series in the database. So, instead of
>> adding a dependency by adding "Depends-on: series-5678" one would add
>> "Depends-on: <20240712120000-1-user@example.com>". We can keep the
>> option of using the patchwork web URLs that was discussed in the
>> original issue on GitHub.
>>
>> The main reasoning for this is that our format doesn't make it clear
>> exactly what the dependency is or where it's found outside of the
>> context of Patchwork. This discussion can be viewed here:
>> http://patchwork.ozlabs.org/project/patchwork/patch/20240617221900.156155-3-ahassick@iol.unh.edu/
>>
>> Does this change sound reasonable?
>>
>> Regards,
>> Adam
next prev parent reply other threads:[~2024-07-19 17:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 19:51 Adam Hassick
2024-04-04 13:50 ` Patrick Robb
2024-04-05 6:41 ` Thomas Monjalon
2024-04-11 14:18 ` Aaron Conole
2024-04-11 14:33 ` Patrick Robb
2024-07-12 20:15 ` Adam Hassick
2024-07-19 15:32 ` Patrick Robb
2024-07-19 17:43 ` Ferruh Yigit [this message]
2024-07-19 17:40 ` Ferruh Yigit
2024-07-22 16:16 ` Adam Hassick
2024-07-22 16:28 ` Patrick Robb
2024-07-23 12:41 ` Aaron Conole
[not found] ` <6b425d90-78b2-497b-958c-9d36e2ba6e3b@amd.com>
2024-07-23 15:36 ` Patrick Robb
2024-07-23 16:08 ` Ferruh Yigit
2024-07-24 15:07 ` Adam Hassick
2024-07-25 9:47 ` Ferruh Yigit
2024-07-25 17:52 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ebbc33f-609f-4dad-8575-bc674a862490@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aconole@redhat.com \
--cc=ahassick@iol.unh.edu \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).