Re: [PATCH v1] drivers/net: use internal API to get eth dev from name

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 2/7/2022 4:47 PM, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, February 7, 2022 6:37 PM
>> To: Ali Alnubani <alialnu@nvidia.com>; kumaraparameshwaran rathinavel
>> <kumaraparamesh92@gmail.com>; dev@dpdk.org; dpdklab
>> <dpdklab@iol.unh.edu>
>> Cc: Kumara Parameshwaran <kparameshwar@vmware.com>; ci@dpdk.org
>> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from
>> name
>>
>> On 2/7/2022 4:08 PM, Ali Alnubani wrote:
>>>> -----Original Message-----
>>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> Sent: Thursday, February 3, 2022 1:32 PM
>>>> To: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>;
>>>> dev@dpdk.org
>>>> Cc: Kumara Parameshwaran <kparameshwar@vmware.com>;
>> ci@dpdk.org;
>>>> Ali Alnubani <alialnu@nvidia.com>
>>>> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from
>>>> name
>>>>
>>>> On 2/3/2022 11:09 AM, kumaraparameshwaran rathinavel wrote:
>>>>> Ferruh,
>>>>>
>>>>> Since in the older patch we had introduced rte_eth_dev_get_by_name
>>>> patch and had been merged to dpdk-next-net, the current patch failed
>> for
>>>> the build when I submitted the patch. Is there a way to enforce it to dpdk-
>>>> next-net ?
>>>>>
>>>>
>>>> CIs apply it onto the main repo, there is a script that chose which
>>>> tree to apply, it seems it is not working as expected for the
>>>> 'drivers/net:' case, cc'ed ci mail list and @Ali for it.
>>>>
>>>
>>> Sorry for the delayed response,
>>>
>>> The script (https://git.dpdk.org/tools/dpdk-
>> ci/tree/tools/pw_maintainers_cli.py) correctly chooses next-net for this
>> patch:
>>> $ MAINTAINERS_FILE_PATH=/path/to/MAINTAINERS
>> tools/pw_maintainers_cli.py --type patch list-trees 106830
>>> Output: dpdk-next-net
>>>
>>> Did the script fail for some reason during this build?
>>
>> In the community CI, initially it tried to build the patch on top of main repo,
>> and it failed.
>>
>> Build looks OK now since I manually triggered re-build it on top of next-net.
> 
> Hi Ferruh,
> 
> Did the job initially decide to apply on main repo because it was chosen by the script?

That is my understanding. Community CI decides which repo to apply based on
your script, as far as I know. But I don't know if there may be any version
difference etc..

> Is it possible to see the pw_maintainers_cli.py command that was used and its output?

I don't know, maybe community CI maintainers may know.