From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A664EA3160 for ; Thu, 10 Oct 2019 18:14:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8450F1E9B5; Thu, 10 Oct 2019 18:14:38 +0200 (CEST) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id A00B51E935 for ; Thu, 10 Oct 2019 18:14:35 +0200 (CEST) Received: by mail-lf1-f68.google.com with SMTP id u28so4834289lfc.5 for ; Thu, 10 Oct 2019 09:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0gsDNgQpdtLW+OGYUKKhGPHxq5+8cizyp17CS/dQ9+E=; b=XCAJTF7/laN+aLts7qfgP3nZ3UuBWcn8OUwubL/N7xgwWu5otWmgHJ6sd4BmjAtgGM v7tQ1rCV/2VKpbMNlE10VjxJtntyFfSKn4FHbcoaSEO5X7UTVOanIuBrvrJefTyaSxLc nCD0ZnyabBSg4UNS6kthIipX9qJI4y+6LXAPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0gsDNgQpdtLW+OGYUKKhGPHxq5+8cizyp17CS/dQ9+E=; b=Bli92BHEmyCHz/oVyjcBaKIkbbv0Rneu2uszYli90CxscNJ95DnLSJo4rjlcFYlvbZ DsVRJHk6ZRhT8A06UHqCuL+2zP+L4dlV8AGUj0HRShpQwA2gb6NDB/hTAIyq6RyXprqB AWcxuhTG8xwTBFSKXcuOHIx3A7RC0mbBXeYXLTWFQ7R1wewXPFIekH00tn8uIGzgAeXl YLtZ4XTuIIXWUzd4q1a7EcnjOUgtoujjBjyj9S9b6qHEs4tgbjHZ5o3A5RJiNk3rnDV6 WsUQkWa0y8qWFqTHmivu+VUHkeNW3XhKUlPF2NVxJ76V63rsQtQ/7R4/8RwAGsInPwaL VoQA== X-Gm-Message-State: APjAAAWOiAburepIiVgNjUjVBUcYkh8Ygr/juVH7xeEs6VK/8ORU9xw0 26rXgPoEBveq1IP3X0s641Wx2cosMrC3YcwGoNJhqQ== X-Google-Smtp-Source: APXvYqwwqOeQM/8lB1CdihDLlvsR4Dz3XYhd4HksAfVgs4n18W8CPgS+7nVb8zOfHKnTbQHcIVrXvuEG3jeKt9Cbyq0= X-Received: by 2002:a19:491c:: with SMTP id w28mr6418981lfa.124.1570724074997; Thu, 10 Oct 2019 09:14:34 -0700 (PDT) MIME-Version: 1.0 References: <20191010093456.47037-1-mb@smartsharesystems.com> <20191010093456.47037-2-mb@smartsharesystems.com> <98CBD80474FA8B44BF855DF32C47DC35C60B72@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C60B72@smartserver.smartshare.dk> From: Jeremy Plsek Date: Thu, 10 Oct 2019 12:13:58 -0400 Message-ID: To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: ci@dpdk.org, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-ci] [PATCH v6 1/2] mbuf: add bulk free function X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" Hi Morten, Sometimes the tests report a false positive. Unfortunately, there isn't a way yet for tests to be reran by contributors. At the moment, only the environment owners (in this case, some members from the Intel team) and I (who maintains the "iol" prefixed CI) can rerun the test. Depending on the patch, the maintainers should realize that a patch shouldn't be reporting a failure and ignore the result (or rerun if they are able to). I've reran the test for you. Although, I've noticed a new patch version was sent (and passed), so it won't really make a difference. Thanks On Thu, Oct 10, 2019 at 10:13 AM Morten Br=C3=B8rup wrote: > > Hi CI Team, > > Although my patch only adds a single function, which is not being called = from anywhere, the patch failed the iol-intel-Performance test: > http://mails.dpdk.org/archives/test-report/2019-October/101829.html > > So I think something went wrong with the test environment. > > Is there any way to trigger a re-run of the test? > > > Med venlig hilsen / kind regards > - Morten Br=C3=B8rup > > > > -----Original Message----- > > From: Morten Br=C3=B8rup [mailto:mb@smartsharesystems.com] > > Sent: Thursday, October 10, 2019 11:35 AM > > To: dev@dpdk.org > > Cc: olivier.matz@6wind.com; stephen@networkplumber.org; > > harry.van.haaren@intel.com; konstantin.ananyev@intel.com; > > mattias.ronnblom@ericsson.com; bruce.richardson@intel.com; > > arybchenko@solarflare.com; Morten Br=C3=B8rup > > Subject: [PATCH v6 1/2] mbuf: add bulk free function > > > > Add function for freeing a bulk of mbufs. > > > > Signed-off-by: Morten Br=C3=B8rup > > Acked-by: Konstantin Ananyev > > Reviewed-by: Andrew Rybchenko > > > > --- > > > > v6: > > * Remove __rte_always_inline from static function. > > The compiler will inline anyway. > > v5: > > * Rename variables from "free" to "pending" for improved readability. > > * Add prefix __ to rte_pktmbuf_free_seg_via_array(). > > * Add array size parameter to __rte_pktmbuf_free_seg_via_array(). > > The compiler will optimize the parameter away anyway. > > * Add description to __rte_pktmbuf_free_seg_via_array(). > > * Minor description updates. > > v4: > > * Mark as experimental by adding __rte_experimental. > > * Add function to experimental section of map file. > > * Fix source code formatting regarding pointer to pointer. > > * Squash multiple modifications into one. > > v3: > > * Bugfix: Handle pakets with multiple segments. > > * Add inline helper function, mainly for readability. > > * Fix source code formatting regarding indentation. > > v2: > > * Function is not inline. > > * Optimize to free multible mbufs belonging to the same mempool in > > bulk. Inspired by ixgbe_tx_free_bufs(), but allowing NULL pointers > > in the array, just like rte_pktmbuf_free() can take a NULL pointer. > > * Use unsigned int instead of unsigned. Passes checkpatch, but > > mismatches the original coding style of the modified files. > > * Fix a typo in the description headline: mempools is plural. > > > > --- > > lib/librte_mbuf/rte_mbuf.c | 66 ++++++++++++++++++++++++++++ > > lib/librte_mbuf/rte_mbuf.h | 15 +++++++ > > lib/librte_mbuf/rte_mbuf_version.map | 1 + > > 3 files changed, 82 insertions(+) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > > index 37718d49c..de5659baa 100644 > > --- a/lib/librte_mbuf/rte_mbuf.c > > +++ b/lib/librte_mbuf/rte_mbuf.c > > @@ -245,6 +245,72 @@ int rte_mbuf_check(const struct rte_mbuf *m, int > > is_header, > > return 0; > > } > > > > +/** > > + * @internal helper function for freeing a bulk of packet mbuf > > segments > > + * via an array holding the packet mbuf segments from the same mempool > > + * pending to be freed. > > + * > > + * @param m > > + * The packet mbuf segment to be freed. > > + * @param pending > > + * Pointer to the array of packet mbuf segments pending to be freed. > > + * @param nb_pending > > + * Pointer to the number of elements held in the array. > > + * @param pending_sz > > + * Number of elements the array can hold. > > + * Note: The compiler should optimize this parameter away when using > > a > > + * constant value, such as RTE_PKTMBUF_FREE_PENDING_SZ. > > + */ > > +static __rte_always_inline void > > +__rte_pktmbuf_free_seg_via_array(struct rte_mbuf *m, > > + struct rte_mbuf ** const pending, unsigned int * const > > nb_pending, > > + const unsigned int pending_sz) > > +{ > > + m =3D rte_pktmbuf_prefree_seg(m); > > + if (likely(m !=3D NULL)) { > > + if (*nb_pending =3D=3D pending_sz || > > + (*nb_pending > 0 && m->pool !=3D pending[0]->pool)) { > > + rte_mempool_put_bulk(pending[0]->pool, > > + (void **)pending, *nb_pending); > > + *nb_pending =3D 0; > > + } > > + > > + pending[(*nb_pending)++] =3D m; > > + } > > +} > > + > > +/** > > + * Size of the array holding mbufs from the same membool pending to be > > freed > > + * in bulk. > > + */ > > +#define RTE_PKTMBUF_FREE_PENDING_SZ 64 > > + > > +/* Free a bulk of packet mbufs back into their original mempools. */ > > +void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, unsigned int > > count) > > +{ > > + struct rte_mbuf *m, *m_next, > > *pending[RTE_PKTMBUF_FREE_PENDING_SZ]; > > + unsigned int idx, nb_pending =3D 0; > > + > > + for (idx =3D 0; idx < count; idx++) { > > + m =3D mbufs[idx]; > > + if (unlikely(m =3D=3D NULL)) > > + continue; > > + > > + __rte_mbuf_sanity_check(m, 1); > > + > > + do { > > + m_next =3D m->next; > > + __rte_pktmbuf_free_seg_via_array(m, > > + pending, &nb_pending, > > + RTE_PKTMBUF_FREE_PENDING_SZ); > > + m =3D m_next; > > + } while (m !=3D NULL); > > + } > > + > > + if (nb_pending > 0) > > + rte_mempool_put_bulk(pending[0]->pool, (void **)pending, > > nb_pending); > > +} > > + > > /* dump a mbuf on console */ > > void > > rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index 98225ec80..a02c8b12c 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -1907,6 +1907,21 @@ static inline void rte_pktmbuf_free(struct > > rte_mbuf *m) > > } > > } > > > > +/** > > + * Free a bulk of packet mbufs back into their original mempools. > > + * > > + * Free a bulk of mbufs, and all their segments in case of chained > > buffers. > > + * Each segment is added back into its original mempool. > > + * > > + * @param mbufs > > + * Array of pointers to packet mbufs. > > + * The array may contain NULL pointers. > > + * @param count > > + * Array size. > > + */ > > +__rte_experimental > > +void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, unsigned int > > count); > > + > > /** > > * Creates a "clone" of the given packet mbuf. > > * > > diff --git a/lib/librte_mbuf/rte_mbuf_version.map > > b/lib/librte_mbuf/rte_mbuf_version.map > > index 2662a37bf..cd6154ef2 100644 > > --- a/lib/librte_mbuf/rte_mbuf_version.map > > +++ b/lib/librte_mbuf/rte_mbuf_version.map > > @@ -50,4 +50,5 @@ EXPERIMENTAL { > > global: > > > > rte_mbuf_check; > > + rte_pktmbuf_free_bulk; > > } DPDK_18.08; > > -- > > 2.17.1 > --=20 Jeremy Plsek UNH InterOperability Laboratory