From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25B504292B for ; Wed, 12 Apr 2023 23:10:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E70E410F2; Wed, 12 Apr 2023 23:10:54 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 08CD6406A2 for ; Wed, 12 Apr 2023 23:10:52 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id r17so6499004pgr.1 for ; Wed, 12 Apr 2023 14:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1681333851; x=1683925851; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8qnERdT5E1RsWOuG3uN0NZLkYXVRfR6vZW4XQ/M8ymM=; b=WHhL/ihM1RlEYGWpWZNXe8leBD2KzURNc0JmQD0NVfMAbeWIM8WpmuSgZIgn6q2JXh RV59uiToHgjSMcWrPMYh5BoAAnWCTUBcwmsZ3x3BTDbSnsekmwsUs4uT2I2puELQaXzg iAAqX0ZnLOfwV0MSHnFLyYHG1ShxltRopxulc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681333851; x=1683925851; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8qnERdT5E1RsWOuG3uN0NZLkYXVRfR6vZW4XQ/M8ymM=; b=BCXLbN7fJdo4TCeldml1xC2MRUWy6eh+hqvRpCfAxV3cfNkA0ohqHAEO5OlhNU2a+t hhZBCaxmkPpF4xrTxcjTCnHwP/Z6o7fplH3iToFB8aoQ2/MGOnUS8/hhiIxqNIBj6AfI +NaFf+qKexmF7/RTnCQwqNWLAtSlPeWlkXCqhnGbDzJNYmb2qLSD++SUITnH+w0n1G5N e1715SyTYNLyJm2XjolG97I6OB5Ci3heUIg/LF7aRQlbV2ZxozfQUuivBOWNhQrbILqi bXV5iGikUww5wIiSncIPthbTZLT7oqepM0gikVJ1S7iHk7XFfPh30yAa2NRZi7MswHCJ 0Ntg== X-Gm-Message-State: AAQBX9eDH0QfMc9T+xIEjpfLm2gj1dmh2xEZ0htlWx74NuqWMBTN6Rfd dsZKB9hyrqUsCqcsHg51TB0Gbmw4Wn+b1lnCxhevsQ== X-Google-Smtp-Source: AKy350bJ6U21QYVjPbdMeZVyVXI6b9j5vNWxCQ4BGRkg+n5LFoKb65srixGSJmRgAYS8UsUiddUCUaUEihVN3YetBg8= X-Received: by 2002:a63:592:0:b0:513:4c81:d04a with SMTP id 140-20020a630592000000b005134c81d04amr4331699pgf.3.1681333851109; Wed, 12 Apr 2023 14:10:51 -0700 (PDT) MIME-Version: 1.0 References: <20230403183930.12001-2-jspewock@iol.unh.edu> <2276688.ElGaqSPkdT@thomas> In-Reply-To: <2276688.ElGaqSPkdT@thomas> From: Jeremy Spewock Date: Wed, 12 Apr 2023 17:10:40 -0400 Message-ID: Subject: Re: [PATCH v7 0/4] Add ACVP Tool To: Thomas Monjalon Cc: Patrick Robb , Ali Alnubani , "ci@dpdk.org" , Aaron Conole Content-Type: multipart/alternative; boundary="000000000000f1d8ee05f92a0ac7" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --000000000000f1d8ee05f92a0ac7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I can see why you would want to squash everything into one patch; I had just thought that the intention with maintaining the structure of the old patch series was to preserve Brandon's original commits and comments alongside some minor expansion where necessary. If it would be preferred however, I can resubmit with everything squashed into a single patch. Aaron, if you could also review this series and give your thoughts on the matter as well that would be greatly appreciated. Thanks, Jeremy On Wed, Apr 12, 2023 at 4:16=E2=80=AFAM Thomas Monjalon wrote: > Hi, > > Aaron is the maintainer. > I can also push the commits. > > I think you should squash all in one patch > and provide an explanation in the commit message > about what this tool is for exactly. > > > 11/04/2023 23:22, Patrick Robb: > > Hi Ali, > > > > Aaron says he is not a maintainer either. Do you know whether there is > some > > place I can look to see who the current maintainers are? There isn't an > > equivalent to the MAINTAINERS file like in the main DPDK repo. > > > > Thomas, you might be the only current maintainer on this repo. We'll be > > grateful at the lab if you're able to merge this patch. > > > > Best, > > Patrick > > > > On Mon, Apr 10, 2023 at 11:19=E2=80=AFAM Ali Alnubani > wrote: > > > > > > Hi Ali, > > > > > > > > Is this good to be merged since it's been acked by a maintainer wit= h > no > > > more discussion afterwards? Or is there something more to be done her= e? > > > [..] > > > > > > Hello Patrick, > > > > > > Already acked from my side, waiting for a maintainer to merge if they > have > > > no other comments (Thomas/Aaron). > > > > > > Thanks, > > > Ali > > > > --000000000000f1d8ee05f92a0ac7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I can see why you would want to = squash everything into one patch; I had just thought that the intention wit= h maintaining the structure of the old patch series was to preserve Brandon= 's original commits and comments alongside some minor expansion where n= ecessary. If it would be preferred=C2=A0however, I can resubmit with everyt= hing squashed into a single patch.

Aaron, if you c= ould also review this series and give your thoughts on the matter as well t= hat would be greatly appreciated.

Thanks,
Jeremy

On Wed, Apr 12, 2023 at 4:16=E2=80=AFAM Thomas Monjalon <= ;thomas@monjalon.net> wrote:<= br>
Hi,

Aaron is the maintainer.
I can also push the commits.

I think you should squash all in one patch
and provide an explanation in the commit message
about what this tool is for exactly.


11/04/2023 23:22, Patrick Robb:
> Hi Ali,
>
> Aaron says he is not a maintainer either. Do you know whether there is= some
> place I can look to see who the current maintainers are? There isn'= ;t an
> equivalent to the MAINTAINERS file like in the main DPDK repo.
>
> Thomas, you might be the only current maintainer on this repo. We'= ll be
> grateful at the lab if you're able to merge this patch.
>
> Best,
> Patrick
>
> On Mon, Apr 10, 2023 at 11:19=E2=80=AFAM Ali Alnubani <alialnu@nvidia.com> wrot= e:
>
> > > Hi Ali,
> > >
> > > Is this good to be merged since it's been acked by a mai= ntainer with no
> > more discussion afterwards? Or is there something more to be done= here?
> > [..]
> >
> > Hello Patrick,
> >
> > Already acked from my side, waiting for a maintainer to merge if = they have
> > no other comments (Thomas/Aaron).
> >
> > Thanks,
> > Ali



--000000000000f1d8ee05f92a0ac7--