From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B9BE42D26 for ; Thu, 22 Jun 2023 18:19:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25E9140DDA; Thu, 22 Jun 2023 18:19:00 +0200 (CEST) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by mails.dpdk.org (Postfix) with ESMTP id C0700406BA for ; Thu, 22 Jun 2023 18:18:59 +0200 (CEST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-570114e1feaso81884247b3.3 for ; Thu, 22 Jun 2023 09:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1687450739; x=1690042739; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=flG+bQg44PgN7MUwKAFpVjjQr7t7PXH4K/QJjgzk/DU=; b=LRjqpKpU8EU2DdDjbqr+REr1ixWnOmCevMt26OpklX2oQM+GcIoiGjKsbEpzeY6AyH xSIefWb2HzHisK2hA5WlITE6xQ3YLQpIGFMS3DnQbX1ghKZEOm5OyEap/O4tzPG8Rt34 Vfq70jzoMq0G3ewE12GlLJUHS/h2l6g7NJyg4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687450739; x=1690042739; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=flG+bQg44PgN7MUwKAFpVjjQr7t7PXH4K/QJjgzk/DU=; b=MnDYw8ZbAvlI0HDtHscnTviybfTCS+R8BP6oszRItb8sTjCFLQ/hhF9idIi0hpaywb lvuoKhvphAcTSa371F5Yfjm6m6pxa8DeBc4a/f5RCPNrJaax7q22dkUfyPPZ4+UBhe0p 83u681mkZfMBFeTsEWt3W/EOc4M+4YyQgDCtesIoyOFQ7JKaOrijIXWa6dVfFspguwOi 6hgF5U91AU6ErFHDWLs5dLsAV9QyQTRnGb+SRt28uQIqkf/6/yP0VUvA+4bLdgcc3pUQ ZAOMW95Sie+hPzw1Vn56rRrWIgcIxYH4otrRSOMuFacP9TWhdQjE8ZxcKE0/6s3c4Dvn AjLg== X-Gm-Message-State: AC+VfDxpjAY03h1H3InmGbYKcATE5/bzs2MUyA/vgw8ifIZ9xfddUHW1 ipldZpbTaZLPigfZSdeT1cHtRgk1gennpPljxstBJ33cwiijzYZM X-Google-Smtp-Source: ACHHUZ5ERBEhGmsI/8w0Kc3mbetFSeWX0M6u6iUaRWfiHApHAQ13vFo6D2/IohgXA79MDNWaJDGPr8FFmCqkcTDtd20= X-Received: by 2002:a0d:e896:0:b0:565:a0c8:7e66 with SMTP id r144-20020a0de896000000b00565a0c87e66mr17601737ywe.0.1687450739194; Thu, 22 Jun 2023 09:18:59 -0700 (PDT) MIME-Version: 1.0 References: <20230525171505.1276457-1-ahassick@iol.unh.edu> <20230525171505.1276457-4-ahassick@iol.unh.edu> In-Reply-To: From: Adam Hassick Date: Thu, 22 Jun 2023 12:18:48 -0400 Message-ID: Subject: Re: [PATCH v6 3/6] containers/builder: Dockerfile creation script To: Ali Alnubani Cc: "ci@dpdk.org" , "aconole@redhat.com" , Owen Hilyard Content-Type: multipart/alternative; boundary="000000000000e2ce5505feba3d31" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --000000000000e2ce5505feba3d31 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This script is not intended to be run by the end user on their machine's bare environment. The CI worker container will acquire the needed python version to run this script when the container is built; the end user does not need to install python 3.10 themselves. The "make_docker_files_in_container" target in the Makefile is the intended way to call this script. The build and push targets then depend on that target. To me, this appears fine, but let me know if you have any concerns. On Thu, Jun 22, 2023 at 11:55=E2=80=AFAM Ali Alnubani = wrote: > > -----Original Message----- > > From: Adam Hassick > > Sent: Thursday, May 25, 2023 8:15 PM > > To: ci@dpdk.org > > Cc: aconole@redhat.com; Ali Alnubani ; Owen Hilyard > > ; Adam Hassick > > Subject: [PATCH v6 3/6] containers/builder: Dockerfile creation script > > > > From: Owen Hilyard > > > > This script will template out all of the Dockerfiles based on the > > definitions provided in the inventory using the jinja2 templating > > library. > > > [..] > > + > > +def get_host_arch() -> str: > > + machine: str =3D platform.machine() > > + match machine: > > This adds a nondocumented dependency on Python 3.10. > --=20 *Adam Hassick* Senior Developer UNH InterOperability Lab ahassick@iol.unh.edu iol.unh.edu +1 (603) 475-8248 --000000000000e2ce5505feba3d31 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This script is not intended to be run by the end= user on their machine's bare environment. The CI worker container will= acquire the needed python version to run this script when the container is= built; the end user does not need to install python 3.10 themselves. The &= quot;make_docker_files_in_container" target in the Makefile is the int= ended way to call this script. The build and push targets then depend on th= at target.

To me, this appears fine, but let me know if you have any= concerns.

On Thu, Jun 22, 2023 at 11:55=E2=80=AFAM Ali Alnu= bani <alialnu@nvidia.com> w= rote:
> -----= Original Message-----
> From: Adam Hassick <ahassick@iol.unh.edu>
> Sent: Thursday, May 25, 2023 8:15 PM
> To: ci@dpdk.org > Cc: aconole@re= dhat.com; Ali Alnubani <alialnu@nvidia.com>; Owen Hilyard
> <ohilyard= @iol.unh.edu>; Adam Hassick <ahassick@iol.unh.edu>
> Subject: [PATCH v6 3/6] containers/builder: Dockerfile creation script=
>
> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> This script will template out all of the Dockerfiles based on the
> definitions provided in the inventory using the jinja2 templating
> library.
>
[..]
> +
> +def get_host_arch() -> str:
> +=C2=A0 =C2=A0 machine: str =3D platform.machine()
> +=C2=A0 =C2=A0 match machine:

This adds a nondocumented dependency on Python 3.10.


--
Adam Hassick
Senior Developer
UNH InterOperability Lab
+1 (603) 475-8248
--000000000000e2ce5505feba3d31--