From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EF79A0538 for ; Wed, 5 Feb 2020 09:49:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D48D41C12E; Wed, 5 Feb 2020 09:49:04 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 851E01C11A for ; Wed, 5 Feb 2020 09:49:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580892541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ruQTwzTOqAkQNYMiB6b0BZQB5UJtth8jfXzSXKISsBE=; b=S/RlhhEm55EyZogGswDRRABu/qzdBCwZ1+R3sKdQPFHVe4fyRZaOfpg8g8vDxkxr+2FXy0 SetlTOBrwVh8c7UF5B2hf5JVtnsMS4FWhUnnxcvp74zl1pPvRuh7hqPnWrjRl3z93J2q4C GrAzOtuzTl/acgaDfM48enmST3VafV0= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-tUz-hJQAOVKNwQPAts533w-1; Wed, 05 Feb 2020 03:48:57 -0500 Received: by mail-ua1-f72.google.com with SMTP id o13so389483uad.7 for ; Wed, 05 Feb 2020 00:48:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7iW0g3N59zsFKh5RIwR4yMSJpPUIePR6FzqqduqLlos=; b=fov5xGmnRusCFZjmGoBsCDCtc6dz8rHKBuUJIlvPt6AAS9Bzw7MVHUNAn2C3A8S35H aTMMcrsecTCcrcESB06mK++h6DvH3jg2j+R8aaj3Y1cSQHGGDy3ihAXFnSLlyNvh5RE0 +hYEg3vcXf9de6LVP49BVEk9K5mr0RljK13fBFDqqAjrDBEqYI4pmyYkd/i0wPCe/SsR fHK3RueP97/uLG33XEdXW5ZPNDp48OCctQaJ0BDD2S5pRca/i0FkisX7gnxqcN4rfj0X 3ZMoE0rXtj9//0DTGIrMnwWT+Mb7KG2AO29OGJ0BJ1+h/XHYTjRLzqzRJP0dQummNzM4 +ttw== X-Gm-Message-State: APjAAAVWLvj8m0mRb4OPhEo3llMC+ZeUV7Ukn2T6ep/lOzf+8MRGUUhh t/15MQqKaW4bLRgBRRMQiSEb6BPg7ouAxoViuFdcFvVabTJsnWGOZ3kKSJ00ErYYWzWevJDgV0n XKU0edhoyR/ELS2znsg== X-Received: by 2002:a67:e342:: with SMTP id s2mr20795770vsm.198.1580892536798; Wed, 05 Feb 2020 00:48:56 -0800 (PST) X-Google-Smtp-Source: APXvYqzBFnig3Or2QL5SXFZFDVSq1HGyrtgPheFFf80s+SaGabsBXgAVyOSVkKlKnED7IwgJKDVIPkUMIYnQGYS+Bgg= X-Received: by 2002:a67:e342:: with SMTP id s2mr20795760vsm.198.1580892536382; Wed, 05 Feb 2020 00:48:56 -0800 (PST) MIME-Version: 1.0 References: <1567748973-24192-1-git-send-email-agupta3@marvell.com> <20200203194912.4669-1-honnappa.nagarahalli@arm.com> <20200203194912.4669-3-honnappa.nagarahalli@arm.com> In-Reply-To: <20200203194912.4669-3-honnappa.nagarahalli@arm.com> From: David Marchand Date: Wed, 5 Feb 2020 09:48:45 +0100 Message-ID: To: ci@dpdk.org, Thomas Monjalon Cc: Amit Gupta , "Wang, Yipeng1" , "Gobriel, Sameh" , dev , nd , "Mcnamara, John" , "Yigit, Ferruh" , Honnappa Nagarahalli X-MC-Unique: tUz-hJQAOVKNwQPAts533w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-ci] [PATCH v2 2/5] test/hash: remove duplicated test code X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli wrote: > > The test case target 'hash_readwrite_autotest' is covered by > 'hash_readwrite_func_autotest' and 'hash_readwrite_perf_autotest'. > Hence, it is removed along with its test code. > > Signed-off-by: Honnappa Nagarahalli > --- > app/test/autotest_data.py | 10 +++- > app/test/test_hash_readwrite.c | 101 --------------------------------- > 2 files changed, 8 insertions(+), 103 deletions(-) > > diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py > index 6deb97bcc..71db4b3f6 100644 > --- a/app/test/autotest_data.py > +++ b/app/test/autotest_data.py > @@ -664,8 +664,14 @@ > "Report": None, > }, > { > - "Name": "Hash read-write concurrency autotest", > - "Command": "hash_readwrite_autotest", > + "Name": "Hash read-write concurrency functional autotest", > + "Command": "hash_readwrite_func_autotest", > + "Func": default_autotest, > + "Report": None, > + }, > + { > + "Name": "Hash read-write concurrency perf autotest", > + "Command": "hash_readwrite_perf_autotest", > "Func": default_autotest, > "Report": None, > }, > diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrit= e.c > index aa55db7fe..635ed5a9f 100644 > --- a/app/test/test_hash_readwrite.c > +++ b/app/test/test_hash_readwrite.c > @@ -749,106 +749,5 @@ test_hash_rw_func_main(void) > return 0; > } > > -static int > -test_hash_readwrite_main(void) > -{ > - /* > - * Variables used to choose different tests. > - * use_htm indicates if hardware transactional memory should be u= sed. > - * reader_faster indicates if the reader threads should finish ea= rlier > - * than writer threads. This is to timing either reader threads o= r > - * writer threads for performance numbers. > - */ > - int use_htm, use_ext, reader_faster; > - unsigned int i =3D 0, core_id =3D 0; > - > - if (rte_lcore_count() < 3) { > - printf("Not enough cores for hash_readwrite_autotest, exp= ecting at least 3\n"); > - return TEST_SKIPPED; > - } > - > - RTE_LCORE_FOREACH_SLAVE(core_id) { > - slave_core_ids[i] =3D core_id; > - i++; > - } > - > - setlocale(LC_NUMERIC, ""); > - > - if (rte_tm_supported()) { > - printf("Hardware transactional memory (lock elision) " > - "is supported\n"); > - > - printf("Test read-write with Hardware transactional memor= y\n"); > - > - use_htm =3D 1; > - use_ext =3D 0; > - > - if (test_hash_readwrite_functional(use_ext, use_htm) < 0) > - return -1; > - > - use_ext =3D 1; > - if (test_hash_readwrite_functional(use_ext, use_htm) < 0) > - return -1; > - > - reader_faster =3D 1; > - if (test_hash_readwrite_perf(&htm_results, use_htm, > - reader_faster) < = 0) > - return -1; > - > - reader_faster =3D 0; > - if (test_hash_readwrite_perf(&htm_results, use_htm, > - reader_faster) < = 0) > - return -1; > - } else { > - printf("Hardware transactional memory (lock elision) " > - "is NOT supported\n"); > - } > - > - printf("Test read-write without Hardware transactional memory\n")= ; > - use_htm =3D 0; > - use_ext =3D 0; > - if (test_hash_readwrite_functional(use_ext, use_htm) < 0) > - return -1; > - > - use_ext =3D 1; > - if (test_hash_readwrite_functional(use_ext, use_htm) < 0) > - return -1; > - > - reader_faster =3D 1; > - if (test_hash_readwrite_perf(&non_htm_results, use_htm, > - reader_faster) < = 0) > - return -1; > - reader_faster =3D 0; > - if (test_hash_readwrite_perf(&non_htm_results, use_htm, > - reader_faster) < = 0) > - return -1; > - > - printf("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); > - printf("Results summary:\n"); > - printf("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); > - > - printf("single read: %u\n", htm_results.single_read); > - printf("single write: %u\n", htm_results.single_write); > - for (i =3D 0; i < NUM_TEST; i++) { > - printf("+++ core_cnt: %u +++\n", core_cnt[i]); > - printf("HTM:\n"); > - printf(" read only: %u\n", htm_results.read_only[i]); > - printf(" write only: %u\n", htm_results.write_only[i]); > - printf(" read-write read: %u\n", htm_results.read_write_= r[i]); > - printf(" read-write write: %u\n", htm_results.read_write= _w[i]); > - > - printf("non HTM:\n"); > - printf(" read only: %u\n", non_htm_results.read_only[i])= ; > - printf(" write only: %u\n", non_htm_results.write_only[i= ]); > - printf(" read-write read: %u\n", > - non_htm_results.read_write_r[i]); > - printf(" read-write write: %u\n", > - non_htm_results.read_write_w[i]); > - } > - > - return 0; > -} > - > -REGISTER_TEST_COMMAND(hash_readwrite_autotest, test_hash_readwrite_main)= ; > REGISTER_TEST_COMMAND(hash_readwrite_func_autotest, test_hash_rw_func_ma= in); > REGISTER_TEST_COMMAND(hash_readwrite_perf_autotest, test_hash_rw_perf_ma= in); > -- > 2.17.1 > I can see that DTS references this test: https://git.dpdk.org/tools/dts/tree/tests/TestSuite_unit_tests_eal.py#n164 Travis (and UNH) also runs those unit tests (via the list included in meson= ). Is there a reason to keep those in DTS? Thanks. -- David Marchand