DPDK CI discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Chen, Zhaoyan" <zhaoyan.chen@intel.com>
Cc: "Zhang, XuemingX" <xuemingx.zhang@intel.com>,
	 "Richardson, Bruce" <bruce.richardson@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	 "Xu, Qian Q" <qian.q.xu@intel.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"Yu, PingX" <pingx.yu@intel.com>,
	Ali Alnubani <alialnu@mellanox.com>,
	ci@dpdk.org
Subject: Re: [dpdk-ci] Master compilation failures in Intel CI
Date: Tue, 14 Jan 2020 10:51:26 +0100
Message-ID: <CAJFAV8yq7YmJBVVsDSB4HeieFwr4LyiVyjoWEGDs=UBiEWpfBA@mail.gmail.com> (raw)
In-Reply-To: <2347250.TLnPLrj5Ze@xps>

On Tue, Jan 14, 2020 at 9:04 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 14/01/2020 08:18, Chen, Zhaoyan:
> > - most of the patches in patchset are aimed to specific PMD driver,
> >    but just several patches for makefile/build script/config file(common files).. in patchset.
> >    (e.g. https://patchwork.dpdk.org/patch/64384/)
> >    This kind of patchset will be pointed to dpdk master

The problem with this patch is that it changes the MAINTAINERS file itself.
The "guess" script works on the origin/master version of the file, not
after the patch is applied.
So the script will point at dpdk master anyway for the patch you
mentioned, since drivers/common are currently going through master.

I'd say those situations are rare and we must look carefully to set
the subtree when adding a new component.

>
> We should filter out config/, mk/ and MAINTAINERS in the decision.

I prepared a change for this.

>
>
> > - one patchset includes document change and other specific PMD driver change.
> >   This kind of patchset will be pointed to dpdk master
>
> For doc/, we must make sure each part of the doc is well sorted
> in MAINTAINERS so we can distinguish crypto and ethdev docs for instance.

The doc/ pattern is currently filtered out, if this is what you are
referring to.


> > For these 2 situations, basically, next-* branches are ahead of master,
> > developers expected their patches could be tested on next-*, since that is code base under developing.
> >
> > So applying these kinds of patchsets to next-* are more meaningful for them.
>
> I agree.

I sent an update on MAINTAINERS, and I am about to send the change
that filters mk/, config/ and MAINTAINERS.

Can you give me a list of patchsets you think are problematic so that
I can test them?
Thanks.


-- 
David Marchand


  reply	other threads:[~2020-01-14  9:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAJFAV8wbWkMbSHgOY4aBW-v1s6jhczaH2Jyf9cxNAywG0RmTsg@mail.gmail.com>
     [not found] ` <CAJFAV8xL7kdAmeyTCXaFGnyJgEApsAuGdHMtgamZqkyo1q4Y9Q@mail.gmail.com>
     [not found]   ` <9DEEADBC57E43F4DA73B571777FECECA41E9E23A@SHSMSX104.ccr.corp.intel.com>
2020-01-14  8:04     ` Thomas Monjalon
2020-01-14  9:51       ` David Marchand [this message]
2020-01-14 10:33         ` Thomas Monjalon
2020-01-14 10:37           ` David Marchand
2020-01-17  6:06         ` Zhang, XuemingX
2020-01-19  8:01           ` Dekel Peled
2020-01-20 14:49           ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8yq7YmJBVVsDSB4HeieFwr4LyiVyjoWEGDs=UBiEWpfBA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=alialnu@mellanox.com \
    --cc=bruce.richardson@intel.com \
    --cc=ci@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=pingx.yu@intel.com \
    --cc=qian.q.xu@intel.com \
    --cc=thomas@monjalon.net \
    --cc=xuemingx.zhang@intel.com \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ https://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git