From: David Marchand <david.marchand@redhat.com>
To: Aaron Conole <aconole@redhat.com>
Cc: Michael Santana <msantana@redhat.com>,
ci@dpdk.org, Juraj Linkes <juraj.linkes@pantheon.tech>,
Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Lincoln Lavoie <lylavoie@iol.unh.edu>
Subject: Re: [dpdk-ci] [RFC pw-ci] pw_mon: check for recheck requested comments
Date: Fri, 21 May 2021 11:38:30 +0200 [thread overview]
Message-ID: <CAJFAV8z491MWq8TbK1mfqiTOvhSqJSGAk6Gohv4vrEA0s04=-w@mail.gmail.com> (raw)
In-Reply-To: <f7ttumx9kvz.fsf@redhat.com>
On Thu, May 20, 2021 at 11:05 PM Aaron Conole <aconole@redhat.com> wrote:
> David Marchand <david.marchand@redhat.com> writes:
>
> > On Wed, May 19, 2021 at 4:18 PM Aaron Conole <aconole@redhat.com> wrote:
> >>
> >> ENOTREADY: Missing the actual recheck logic... needs some input /
> >> design before committing to anything.
> >>
> >> When a developer wants to ask for a test case recheck (for example,
> >> maybe to rerun the github-actions test suite), we scan for the specific
> >> line:
> >>
> >> ^Recheck-request: .*$
> >>
> >> The line would break up as:
> >>
> >> Recheck-request: [context]
> >>
> >> where '[context]' is the name of the check (as it appears in the UI).
> >> For example, if we look at a patch that has 'github-robot', we can
> >> request a recheck of the series by sending an email reply with the line:
> >
> > It could happen that the tree was broken and we want to rerun all or a
> > list of tests.
> > Coud we accept multiple ^Recheck-request lines?
>
> I guess we can solve this with the comma separated list.
Yes, it looks fine.
>
> > Or maybe have a magic "all" context?
>
> That might require more thought, but it's possible. Do you think it
> would be better than doing a comma separated list?
No, an explicit list is actually better.
When a new check is added, for someone looking at the mails (maybe 2/3
weeks later), and reading just "all", he would have to know what
checks were available at the time.
--
David Marchand
next prev parent reply other threads:[~2021-05-21 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 14:17 Aaron Conole
2021-05-20 9:37 ` Juraj Linkeš
2021-05-20 19:16 ` Aaron Conole
2021-05-20 13:38 ` David Marchand
2021-05-20 21:05 ` Aaron Conole
2021-05-21 9:38 ` David Marchand [this message]
2021-06-17 14:38 ` Lincoln Lavoie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z491MWq8TbK1mfqiTOvhSqJSGAk6Gohv4vrEA0s04=-w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ci@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lylavoie@iol.unh.edu \
--cc=msantana@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).