From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B82D7A0A0A for ; Thu, 20 May 2021 15:38:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD0B940143; Thu, 20 May 2021 15:38:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id ACC5E40041 for ; Thu, 20 May 2021 15:38:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621517932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oTjv3waCjjlI5LFECj3qg+RZ45DBv8WiUnmqu4ndgrY=; b=AaGpxAwjBN+eVwNVarxno1FY4Q3gOK1zKvZo2MIvpMMRzRmzbG0Vwu5AlV202CejwMQMhm IwSerIsjcVn/Cm8jPiiuZCF46h1Cx5sovhaydWR8kdsu2KHTGFCzDLEc4Q4sOEOmlkUTOD E10GO63Am6RoU4NPPSzA4Uxo/R0Jhm8= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-XpdpT3HIPkC3AtR32zzcjg-1; Thu, 20 May 2021 09:38:48 -0400 X-MC-Unique: XpdpT3HIPkC3AtR32zzcjg-1 Received: by mail-vs1-f71.google.com with SMTP id v15-20020a67c00f0000b029023607a23f3dso4448103vsi.10 for ; Thu, 20 May 2021 06:38:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oTjv3waCjjlI5LFECj3qg+RZ45DBv8WiUnmqu4ndgrY=; b=rLSJ9uliewcmtJ1atStg8n+H41n9rT853SPGrRflUz8H9/aJZM/ZZUH8LIXNPahoRr tErNMKOTs/c4hyzP8U4RujR25q8nO0p0L8roNwIU2MjV1KFFQIq6kx8ABHWUHNSozclp LZ6NIAP5PuDI/AoxOKLR/hddyT7VL1MYQfLXhWCq1qA7cLb7Qmknbu1r4nwuhz1T9zk1 uF9t36nQU6nU4ARd4WQ8pNtu6aH6elyMOaKm+lu138ktbHP+P2DtWYwl7l69JYYplbcJ f8yaxy3BSciT9d0Y3jX7cmEv0auaNm0bYrDSs3O34HBTKy/0xNxIOb5yGpiD917DYzQM 1rGw== X-Gm-Message-State: AOAM532ya33vF+/ZIJQBcEGX8adGafzYPPKB39KmNnVUmqNSiPuVWGPH sq4Q/6kmCuNwhPO7xqa1QD2TQluuR7ofSW8bqz901EW0VWBwABg+zvObyF3Ud1fVdQzzOR06YkH yN4rbiv8SF5auJmMCYw== X-Received: by 2002:a67:7cc4:: with SMTP id x187mr3868108vsc.17.1621517928198; Thu, 20 May 2021 06:38:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzt2VcPtibukhwsr+asMc7LL1ebzDAJnkGPXc7QQiuOp2BXfyRSIg5cGKgRvk3DMLDJIibNu3Jgt/2vJLNALrs= X-Received: by 2002:a67:7cc4:: with SMTP id x187mr3868080vsc.17.1621517928026; Thu, 20 May 2021 06:38:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Thu, 20 May 2021 15:38:35 +0200 Message-ID: To: Aaron Conole Cc: Michael Santana , ci@dpdk.org, Juraj Linkes , Bruce Richardson , Thomas Monjalon , Lincoln Lavoie Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-ci] [RFC pw-ci] pw_mon: check for recheck requested comments X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" On Wed, May 19, 2021 at 4:18 PM Aaron Conole wrote: > > ENOTREADY: Missing the actual recheck logic... needs some input / > design before committing to anything. > > When a developer wants to ask for a test case recheck (for example, > maybe to rerun the github-actions test suite), we scan for the specific > line: > > ^Recheck-request: .*$ > > The line would break up as: > > Recheck-request: [context] > > where '[context]' is the name of the check (as it appears in the UI). > For example, if we look at a patch that has 'github-robot', we can > request a recheck of the series by sending an email reply with the line: It could happen that the tree was broken and we want to rerun all or a list of tests. Coud we accept multiple ^Recheck-request lines? Or maybe have a magic "all" context? > > Recheck-request: github-robot > > It is important to use the 'msgid' field to distinguish recheck > requests. Otherwise, we will continuously reparse the same > recheck request and loop forever. Additionally, we've discussed using a > counter to limit the recheck requests to a single 'recheck' per test > name. > > As an additional change, we run after the 'superseded' and 'completed' > checks, to ensure that we don't bother parsing comments from older > series that aren't relevant any longer. There was also an ask on filtering requesters (only maintainers and patch authors can ask for a recheck). -- David Marchand