DPDK CI discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: Aaron Conole <aconole@redhat.com>
Cc: Adam Hassick <ahassick@iol.unh.edu>, ci@dpdk.org, alialnu@nvidia.com
Subject: Re: [PATCH 1/2] tools: Add script to create artifacts
Date: Wed, 10 Jan 2024 13:56:17 -0500	[thread overview]
Message-ID: <CAJvnSUC5dtMD3GFPJ1ARxOe0Wt3HSRudeLXL-WYcMjpu9m7SvA@mail.gmail.com> (raw)
In-Reply-To: <f7tbk9tf7sz.fsf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

On Wed, Jan 10, 2024 at 11:54 AM Aaron Conole <aconole@redhat.com> wrote:

> Adam Hassick <ahassick@iol.unh.edu> writes:
>
> > This script takes in a URL to a series on Patchwork and emits a
> > tarball which may be used for running tests.
> >
> > Signed-off-by: Adam Hassick <ahassick@iol.unh.edu>
> > ---
>
> Just a quick glance.
>
> Is it possible to include a doc on how it is expected to run this
> script?  Maybe that could help to also evaluate it as well.
>

I was thinking along similar lines when I ran the script, but to a certain
extent it seemed like having helpful examples in the config file would
clear up confusion. Nevertheless, I think it's certainly worth writing the
process down a little more. I wonder should we instead follow the example
of pw_maintainers_cli.py and have the example usage, how to run, etc.
written as a string at the top of the file? Then we are consistent with how
other scripts in the repo are operating.

[-- Attachment #2: Type: text/html, Size: 1463 bytes --]

  reply	other threads:[~2024-01-10 18:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 14:57 [PATCH 0/2] Add a script to create series artifacts Adam Hassick
2024-01-10 14:57 ` [PATCH 1/2] tools: Add script to create artifacts Adam Hassick
2024-01-10 16:54   ` Aaron Conole
2024-01-10 18:56     ` Patrick Robb [this message]
     [not found]     ` <CAC-YWqhfQAPQ2=yaqpgG+axPSG9n=kScJULkYv9ZybTnSiZUog@mail.gmail.com>
2024-01-16 14:10       ` Aaron Conole
2024-01-16 23:41         ` Adam Hassick
2024-01-11 11:55   ` Juraj Linkeš
2024-01-10 14:57 ` [PATCH 2/2] config: Add example config file Adam Hassick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJvnSUC5dtMD3GFPJ1ARxOe0Wt3HSRudeLXL-WYcMjpu9m7SvA@mail.gmail.com \
    --to=probb@iol.unh.edu \
    --cc=aconole@redhat.com \
    --cc=ahassick@iol.unh.edu \
    --cc=alialnu@nvidia.com \
    --cc=ci@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).