DPDK CI discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Adam Hassick <ahassick@iol.unh.edu>,
	ci@dpdk.org, Aaron Conole <aconole@redhat.com>
Subject: Re: Adding Series Dependency to Patchwork
Date: Thu, 25 Jul 2024 13:52:56 -0400	[thread overview]
Message-ID: <CAJvnSUCD-Zmeokz13EH=fsgci+AsnaE0RBqQLFNUjLLYTmch0A@mail.gmail.com> (raw)
In-Reply-To: <8027a8c9-3911-4715-9aa6-2e804e0e7688@amd.com>

On Thu, Jul 25, 2024 at 5:57 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 7/24/2024 4:07 PM, Adam Hassick wrote:
> > On Tue, Jul 23, 2024 at 12:08 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> > An unrelated note about the v2: Earlier I mentioned that we might
> > support cover letter IDs to reference a series dependency. I've
> > decided to forgo that feature because developers do not always
> > resubmit cover letters when they submit new versions of a patch
> > series. For example, if they depend on the v3 of a patch and they use
> > the cover letter message ID submitted with v1, that will introduce a
> > dependency on v1. This could lead to some confusion.
> >
>
> As far as I can see if a patch series has cover letter, more likely it
> will have cover letter in next version.

Okay, this was not my impression, so thanks for setting the record straight.

Sorry Adam for me giving you the wrong idea about common cover letter
resubmission practices. :)

>
> If cover letter is not supported, and dependent series has a cover
> letter, is the expectation to add first patch of the series as
> dependency skipping cover letter? This maybe also confusing.

Yes this would work, but I can see how having this expectation may be
confusing. So, we can abandon this idea.

>
> For the sample you give, if dependent patch decided to drop cover letter
> in v3, won't it work to provide first patch of v3 as dependency?
>

Yes.

      reply	other threads:[~2024-07-25 17:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 19:51 Adam Hassick
2024-04-04 13:50 ` Patrick Robb
2024-04-05  6:41   ` Thomas Monjalon
2024-04-11 14:18     ` Aaron Conole
2024-04-11 14:33       ` Patrick Robb
2024-07-12 20:15         ` Adam Hassick
2024-07-19 15:32           ` Patrick Robb
2024-07-19 17:43             ` Ferruh Yigit
2024-07-19 17:40           ` Ferruh Yigit
2024-07-22 16:16             ` Adam Hassick
2024-07-22 16:28               ` Patrick Robb
2024-07-23 12:41                 ` Aaron Conole
     [not found]                 ` <6b425d90-78b2-497b-958c-9d36e2ba6e3b@amd.com>
2024-07-23 15:36                   ` Patrick Robb
2024-07-23 16:08                     ` Ferruh Yigit
2024-07-24 15:07                       ` Adam Hassick
2024-07-25  9:47                         ` Ferruh Yigit
2024-07-25 17:52                           ` Patrick Robb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJvnSUCD-Zmeokz13EH=fsgci+AsnaE0RBqQLFNUjLLYTmch0A@mail.gmail.com' \
    --to=probb@iol.unh.edu \
    --cc=aconole@redhat.com \
    --cc=ahassick@iol.unh.edu \
    --cc=ci@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).