DPDK CI discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: zhoumin <zhoumin@loongson.cn>
Cc: ci@dpdk.org, Aaron Conole <aconole@redhat.com>,
	 David Marchand <david.marchand@redhat.com>,
	"Brandes, Shai" <shaibran@amazon.com>
Subject: Re: Email based retests for the Loongarch lab
Date: Fri, 1 Aug 2025 09:49:06 -0400	[thread overview]
Message-ID: <CAJvnSUCJpyLDUGoqP=e0FGCkL_tQbGQNgoNxLvn97Vs25YNJFg@mail.gmail.com> (raw)
In-Reply-To: <47f559d8-7268-9f85-1024-36468c9cef4e@loongson.cn>

[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

On Thu, Jul 31, 2025 at 9:29 PM zhoumin <zhoumin@loongson.cn> wrote:

> Hi Patrick Robb,
> On 2025/7/25 10:24PM, Patrick Robb wrote:
>
>
>
>>
> The behavior you describe is correct - when the rebase argument is used,
> the patch should be applied to HEAD of the branch specified by the rebase
> arg.
>
> However, I do believe there is a discrepancy in our labs behavior when it
> comes to retests which are submitted without the rebase argument. In this
> case, UNH lab, AWS, and GitHub are running retests on the original patch
> artifacts without re-applying to the current HEAD at the time of the
> retest. On the other hand, I believe Loongson does re-apply to HEAD even
> when the rebase argument is not specified. I think in an ideal world our
> behavior would be uniform across the labs. What that would require in this
> case is either:
>
> 1. Loongson changes to retesting without re-apply on HEAD when no rebase
> argument is given (unclear how much work this is)
>
> I'm glad to say Loongson lab has changed to retesting without re-apply on
> HEAD when no rebase argument is given. We recorded the commit ID of the
> base for the series to test during the first test and use it as the base to
> retest if no rebase argument is specified. We also ensure that the patch
> will be applied to HEAD of the branch specified by the rebase argument if
> it exists.
>


Thanks that sounds perfect. :)

>
>>

[-- Attachment #2: Type: text/html, Size: 3005 bytes --]

      reply	other threads:[~2025-08-01 13:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  5:55 Patrick Robb
2024-02-22 13:54 ` Patrick Robb
2024-02-28  5:34   ` zhoumin
2024-02-29  6:09     ` Patrick Robb
2024-03-01 10:19       ` zhoumin
2025-05-28 19:36         ` Patrick Robb
2025-06-08  0:49           ` zhoumin
2025-06-11 21:05             ` Patrick Robb
2025-06-17  4:15               ` zhoumin
2025-07-09 12:49                 ` Patrick Robb
2025-07-17 12:48                   ` zhoumin
2025-07-25 14:24                     ` Patrick Robb
2025-08-01  1:27                       ` zhoumin
2025-08-01 13:49                         ` Patrick Robb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJvnSUCJpyLDUGoqP=e0FGCkL_tQbGQNgoNxLvn97Vs25YNJFg@mail.gmail.com' \
    --to=probb@iol.unh.edu \
    --cc=aconole@redhat.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=shaibran@amazon.com \
    --cc=zhoumin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).