From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ci-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A9C843075; Tue, 15 Aug 2023 21:05:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBC294114B; Tue, 15 Aug 2023 21:05:20 +0200 (CEST) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id 9A93D410ED for <ci@dpdk.org>; Tue, 15 Aug 2023 21:05:19 +0200 (CEST) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-56dd69cbb18so3980990eaf.2 for <ci@dpdk.org>; Tue, 15 Aug 2023 12:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1692126319; x=1692731119; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L+zo40wGVPxuILwQutKho1swAMX2ZJfNM+HLmPvdwU0=; b=aidE4Pk9TNJTD+1djxpf/eJmxK+WHrfXj/WPJY4OD+OAa5VOL++IEv143E70mdh6ra cK5SUvD/iJnh0wVmfNvoIQAv2dQWb0cszRSHQ1adtEi40Jsdla3aiTLFZLtYl/bTFA6d 4aNLav4u0id1MS1Cp33hMStRpkj0CY3CD/0L8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692126319; x=1692731119; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L+zo40wGVPxuILwQutKho1swAMX2ZJfNM+HLmPvdwU0=; b=hYYb4B4GG9zXhz9YNuQWk4ZDfsAv7xUSZCPZTwCD8Jd5m4+1MCjea1HGn4vtEPD/ER WQdz/d710J3I/HWiOZn2d9nW75hyEtoNFOpuhu5xhB1R9+SJM5fK7LlXfV90yJTLBzp/ c8ZkYN6SnQhJhdVNZ/14ATXUKXVk2WWv9dpQBkOoa/g1ck9loQta14bpxcY2EImISGSJ CSXa8BbJgQAHB3Rgp376esRh27u/tQTWMVlsVESRa9kwEH7l7qkh8a7eB6Sogvcf3KAa +/vIDtDEZi+ufLSyE7Qbo7LZccf4gBpHk4y5xxOwf9eVA4wNisn/xeIGj3r81j9OKfvp U0sQ== X-Gm-Message-State: AOJu0Yy052jxvl3SjHHCTuIqJSaQ4ZNalkAKufLHjZwJBUH0gvPTQRb2 7aB+L5zLy0Y9c+ExMq5xT0BYHyL0o2esd47QqWmNDw== X-Google-Smtp-Source: AGHT+IF9PIW+IIOgYIV6uSfEiza11cgmJFocfkm5oZZZUQY/yD6hRKlTAUtprGCDc16SgZM69MmvAQCKh1NbH0JmaDI= X-Received: by 2002:a4a:2502:0:b0:56e:4bb5:3095 with SMTP id g2-20020a4a2502000000b0056e4bb53095mr2446388ooa.5.1692126318748; Tue, 15 Aug 2023 12:05:18 -0700 (PDT) MIME-Version: 1.0 References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-5-bruce.richardson@intel.com> In-Reply-To: <20230815151053.996469-5-bruce.richardson@intel.com> From: Patrick Robb <probb@iol.unh.edu> Date: Tue, 15 Aug 2023 15:05:08 -0400 Message-ID: <CAJvnSUCVUdTgF6SuospBMPju_v_emMmqEhOsshzUOW2TSqG7fw@mail.gmail.com> Subject: Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, ci@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com> Content-Type: multipart/alternative; boundary="00000000000024fde90602fadc11" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions <ci.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/ci>, <mailto:ci-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/ci/> List-Post: <mailto:ci@dpdk.org> List-Help: <mailto:ci-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/ci>, <mailto:ci-request@dpdk.org?subject=subscribe> Errors-To: ci-bounces@dpdk.org --00000000000024fde90602fadc11 Content-Type: text/plain; charset="UTF-8" Adam from our team just raised something important about this patch and UNH CI which I missed during the RFC discussion. Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (arm people are aware of this, they think it might be a memory leak from mlx5 driver), so at their request we are disabling this unit test (on arm only) for them for the time being. This failure was discovered when we were initially standing up arm unit testing on tx2 servers earlier this year - previously there was no coverage for this. We do this filtering by going through the /app/test/meson.build file and resetting the eal_flags_file_prefix_autotest line to an empty string. This process is broken by your patch series. Again, I'm sorry I didn't catch this concern when discussing it during the RFC. This is why you are not getting unit test results for arm64, we can't run unit tests given the changes in this patch. Your refactor likely means that going forward, we will no longer be able to tailor the fast test suite (or any suite) per vendor request. That might actually be a good thing. In any case, if this is merged now, it is going to put the tree in a state where our CI doesn't run any unit testing on ARM. I don't know how close this patch series is to possibly hitting mainline, but, if possible, can that be delayed, pending us figuring out how we will respond to this situation? --00000000000024fde90602fadc11 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">Adam from our team just raised something = important about this patch and UNH CI which I missed during the RFC discuss= ion. Presently,=C2=A0eal_flags_file_prefix_autotest fails on arm tx2 system= s (arm people are aware of this, they think it might be a memory leak from = mlx5 driver), so at their request we are disabling this unit test (on arm o= nly) for them for the time being. This failure was discovered when we were = initially standing up arm unit testing on tx2 servers earlier this year - p= reviously there was no coverage for this. We do this filtering by going=C2= =A0through the /app/test/meson.build file and resetting the=C2=A0eal_flags_= file_prefix_autotest line to an empty string. This process is broken by you= r patch series. Again, I'm sorry I didn't catch this concern when d= iscussing it during the RFC. This is why you are not getting unit test resu= lts for arm64, we can't run unit tests given the changes in this patch.= =C2=A0</div><div dir=3D"ltr"><br></div><div>Your refactor likely means that= going forward, we will no longer be able to tailor the fast test suite (or= any suite) per vendor request. That might actually be a good thing. In any= case, if this is merged now, it is going to put the tree in a state where = our CI doesn't run any unit testing on ARM. I don't know how close = this patch series is to possibly hitting mainline, but, if possible, can th= at be delayed, pending us figuring out how we will respond to this situatio= n?=C2=A0</div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><br></div></div> --00000000000024fde90602fadc11--