From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E50546B81; Tue, 15 Jul 2025 20:53:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EEED4026D; Tue, 15 Jul 2025 20:53:36 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 8F3EF4026D for ; Tue, 15 Jul 2025 20:53:35 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-235ea292956so54994045ad.1 for ; Tue, 15 Jul 2025 11:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1752605614; x=1753210414; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nZ5iCFGHKvqLE8PCYaSLG72JFY5UIUgQ67Ee12qIVSk=; b=IIwt+/+AWVTsJ9he7KsxjxIAKIYHhP0e1siolYOFyjTCCIlnhyiddrcFQMbBaIJ0dE yxQQo41Bz7+ghOhb3NOsXuDpmLZCRvagc+N+vVBIsWPRaYWogZe8XXtH2uvbucgGPb01 /57uDt2LN4L2gxh0Cir+iDBpEcE6wStYZup4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752605614; x=1753210414; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nZ5iCFGHKvqLE8PCYaSLG72JFY5UIUgQ67Ee12qIVSk=; b=aWIFCZPPW9Mf/FunM5530I3xpY4f8CivBPVcVuxe75FTjsL4iBalcWb+6uAn1Dz1F5 CpPOpnKvCfDzMp9vy1yhEvvVYD74/ncYco5CVqD6NGBOHOOCo5TN66CqEvsAN09Xkp0z QItgr1TxqqCtPi9RH9lENcOGTX5p1rz5LOdo2qLbDj66fQI39FimGccg7x7H33auT3YF 3DaNf4hByY1GIFmiK5YEKb+51LGUnEL69PpiXCVbYkc2O3Es4NpCzI8C3DbCL6Vz6vi/ onqx5LugVG11E5sPTRhNjf81W92R2IdwkKaFLO/5c3Yyg+cmzgS6FrXKVWzbkwbnyDAu gbAw== X-Forwarded-Encrypted: i=1; AJvYcCXMSOE5xCfmloYxHUL5N/inC6dXYFGxSnk9Np+ujzHwXsPHHy50rWbr420a5JzvLal5uA==@dpdk.org X-Gm-Message-State: AOJu0YxYylLhdiEX/y1DtqIn2vhx7oNJ0fI2L/mwad7xZF6p/jWbzIAS pS4ViRLMpihzrdCmrb6q9aKibJi8EgQ8TcUQyaUvzemrBdIyxebc0YpUgax2lb91AUrsqVxp5+q 5ZX9pRmRe1O3aVke+T4oBGTi4b6dKYi6Tm8hGPb5ULg== X-Gm-Gg: ASbGncv4WhKWvgn6Z3ltF3V37IR9VLnrliKQyuEkyQl0P456iBwZrRqkUj/tk/RN1Zv 8d0jZcb5CWjoaG1+C1dPc9Fvc+fxtXQFbCDp0U5orNPJHyGrEGC33CQBzGgMcKvRxnqbgrHOHuM ZpWdod/YX2C/IR6d/HVg7Z0GEtMIfAN+jhTwRE+kN0u9PNQliv1yfnE6ka2IgmH9nbwaKMDEKRq /i/dm1oWg== X-Google-Smtp-Source: AGHT+IH5GAE+kRCQBHd5pc1atVzaxANPByRYLEZ9kdNdsYIz67MULrn+nHV1blRbjtjlPhmxLrqC4XaMs+ttyPFxxZo= X-Received: by 2002:a17:90b:3b83:b0:31c:15b4:8e22 with SMTP id 98e67ed59e1d1-31c9e6e9a3amr375014a91.7.1752605614121; Tue, 15 Jul 2025 11:53:34 -0700 (PDT) MIME-Version: 1.0 References: <1746458561-13525-1-git-send-email-andremue@linux.microsoft.com> <1752588889-27133-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1752588889-27133-1-git-send-email-andremue@linux.microsoft.com> From: Patrick Robb Date: Tue, 15 Jul 2025 14:47:43 -0400 X-Gm-Features: Ac12FXxNI_ezesqEd2Q5LvpUKnWnWbaqymLx9Nv3lnH5gnGwswE4zAqvONQMQ8s Message-ID: Subject: Re: [PATCH v2] doc: update parameters to use for mlx5 on Windows To: Andre Muezerie , ci@dpdk.org, Manit Mahajan , Andrew Bailey Cc: bingz@nvidia.com, dev@dpdk.org, dsosnowski@nvidia.com, matan@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, viacheslavo@nvidia.com Content-Type: multipart/alternative; boundary="0000000000001041ec0639fc4b06" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --0000000000001041ec0639fc4b06 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable +ci@dpdk.org +Manit Mahajan +Andrew Bailey Thank you for this we will modify our Clang and MSVC build pipelines at UNH= . Acked-by: Patrick Robb On Tue, Jul 15, 2025 at 10:14=E2=80=AFAM Andre Muezerie < andremue@linux.microsoft.com> wrote: > The linker parameters to use with MSVC and Clang differ. > Showing explicitly what to use with each in the documentation. > > Signed-off-by: Andre Muezerie > --- > doc/guides/platform/mlx5.rst | 27 +++++++++++++++++++++++---- > 1 file changed, 23 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst > index ab3107209a..94ed59b170 100644 > --- a/doc/guides/platform/mlx5.rst > +++ b/doc/guides/platform/mlx5.rst > @@ -268,14 +268,33 @@ configured by the ``ibverbs_link`` build option: > Compilation on Windows > ~~~~~~~~~~~~~~~~~~~~~~ > > -The DevX SDK location must be set through CFLAGS/LDFLAGS, > -either:: > +The DevX SDK location must be set through CFLAGS/LDFLAGS. > +When compiling with MSVC, use either:: > > - meson.exe setup "-Dc_args=3D-I\"%DEVX_INC_PATH%\"" > "-Dc_link_args=3D-L\"%DEVX_LIB_PATH%\"" ... > + meson.exe setup ^ > + "-Dc_args=3D-I\"%DEVX_INC_PATH%\"" ^ > + "-Dc_link_args=3D-LIBPATH:\"%DEVX_LIB_PATH%\"" ^ > + -Denable_stdatomic=3Dtrue ^ > + ... > > or:: > > - set CFLAGS=3D-I"%DEVX_INC_PATH%" && set LDFLAGS=3D-L"%DEVX_LIB_PATH%"= && > meson.exe setup ... > + set CFLAGS=3D-I"%DEVX_INC_PATH%" > + set LDFLAGS=3D-LIBPATH:"%DEVX_LIB_PATH%" > + meson.exe setup -Denable_stdatomic=3Dtrue ... > + > +When compiling with Clang, use either:: > + > + meson.exe setup ^ > + "-Dc_args=3D-I\"%DEVX_INC_PATH%\"" ^ > + "-Dc_link_args=3D-Wl,-LIBPATH:\"%DEVX_LIB_PATH%\"" ^ > + ... > + > +or:: > + > + set CFLAGS=3D-I"%DEVX_INC_PATH%" > + set LDFLAGS=3D-Wl,-LIBPATH:"%DEVX_LIB_PATH%" > + meson.exe setup ... > > > .. _mlx5_common_env: > -- > 2.50.1.vfs.0.0 > > --0000000000001041ec0639fc4b06 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
+ci@dpdk.org=C2=A0

= Thank you for this we will modify our Clang and MSVC=C2=A0build pipelines a= t UNH.

Acked-by: Patrick Robb <probb@iol.unh.edu>

O= n Tue, Jul 15, 2025 at 10:14=E2=80=AFAM Andre Muezerie <andremue@linux.microsoft.com> wrote:=
The linker para= meters to use with MSVC and Clang differ.
Showing explicitly what to use with each in the documentation.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
=C2=A0doc/guides/platform/mlx5.rst | 27 +++++++++++++++++++++++----
=C2=A01 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst index ab3107209a..94ed59b170 100644
--- a/doc/guides/platform/mlx5.rst
+++ b/doc/guides/platform/mlx5.rst
@@ -268,14 +268,33 @@ configured by the ``ibverbs_link`` build option:
=C2=A0Compilation on Windows
=C2=A0~~~~~~~~~~~~~~~~~~~~~~

-The DevX SDK location must be set through CFLAGS/LDFLAGS,
-either::
+The DevX SDK location must be set through CFLAGS/LDFLAGS.
+When compiling with MSVC, use either::

-=C2=A0 =C2=A0meson.exe setup "-Dc_args=3D-I\"%DEVX_INC_PATH%\&qu= ot;" "-Dc_link_args=3D-L\"%DEVX_LIB_PATH%\"" ... +=C2=A0 =C2=A0meson.exe setup ^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0"-Dc_args=3D-I\"%DEVX_INC_PATH%\"= ;" ^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0"-Dc_link_args=3D-LIBPATH:\"%DEVX_LIB= _PATH%\"" ^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0-Denable_stdatomic=3Dtrue ^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0...

=C2=A0or::

-=C2=A0 =C2=A0set CFLAGS=3D-I"%DEVX_INC_PATH%" && set LDF= LAGS=3D-L"%DEVX_LIB_PATH%" && meson.exe setup ...
+=C2=A0 =C2=A0set CFLAGS=3D-I"%DEVX_INC_PATH%"
+=C2=A0 =C2=A0set LDFLAGS=3D-LIBPATH:"%DEVX_LIB_PATH%"
+=C2=A0 =C2=A0meson.exe setup -Denable_stdatomic=3Dtrue ...
+
+When compiling with Clang, use either::
+
+=C2=A0 =C2=A0meson.exe setup ^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0"-Dc_args=3D-I\"%DEVX_INC_PATH%\"= ;" ^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0"-Dc_link_args=3D-Wl,-LIBPATH:\"%DEVX= _LIB_PATH%\"" ^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0...
+
+or::
+
+=C2=A0 =C2=A0set CFLAGS=3D-I"%DEVX_INC_PATH%"
+=C2=A0 =C2=A0set LDFLAGS=3D-Wl,-LIBPATH:"%DEVX_LIB_PATH%"
+=C2=A0 =C2=A0meson.exe setup ...


=C2=A0.. _mlx5_common_env:
--
2.50.1.vfs.0.0

--0000000000001041ec0639fc4b06--