AWS lab meson test fails

AWS lab meson test fails

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi Shai,

It looks like for some recent patches AWS is reporting an overall FAIL
status for meson fast tests even though the logs indicate all tests either
passed or skipped. Can you take a look? Thanks!

example:

https://patchwork.dpdk.org/project/dpdk/patch/20250609211937.345620-1-schneide@qti.qualcomm.com/

[-- Attachment #2: Type: text/html, Size: 544 bytes --]

RE: AWS lab meson test fails

[Brandes, Shai]

Hi Patrick,

The failure status appears to be due to an issue applying the patch to the release notes RTS file.
We suspect that the patch may have been applied to the incorrect DPDK tree.
Could you advise if there is any specific metadata we should be using to determine the correct tree for applying the patch?

Best regards,
Shai


> -----Original Message-----
> From: Patrick Robb <probb@iol.unh.edu>
> Sent: Wednesday, June 11, 2025 8:40 PM
> To: Brandes, Shai <shaibran@amazon.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>; ci@dpdk.org
> Subject: [EXTERNAL] AWS lab meson test fails
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> Hi Shai,
> 
> 
> It looks like for some recent patches AWS is reporting an overall FAIL status for
> meson fast tests even though the logs indicate all tests either passed or
> skipped. Can you take a look? Thanks!
> 
> example:
> 
> https://patchwork.dpdk.org/project/dpdk/patch/20250609211937.345620-1-
> schneide@qti.qualcomm.com/

RE: AWS lab meson test fails

[Brandes, Shai]

In addition, I also see that apply patch failed with warning on my patchset in the ci/iol-testing (https://mails.dpdk.org/archives/test-report/2025-May/881787.html) which makes me wonder is this is a known issue with applying the release notes changes that already has a mitigation by the labs.

> -----Original Message-----
> From: Brandes, Shai
> Sent: Thursday, June 12, 2025 1:20 PM
> To: 'Patrick Robb' <probb@iol.unh.edu>
> Cc: Bruce Richardson <bruce.richardson@intel.com>; ci@dpdk.org
> Subject: RE: [EXTERNAL] AWS lab meson test fails
> 
> Hi Patrick,
> 
> The failure status appears to be due to an issue applying the patch to the
> release notes RTS file.
> We suspect that the patch may have been applied to the incorrect DPDK tree.
> Could you advise if there is any specific metadata we should be using to
> determine the correct tree for applying the patch?
> 
> Best regards,
> Shai
> 
> 
> > -----Original Message-----
> > From: Patrick Robb <probb@iol.unh.edu>
> > Sent: Wednesday, June 11, 2025 8:40 PM
> > To: Brandes, Shai <shaibran@amazon.com>
> > Cc: Bruce Richardson <bruce.richardson@intel.com>; ci@dpdk.org
> > Subject: [EXTERNAL] AWS lab meson test fails
> >
> > CAUTION: This email originated from outside of the organization. Do
> > not click links or open attachments unless you can confirm the sender
> > and know the content is safe.
> >
> >
> > Hi Shai,
> >
> >
> > It looks like for some recent patches AWS is reporting an overall FAIL
> > status for meson fast tests even though the logs indicate all tests
> > either passed or skipped. Can you take a look? Thanks!
> >
> > example:
> >
> > https://patchwork.dpdk.org/project/dpdk/patch/20250609211937.345620-1-
> > schneide@qti.qualcomm.com/

Re: AWS lab meson test fails

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

Hi Shai,

On Thu, Jun 12, 2025 at 6:20 AM Brandes, Shai <shaibran@amazon.com> wrote:

> Hi Patrick,
>
> The failure status appears to be due to an issue applying the patch to the
> release notes RTS file.
> We suspect that the patch may have been applied to the incorrect DPDK tree.
> Could you advise if there is any specific metadata we should be using to
> determine the correct tree for applying the patch?
>

Here is the script which should be used to determine the tree to apply the
patchseries to:
https://git.dpdk.org/tools/dpdk-ci/tree/tools/pw_maintainers_cli.py

Even better than using that directly, though, is using this create series
artifact script, which will handle running pw_maintainers_cli.py and
applying the series from patchwork for you:
https://git.dpdk.org/tools/dpdk-ci/tree/tools/create_series_artifact.py

The process create_series_artifact.py uses is:

1. Try to apply to the tree suggested by pw_maintainers_cli.py. If
successful, proceed.
2. If there was an apply failure in 1, try to apply again, this time on
main. If successful, proceed.
3. If 1 and 2 failed, indicate that there was an apply failure.

Also, if your automation failed to apply the patch, the best thing is to
report "_apply patch failure_" in your test_report email, and bail out of
running testing (so don't run meson test in this case).

And then as a separate matter, I see you mentioned the same sort of .rst
apply failure situation was seen on a patch you submitted recently. We do
not currently have a strategy for mitigating this, but perhaps we should
develop one. Do you have any ideas? I can also raise this discussion during
the CI meeting.

Thanks Shai.

[-- Attachment #2: Type: text/html, Size: 2373 bytes --]

Re: AWS lab meson test fails

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 2185 bytes --]

Oh, and of course I'll just raise that if the apply failure comes from
pw_maintainers_cli.py having guessed the wrong tree, the submitter can
always request a rebase and retest on a particular branch (which they can
specify) using the testing recheck framework:
https://core.dpdk.org/testing/#requesting-a-patch-retest

On Thu, Jun 12, 2025 at 8:38 AM Patrick Robb <probb@iol.unh.edu> wrote:

> Hi Shai,
>
> On Thu, Jun 12, 2025 at 6:20 AM Brandes, Shai <shaibran@amazon.com> wrote:
>
>> Hi Patrick,
>>
>> The failure status appears to be due to an issue applying the patch to
>> the release notes RTS file.
>> We suspect that the patch may have been applied to the incorrect DPDK
>> tree.
>> Could you advise if there is any specific metadata we should be using to
>> determine the correct tree for applying the patch?
>>
>
> Here is the script which should be used to determine the tree to apply the
> patchseries to:
> https://git.dpdk.org/tools/dpdk-ci/tree/tools/pw_maintainers_cli.py
>
> Even better than using that directly, though, is using this create series
> artifact script, which will handle running pw_maintainers_cli.py and
> applying the series from patchwork for you:
> https://git.dpdk.org/tools/dpdk-ci/tree/tools/create_series_artifact.py
>
> The process create_series_artifact.py uses is:
>
> 1. Try to apply to the tree suggested by pw_maintainers_cli.py. If
> successful, proceed.
> 2. If there was an apply failure in 1, try to apply again, this time on
> main. If successful, proceed.
> 3. If 1 and 2 failed, indicate that there was an apply failure.
>
> Also, if your automation failed to apply the patch, the best thing is to
> report "_apply patch failure_" in your test_report email, and bail out of
> running testing (so don't run meson test in this case).
>
> And then as a separate matter, I see you mentioned the same sort of .rst
> apply failure situation was seen on a patch you submitted recently. We do
> not currently have a strategy for mitigating this, but perhaps we should
> develop one. Do you have any ideas? I can also raise this discussion during
> the CI meeting.
>
> Thanks Shai.
>

[-- Attachment #2: Type: text/html, Size: 3174 bytes --]

RE: AWS lab meson test fails

[Brandes, Shai]

[-- Attachment #1: Type: text/plain, Size: 2613 bytes --]

Thanks for the detailed response, adding Wajeeh, who maintains the lab

From: Patrick Robb <probb@iol.unh.edu>
Sent: Thursday, June 12, 2025 3:43 PM
To: Brandes, Shai <shaibran@amazon.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>; ci@dpdk.org
Subject: RE: [EXTERNAL] AWS lab meson test fails


CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.


Oh, and of course I'll just raise that if the apply failure comes from pw_maintainers_cli.py having guessed the wrong tree, the submitter can always request a rebase and retest on a particular branch (which they can specify) using the testing recheck framework: https://core.dpdk.org/testing/#requesting-a-patch-retest

On Thu, Jun 12, 2025 at 8:38 AM Patrick Robb <probb@iol.unh.edu<mailto:probb@iol.unh.edu>> wrote:
Hi Shai,

On Thu, Jun 12, 2025 at 6:20 AM Brandes, Shai <shaibran@amazon.com<mailto:shaibran@amazon.com>> wrote:
Hi Patrick,

The failure status appears to be due to an issue applying the patch to the release notes RTS file.
We suspect that the patch may have been applied to the incorrect DPDK tree.
Could you advise if there is any specific metadata we should be using to determine the correct tree for applying the patch?

Here is the script which should be used to determine the tree to apply the patchseries to: https://git.dpdk.org/tools/dpdk-ci/tree/tools/pw_maintainers_cli.py

Even better than using that directly, though, is using this create series artifact script, which will handle running pw_maintainers_cli.py and applying the series from patchwork for you: https://git.dpdk.org/tools/dpdk-ci/tree/tools/create_series_artifact.py

The process create_series_artifact.py uses is:

1. Try to apply to the tree suggested by pw_maintainers_cli.py. If successful, proceed.
2. If there was an apply failure in 1, try to apply again, this time on main. If successful, proceed.
3. If 1 and 2 failed, indicate that there was an apply failure.

Also, if your automation failed to apply the patch, the best thing is to report "_apply patch failure_" in your test_report email, and bail out of running testing (so don't run meson test in this case).

And then as a separate matter, I see you mentioned the same sort of .rst apply failure situation was seen on a patch you submitted recently. We do not currently have a strategy for mitigating this, but perhaps we should develop one. Do you have any ideas? I can also raise this discussion during the CI meeting.

Thanks Shai.

[-- Attachment #2: Type: text/html, Size: 6958 bytes --]