From: Ali Alnubani <alialnu@nvidia.com>
To: Adam Hassick <ahassick@iol.unh.edu>
Cc: "ci@dpdk.org" <ci@dpdk.org>,
"aconole@redhat.com" <aconole@redhat.com>,
Owen Hilyard <ohilyard@iol.unh.edu>
Subject: RE: [PATCH v6 3/6] containers/builder: Dockerfile creation script
Date: Thu, 22 Jun 2023 16:52:47 +0000 [thread overview]
Message-ID: <DM4PR12MB516788C09A239C32FA5E2D67DA22A@DM4PR12MB5167.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAC-YWqjCoXrSsvR_5K89memiak58qQtkopF-EoXXOMhiUWauTQ@mail.gmail.com>
> This script is not intended to be run by the end user on their machine's bare environment. The CI worker container will acquire the needed python version to run this script when the container is built; the end user does not need to install python 3.10 themselves. The "make_docker_files_in_container" target in the Makefile is the intended way to call this script. The build and push targets then depend on that target.
>
> To me, this appears fine, but let me know if you have any concerns.
That's fine to me as well.
Thanks,
Ali
next prev parent reply other threads:[~2023-06-22 16:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 17:14 [PATCH v6 0/6] Community Lab Containers and Builder Engine Adam Hassick
2023-05-25 17:15 ` [PATCH v6 1/6] containers/docs: Add container builder start Adam Hassick
2023-05-25 17:15 ` [PATCH v6 2/6] containers/inventory: Add inventory for container builder Adam Hassick
2023-05-25 17:15 ` [PATCH v6 3/6] containers/builder: Dockerfile creation script Adam Hassick
2023-06-22 15:55 ` Ali Alnubani
2023-06-22 16:18 ` Adam Hassick
2023-06-22 16:52 ` Ali Alnubani [this message]
2023-05-25 17:15 ` [PATCH v6 4/6] containers/templates: Templates for Dockerfiles Adam Hassick
2023-06-22 15:40 ` Ali Alnubani
2023-06-22 16:08 ` Adam Hassick
2023-06-22 16:51 ` Ali Alnubani
2023-05-25 17:15 ` [PATCH v6 5/6] containers/container_builder: Container for python scripts Adam Hassick
2023-05-25 17:15 ` [PATCH v6 6/6] containers/Makefile: Makefile to automate builds Adam Hassick
2023-06-22 15:29 ` [PATCH v6 0/6] Community Lab Containers and Builder Engine Ali Alnubani
2023-06-22 19:28 ` Adam Hassick
2023-06-23 14:11 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB516788C09A239C32FA5E2D67DA22A@DM4PR12MB5167.namprd12.prod.outlook.com \
--to=alialnu@nvidia.com \
--cc=aconole@redhat.com \
--cc=ahassick@iol.unh.edu \
--cc=ci@dpdk.org \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).