From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 782EFA0C4B for ; Mon, 8 Nov 2021 08:45:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65F2E40DF7; Mon, 8 Nov 2021 08:45:33 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2069.outbound.protection.outlook.com [40.107.243.69]) by mails.dpdk.org (Postfix) with ESMTP id 3217340040 for ; Mon, 8 Nov 2021 08:45:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HY5jOJ1gH3mY60r5RuDlhrL4ENueQi7S82AO9vHsIYbW5koGK+OLT7Te3pUVeMfy7de16B3eTMzhvNoHD3clSnZbA9SHa3dGzj3nNsHqlJeAykULI4Sn73OgyIfrD6IpfjO5qrsPzRqfHpuwFpywxl+E2CSxY4QzBy42erQMAk3yPw7R7yZYzhuV+fyjw9IQq33+RL/+wvsyVlpSauLpYOJftL8Hjz0NkP3bpr+bnJ2jsY92qHsQimyMK/QzcGY6IrnN+gaRBjpeyMY77q3Ivsx6DGep2p8qem5NCbI/ogcTLVehjrrQ663NJX8Ako5NH4JbBtk0E2Gvwe5g3xz+uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AlNfBbh2SbkMnx8UhSWVFhcQ/6jZcYM65nfdyahIH6w=; b=Uuw/F7oNtv8zzWlxdW8Y9w/CR7DgfzZY0hvFZWiiXzHROLCL87kaX0ZV9PdeL135buyD56XOlhpDex2IXj/ik3qN5kCnjptTtz4BrOVXiSSLyhZeZ23r7ADrwJ2WlnCGIqDfm/I8dG7dj9npcw+a3jFsilLBmNQWA8V2vSPvyJ7EachIxF5wjkEvpjj2/C2KRvPTLRUfCp11Th8Oiuy1uroXgcy/B9rwMISgm/n9weQBDBAUvszDXVSic+unYpkOpzN/k83m5hXnyUSUSxBGk80cTYc9hTS5Fv8afsnKr9jdv9TJ7iuuYgwF5ZyRyCuojtwQ7dDo+15ZKzsulsX90g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AlNfBbh2SbkMnx8UhSWVFhcQ/6jZcYM65nfdyahIH6w=; b=Bx3KFyvtVSqpgWi93STtmZVHdj78UoHVfPlDKQSwUKO6tZRRdnDsPPmvcIt7jH7kIsJFcCVmIjC2y0LTERzOROCeXYeHPM2PtiBoyjE5twrSYVrThNyEDQc8KaVFFua9o9ihU3wsSHlUQ2zpEg5a+rZ7/SVxbYcxjnEwM7ZAizhev/b5ZaUdqIlLanXhsxmvggVsAYezTZ35g0ppmXNxyGK5F2VbkMhGFt07ausjk3gpjo7bESAIf01lUxhvB6CFTv1S2B3ZGgkfHPGW73irZWq5/9QZeH2ME6kx0rE0Sf+cSIetYbBZ1DXREf3jSfOnINFHmpmnC2lEG1hIexn3mg== Received: from DM4PR12MB5167.namprd12.prod.outlook.com (2603:10b6:5:396::10) by DM4PR12MB5261.namprd12.prod.outlook.com (2603:10b6:5:398::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16; Mon, 8 Nov 2021 07:45:30 +0000 Received: from DM4PR12MB5167.namprd12.prod.outlook.com ([fe80::c5e8:f3c:53d9:d6ce]) by DM4PR12MB5167.namprd12.prod.outlook.com ([fe80::c5e8:f3c:53d9:d6ce%9]) with mapi id 15.20.4669.013; Mon, 8 Nov 2021 07:45:30 +0000 From: Ali Alnubani To: NBU-Contact-Thomas Monjalon CC: "ci@dpdk.org" , "jerinj@marvell.com" , "ferruh.yigit@intel.com" , "david.marchand@redhat.com" , "juraj.linkes@pantheon.tech" Thread-Topic: [PATCH v2 05/10] tools: add functionality for setting pw delegates Thread-Index: AQHXtdu5qAm+7mlJpkCgH71Ih8ojTavYfQEggAz9LoCADjDWkIAAOXCAgAWYyDA= Date: Mon, 8 Nov 2021 07:45:30 +0000 Message-ID: References: <20210906154537.1299-1-alialnu@nvidia.com> <1810993.5c47M4QTcs@thomas> <2566422.rZZgpRVHQ4@thomas> In-Reply-To: <2566422.rZZgpRVHQ4@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e5c2adab-890f-410c-9a9a-08d9a28bbd44 x-ms-traffictypediagnostic: DM4PR12MB5261: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OC0CMGXKkRNfrkxjBnOrOimUUuLNsV/uEKwXi15lw3fM5nuM2fhBlgA73s18EQU0Een9TTvFvrLd5gBF75uo/UzJ0eXCCa3lAQnTKdCqCLdU48RnfaAFtdn1swlKp6tzcIMDq+z8eFoHVrcMbKOdQLpWNIkKxC+7FQtAO9xvszW7XH6Pvkn6k3Lv0xo2fb3avKwpoO42iE6L2g9s3ijXtBtx4Gr7wSAul8y3ly1Z05HaG0atj3/jkwQ1dwa6o+RB2yI8hI6iNzLL1MKyRfdZZbaZxoR7g99uXZRYmB8XfOWvBST6WjAnCxJDCEWS8IOAEq8RgCcWftWpw13OrsBtobIdaACooj5qhb/F0SzYg08+abLMLVy4SRGN1IuNZtOfMkE56eKDsXnEj2KQ08N+rc2Kj1K8eTgPmiZKvCRVr8p4f7bi0wu2qwQfNv+qyOHSFCNaFAxO+FpEbcW9Rl/HZ0gOFn4p/pqZz4cWsM/znf+lusAXja0pf1AzFAkxosm8xbDAnEj7IyJ6cszilpzyUPJOVT9oQ4PzEuLRITL6Qdybp820nZxAiCr+Lr3xsIZOb8+6z/UNGHuF3kK2mOqpXUZOj7nhVeq3392wndYRBrVhrnC5EyA4kQL6IFTmm5nggEVSxRNTM3Rvls/+JODvA+qW4H3CjlRVlEWu4ZPw7Rx3F7MiHTcpQBjxd4zGfIrc8sOWnV1TswoAUnYfQZ4vltxibqzpeZEhH40QUOPuFXOKgmvpW51GIsLYx9+xqMIDSH1IgaT6/baDPWQaTyAhvQKj/eRe5SaFbHyCK+fQ0NY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5167.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(966005)(52536014)(55016002)(4326008)(38070700005)(71200400001)(54906003)(7696005)(33656002)(316002)(9686003)(2906002)(186003)(6916009)(8936002)(6506007)(53546011)(8676002)(86362001)(76116006)(122000001)(508600001)(66946007)(26005)(38100700002)(5660300002)(66446008)(66476007)(66556008)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W874E3TUP6oeRCH2xMRS+Jv+0QuUkFCKrn7KlWdfW6F+69ZPtApVQG0vf9zQ?= =?us-ascii?Q?mz0MAlJYcO27dMzi36gbVbFtMPQYxQFAwPe1FoL2HrB2dIJ3p8WGdlM0i6QB?= =?us-ascii?Q?ZYaJlbSiXDlyShU6Clkv5dC5pyK8L753koYFeHbAsJ56G5JY52OYSufV3a1B?= =?us-ascii?Q?TaHGdcVaRc/jqL449loDRVTPls9fyW8xxrAcMENjA6zV/57b4gJsRrHLIYDd?= =?us-ascii?Q?up4uEK2TBQHc3OKCBqZ6mDlgFOUHcxbNJLJ+bqH+v25O/mIhQJ6doRmlRQj9?= =?us-ascii?Q?x1HDZZnX5bHPclBT62cy1BPwdiaofz30xmdcR9L/7Z80RuPbbSBBiNMwTPao?= =?us-ascii?Q?oh+REcjfkrYlG1y0O7NzUsfDY+5I5LAmrymarhmGoMjEAhtHEwnR6jm8/jCr?= =?us-ascii?Q?7iJqk+ilzeKrz2O/dfmzQdDN4a26N3FIRm+AHl4JPrzezfyPBNBb7q1ghfKR?= =?us-ascii?Q?mQw9pyi+qPP7NEvmSKCHf2B/SSBIDCKyBW4wa5Mi1GwSIYJujU93dcMZdo9C?= =?us-ascii?Q?rSbj5NpVILGYeHCo3y4zXJqCzo90BsB4J6huGOa7yC4vQ1iIPz4K4w0yRFcC?= =?us-ascii?Q?NDrkvdvdxOT/HxLH9SzSyavS76gZkMkDV1VI2jmUsxnUS6lx5zfEcj09xBLY?= =?us-ascii?Q?TkGL3YsuFKoVfhluGweAiMB+L/6Fd1tJCJl+Bb5eWdScs0D5G3AaHr4uUp1u?= =?us-ascii?Q?2NfdKbpDUAUmHimfvScDxsuC/cfjqjcttn+MYWEcCTI/HT/sfJLEawCc9iZ+?= =?us-ascii?Q?Ti4yaYCJ87L8t3pheMJw2Gxmu9n+AG38ZQXqUuQgK/HUzKkWIWg+x4jN0Zoi?= =?us-ascii?Q?LhQHp4jI25xExMR6aLosPD3PBwKsxVUUS2s9+Nenpm3y7ehiqCctOgHmC27E?= =?us-ascii?Q?yYLlOUkGlDJtsKfpDx8wyZK/e8fC2mS/5Li8poUS3Ii9pEswzWrFcQwyrFkW?= =?us-ascii?Q?A1O8Pd9DUwS+PlsqgPgyilwWNIWJbs7bSDULojkl2+p5YqpugQzb13mJw7h4?= =?us-ascii?Q?VJPLT49JoXHLqZUu8iV3it2Mh1mqips1wAQHVLhYtYRjwZcP3ASySaytiv6b?= =?us-ascii?Q?KXGngs6sVKrLqYEpCvchdGFQQqDNsB2WDSMJJAM+Yf8IqbUPsGX/DUccVnqh?= =?us-ascii?Q?Sm8BiyHex/umN7tSmDDKedIryECelphOssVyzRTu/sAgTQDULVmRmmC++Fcz?= =?us-ascii?Q?jI37sOUI4Uaqm9EAP1R0ooBZ0gK9GHDi2/oKl2xL57Y9/iEZZnlRUZN87UIX?= =?us-ascii?Q?svHQENeM7StOTBV0S/Wx/Z7ewhIebIj2XBUSRxcg5zDtBty/StDdNQ/m5ax9?= =?us-ascii?Q?HraYSR37GipTlZuOKwGhKC0PgPV85aIej40qiFKKtDVnXrAsLEbdKBrwOpfB?= =?us-ascii?Q?b9GazE/pB9TtuO+jmWqzWbFxulWmsKSJp4cmibLzQF+mjWD6C0Ybeg60RDBx?= =?us-ascii?Q?iuoo1dQVFIyPnH3+tsJ3rjD0UGPbmqTcwqQI0RC1xZx7FzUBjy/5rtywFEj5?= =?us-ascii?Q?oTDkSzCI6/sVKPdfrfpxqfWoPEVfqXwZV+nVT++nirK+n4JWsmx0jmatTUCh?= =?us-ascii?Q?sN9SuAQqk/IVwQsrfP2cAoqcFJd/E/yMtd5fneGNMbovmfQ7smgXnDkhPF7s?= =?us-ascii?Q?kemBINOGQ/Mhiyy3PHJu+4Q=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5167.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5c2adab-890f-410c-9a9a-08d9a28bbd44 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2021 07:45:30.8860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q/82n8XRAYJnOBG+UBAFkA6oYUieZmNzSStuJa2ySLq0J1DwBiMqNg+Rcdycb4lcRPJN4EM/xSD+wsvLAzPPUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5261 Subject: Re: [dpdk-ci] [PATCH v2 05/10] tools: add functionality for setting pw delegates X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, November 4, 2021 8:16 PM > To: Ali Alnubani > Cc: ci@dpdk.org; jerinj@marvell.com; ferruh.yigit@intel.com; > david.marchand@redhat.com; juraj.linkes@pantheon.tech > Subject: Re: [PATCH v2 05/10] tools: add functionality for setting pw > delegates >=20 > 04/11/2021 17:48, Ali Alnubani: > > From: Thomas Monjalon > > > 18/10/2021 09:48, Ali Alnubani: > > > > From: Thomas Monjalon > > > > > 21/09/2021 16:35, alialnu@nvidia.com: > > > > > > From: Ali Alnubani > > > > > > > > > > > > A new command was added to set patch delegates in Patchwork > > > > > > based on the emails found in DPDK's MAINTAINERS file. > > > > > > > > > > > > Example usage: > > > > > > $ export MAINTAINERS_FILE_PATH=3D/path/to/dpdk/MAINTAINERS > > > > > > $ ./pw_maintainers_cli.py --type series set_pw_delegate > SERIES_ID > > > > > > > > > > > > Signed-off-by: Ali Alnubani > > > > > > --- > > > > > > + def set_delegate(self, patch_list, delegate): > > > > > > + """Set the delegate for a patch. > > > > > > + Only tries to set a delegate for patches that don't ha= ve > > > > > > + one set already. > > > > > > > > > > I'm not sure we should skip patches which are already delegated. > > > > > If we use the command to explicitly delegate the patch, > > > > > we should do it, right? > > > > > > > > > > The skip logic may be implemented at a higher level in the CI. > > > > > > > > I added an arg (--force_set_delegate) to force overriding delegates= in > v3. > > > > > > Given the command is to set delegate, the force looks strange to me. > > > Wouldn't it be more logical to add an option to skip already delegate= d > > > patches? > > > > Isn't it safer not to force overriding the delegate by default? > > Users can send patches with the header "X-Patchwork-Delegate" to set a > specific delegate. Maintainers might want to set another user as the > delegate when there are multiple delegates in the MAINTAINERS file for a > patch. Should we override these by default? >=20 > These considerations don't contradict with the option name. > If we have the option --skip-delegated (or --only-non-delegated), > we can always use this option in the automatic run. >=20 > But for a manual run, I expect the script to delegate a patch > the user explicitly wants to set, without requiring a "force" option. Thanks for the feedback, updated in v4 and added a --skip-delegated arg ins= tead: https://inbox.dpdk.org/ci/20211108062815.7614-6-alialnu@nvidia.com/T/#u