From: Ali Alnubani <alialnu@oss.nvidia.com>
To: "ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>,
"ci@dpdk.org" <ci@dpdk.org>
Cc: "aconole@redhat.com" <aconole@redhat.com>
Subject: Re: [dpdk-ci] [PATCH 2/2] guess_git_tree: edge case and style changes
Date: Mon, 11 Oct 2021 17:38:06 +0000 [thread overview]
Message-ID: <DM4PR12MB5167FCB58F8CC8C03E2DE951DAB59@DM4PR12MB5167.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210924160527.45602-2-ohilyard@iol.unh.edu>
> -----Original Message-----
> From: ci <ci-bounces@dpdk.org> On Behalf Of ohilyard@iol.unh.edu
> Sent: Friday, September 24, 2021 7:05 PM
> To: ci@dpdk.org
> Cc: aconole@redhat.com; Owen Hilyard <ohilyard@iol.unh.edu>
> Subject: [dpdk-ci] [PATCH 2/2] guess_git_tree: edge case and style changes
>
> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> The import statements in the file have been moved below the module doc
> comment per PEP 257.
>
> A sanity check has been added to find_filenames. Occasionally, due to
> how the community lab internally handles getting patches from
> patchworks, a patch will result in no diff. This patch adds handling for
> this case.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
The subject (commit summary) should be an imperative sentence (see https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line).
I also think it would be better to split this into 2 patches (one for the style fix, and one for the empty list).
Thanks,
Ali
next prev parent reply other threads:[~2021-10-11 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 16:05 [dpdk-ci] [PATCH 1/2] create_new_execution_file_from_tags: add test specifier ohilyard
2021-09-24 16:05 ` [dpdk-ci] [PATCH 2/2] guess_git_tree: edge case and style changes ohilyard
2021-10-11 17:38 ` Ali Alnubani [this message]
2021-10-11 17:53 ` [dpdk-ci] [PATCH 1/2] create_new_execution_file_from_tags: add test specifier Ali Alnubani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5167FCB58F8CC8C03E2DE951DAB59@DM4PR12MB5167.namprd12.prod.outlook.com \
--to=alialnu@oss.nvidia.com \
--cc=aconole@redhat.com \
--cc=ci@dpdk.org \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).