From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1212543063; Mon, 14 Aug 2023 17:22:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C272410F1; Mon, 14 Aug 2023 17:22:32 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 6976940A8A; Mon, 14 Aug 2023 17:22:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692026550; x=1723562550; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=X5XRNuOq6U108ksTVrEyGpOe/8Mr7z2iR4DyzhivHbw=; b=bSHJjlNdjy1+lxCr3Qm27VDkA8wGmq6//1FGvXOjkVyL3m1in/NC/JuC Ri2iuc7zU7928bU9uzMHP8lV7wXkH05mtIdN56e1LiE57SVPVo7gSGGOP t7pnESQ4vsrrxrFUPypR039S/hd0tdsoqbpzMI9lBbu5QiWo5OJUpRIJh fWwY7CWG0br6w8Y/L0YVCO0gyMuhFDnh30ZDylDk71uag1q8wak6hJdyZ HIwP2KNFBFzPRY0PbF/C9VyCCCwWTFJ3Jth+fmnYwIMkJEG79rPpe+TIM LECGzVK56sacmpmRADlCO9mpg5dIEZCE20oCMVq9D25ixT+bki7paJq5+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="374836828" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="374836828" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 08:22:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="847696512" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="847696512" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 14 Aug 2023 08:22:26 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 08:22:25 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 14 Aug 2023 08:22:25 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 14 Aug 2023 08:22:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aj/yybVJB3H1saFsCxIePRbg2nxoeyKZlod2gEE6NqbhMuDXAkKqSkKOGynVEG8Znu38FljVNjmnwfWebpo/zWWMr1qhUvUi434NU8Kr7C8uve23WAu0DkzGHThIOvY+yv1nO2FlAUhc9hm8TfUqjn6kRpr2RVv3buq7x0uOk5XKj6cEtL+/Q7SiCu839bhfppazhAy1oUzNZ7ms8UoJU1AZO0JZ5PB2mRwvDv9PldmIUu5OgTmZzSU0QsDxfW541ctwSHl0bldGcoJWGa/3HOgC6L9ZG9Y+MF+4gbUHQchF2VUwyfQfRJS38/i7CNAgh6FRwSc5g1WVAAuPO0JuzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0otFrevmFlRBbq2ScFPHrqlreiDZKOj/YNr3/uzp45g=; b=X28DVU9hKMEuyZyEWAJIFHYikD952Xp1ah+w+5aN0Q5emZQrhj937hLHQsiKQFJ++6b5DC0aht0Tla6UreqQ2yrxO9BsuYC84Qjj9gj2nivvBSNYoPcUqIldtnBsCUT+UhldJuTI6fNRDZttXV1Fxg0kgBVhNaOPgkrE0cXjbY6I5yclOIiaHduZphhbUBK/mT0pB8cy3YWgso4WLmBA7IZfdTUSYcSD201EOp6h+s58swMXkbVPmhpLvHC15/Eokdcw8RwBxcxtQGCm1a7d38U1aulmw5ix47yEZ5Mf9hbc+u3gLnSwiA0lJZXjWGvejjQ4MzgDKiaeWAKcWrYZrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB7805.namprd11.prod.outlook.com (2603:10b6:8:ea::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.23; Mon, 14 Aug 2023 15:22:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.022; Mon, 14 Aug 2023 15:22:23 +0000 Date: Mon, 14 Aug 2023 16:22:17 +0100 From: Bruce Richardson To: CC: Subject: Re: [PATCH v2 0/8] expand list of optional libraries Message-ID: References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230814151609.3077077-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230814151609.3077077-1-bruce.richardson@intel.com> X-ClientProxiedBy: DBBPR09CA0014.eurprd09.prod.outlook.com (2603:10a6:10:c0::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB7805:EE_ X-MS-Office365-Filtering-Correlation-Id: bc3c2e71-a401-4f55-a97b-08db9cda4259 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: glszcLSagspbNSGS7LMJ1ZZ57mGyc7u9mUOadNqVDCY2T/l9g1HymAbobCRyzeXQTEOYF8csIKkwKWIg10sAXci1hvlZIa3k/ooWW0IJaY2CEC0GJX7u0IzzZbN3N4uEKhC30+huYckQavPDT466mMo4Ipn/RMZKjEImUz4k++UxOhqyr/K7sDdhK59mt0imRr3mthSXqFbUijq6/hM08n0hHsGPX/g1NB+exiykjPOkb91viuC7f2CwgFLSR+XPfrL+4FeBGvgZZ7vy6dUzKZW4gX8uC5DI7E7Tus5TwPnfoGcUz0Cn6EI23btNRCFFwngwlIJj5zHS2VqIeCIySDElUHCChGBpjhfijSWPtFMxS6b3hq2vN+G2BaKaozWSe6DkrkEZ6dnyI6qylDQ5TeFKEoouUG7tPUF8N+u/6ceJwCY6ALR0sD9ji/QQ2x3HWGlM/i4HYLnhHLeqpUlDQvujwOlH7sP3lQNHyz77E3kC/86kP/DJGoNqAZhs+UYaSP39cZyWIlRSQmuF6Lr40uDeaMIgRc3ZBYusckiI6v3zQrMyyo58kHaZnLCFeT0a X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199021)(186006)(1800799006)(44832011)(5660300002)(2906002)(86362001)(83380400001)(66946007)(66556008)(66476007)(6916009)(4326008)(450100002)(38100700002)(316002)(41300700001)(26005)(6512007)(6486002)(6506007)(6666004)(8676002)(8936002)(478600001)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T1cUssSlLDegpcaMkXoqMFomRWGKspMwfIV9twayWtAWYnVijTgCxvCsXYKq?= =?us-ascii?Q?F9t5bG/KzkpFmVRuvLkzLBRMyeYVxwh45n/Y9sSqj8BRx6qySSxyEXuFS12v?= =?us-ascii?Q?1yNM/ozxueTQ7HN6RpZ82TY7E7uyPPxYP6R1XD61szUQTKbsRnUGW8Llobpg?= =?us-ascii?Q?lmRrHR53taNTgQgYbVoTyyrtu6mbgCXcJ6ys/A3HKaIU6qvDj+uNCzLqW4Zb?= =?us-ascii?Q?HlJwRoIebtog01LxW3QDyxbKGsx0RHtaVJHTPVG2TVQ4yIrLjOPZcM4N7PFO?= =?us-ascii?Q?iX125v9XAk3XmazOyAy9xs4BsDW1nEK3+BGVgfqfgfRCr9PGCTbyV1AwikX5?= =?us-ascii?Q?jiZ86Y3Zh7/7JBrboq3hpL8GmV47Y31LHGQijZKKpUHa5t+Q4l+Yx8KbHM5z?= =?us-ascii?Q?U61Fls4KlXmk7sWvd/Djj/y/4VtwLJAC0MGQrUCK5UxSlPzxNE6kslR9AUGQ?= =?us-ascii?Q?1e1jIJ3MY0KJZCohiaux52s+ap8BDTKBtKTl50pX5Wz/uP2vNHI5lJ8VPKmb?= =?us-ascii?Q?6YY4p+FBgnd8SNdT4jGhU0AThXdsiIP0mSwTqT2e+PjiKV6f+EpwrFMhr9fK?= =?us-ascii?Q?a7ADLA94+Aujk9hWMDASzJ3jMETe8r8h1kNi0uiN9skt0krLSKj76IByIYHF?= =?us-ascii?Q?2MnByubj9i49FGyT0rHp3YOK4wcDr8cIQq49AU513EgS1iV/x0n+joZzFtJl?= =?us-ascii?Q?Ctut5WFkzPMasb1AIXUBpk9xAcpmgkxrMGbx5hOFLjcsGDJB8xnM8CLaiiDV?= =?us-ascii?Q?pGeSY6gGnTCuWnEiIVein9yRq7U+6PtGN46TJXIjosH5nUG3vjldst5ZskkY?= =?us-ascii?Q?azimG3hb/1vAeA+b+7we+3mqcRmOV+8Z6MMl1XtcvA2HOrr+V8mbjMGns4m2?= =?us-ascii?Q?0FT0+FyhL0nmOzVCkwOAVCR8IFjNtRb8b7orBxyUMXnR5XrBdSXqveWY/I01?= =?us-ascii?Q?QA8D8j41HO6NjsJc1GEMkX86+M+jLRzlXMk/wNcSPFDJRtIC2RHGm929kCGQ?= =?us-ascii?Q?kxbTkvS6cX/vL5J2d9IZOlz5qzXFWiRol5w2doCDtjkiWfKrQxFxi9ohJ+O4?= =?us-ascii?Q?V+ZKjmcGQcRknDFg2mSQH+ptgA71TSgcej9Vf7Nc2P9IYDvGAieIlC8TBH6c?= =?us-ascii?Q?qVxCtBnb57H53XY3NHVyoxQD0IwbSeiZL4Q+W+tm/0j0YC/8Je8SK4h/P20B?= =?us-ascii?Q?RQVTbudR7dfkuegET9/sP0FaU+H/i7pgEaj7FWGNl0KptcVaBeJX1wgjExSd?= =?us-ascii?Q?9KZHvFwBlMwERPmfhKOmZW9UomlVW/pSbPtoQ/aaR3L/kYSosscGj7Pto3Q3?= =?us-ascii?Q?VqWExUVirFQrhvqQpoKQNsgWXVAar2M8hwJP0nkRArfGGyfA/qrkzMPvZeGQ?= =?us-ascii?Q?MJmsvy92GsijjHNmta0lWA2qeh88H7Gq35f7XKekK/UmOd+AXxwqa7qcwBd+?= =?us-ascii?Q?h5BGpKk/9wqKs4Q5wjulgG70d37dRuWOdlK/x1S/7Kf8ocCKb7qonl/H92D3?= =?us-ascii?Q?QEeJh7yyKrVSIl9EbzF0Z9NOfwqpe2jEWFizoq/BSMTsaiTZNdu8lpt9MtDq?= =?us-ascii?Q?ho4GlgQW67Fu5rzvIfVwmQROh+zdBFLV+Epee5oZqctLc5yuM4aJOv2tzBB4?= =?us-ascii?Q?Ew=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bc3c2e71-a401-4f55-a97b-08db9cda4259 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 15:22:23.5711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7oI2cxeQ3FvOr9fYOB4z+DyZhWxua7Aw/2hj4Z+NXRJKo8zAXMQDwKFoIanVnRk6z+Uo/jkGiTwSeFeQaIAo6nlXo9RHEBkR07FsKcAnjzc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7805 X-OriginatorOrg: intel.com X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On Mon, Aug 14, 2023 at 04:16:01PM +0100, Bruce Richardson wrote: > This patchset contains changes to DPDK to make the build more configurable > overall. The changes can be grouped into two areas: > > * Firstly, there are changes to make the build of the unit tests more > flexible and maintainable. These 5 patches switch the unit tests from > having separate hard-coded lists of files and tests, with lots of > conditional logic to add/remove items from the list, to instead being > a single list of files and dependencies per-file. The actual lists of > test-suites are built up dynamically from the list of files whose > dependencies are met and therefore will be part of the build. > This rework enables... > * The second set of patches which expands the list of libraries which > can be disabled at build-time, while still giving a successful build > of DPDK. Overall, after this set is applied, the list of optional > libraries in DPDK is approx doubled in size. [15 additions giving > 31 optional libs] > > NOTES: > * as stated in the RFC, the test binary moves in the build as a result > of this set - from app/test/dpdk-test to app/dpdk-test. > * running the suites of tests no longer works after patch 4 until patch > 5 is applied. If this is an issue, the two patches can be merged on > apply. However, the individual tests are still runnable through the > test binary - it's only through "meson test" that there are issues, so > I'm keeping the patches separate since each is relatively complex in its > own right. > Apologies, some other things I neglected to mention in the notes above. This patchset has revealed some issues with the building and running of unit tests: * Some files/tests were not getting built, and look to have been missed years ago in the move from make to meson. Specifically those tests using external resources, e.g. the cfgfile tests, are not buildable and have not been for years. * There are quite a number of tests defined that are not registered in a test suite in meson and which cannot be run through meson test. Since the test cases were automatically tagged via script when generating this patchset, the offending test cases can now be found by grepping the sources for use of the old "REGISTER_TEST_COMMAND" macro. The fixing of these issues I consider outside the scope of this set, and won't be looking at in subsequent revisions. Hopefully #2 should be fairly easy to rectify in future, but #1 may be more complex. /Bruce