From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41F3AA04B7 for ; Wed, 14 Oct 2020 16:38:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BD7E1DE7F; Wed, 14 Oct 2020 16:38:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 0AF161DE6F for ; Wed, 14 Oct 2020 16:38:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602686289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Agf7es6xaNirYoQL7uML5e/e/IxSsEOpxbsrC+zlBA=; b=V7yFwJQPqinO9AJMrxgdOixmCH6VRTZ1LJRx94B+TkPwuoY3N+VljoqzQ2omqH17c6uQKq K0G8/hfgSu1XZtivOA7/SIkxIN+Zrpgal/ySz0o1DZiRXxC7tHfnORT063R4HceSJH9kO5 tFdlN9gP0WGAbU3u8SIO6yIR8t7KUd8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-s5b0yJjNM8Osai247kuuGg-1; Wed, 14 Oct 2020 10:38:04 -0400 X-MC-Unique: s5b0yJjNM8Osai247kuuGg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9170B802B6D; Wed, 14 Oct 2020 14:38:03 +0000 (UTC) Received: from [10.36.110.38] (unknown [10.36.110.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 84D3A75131; Wed, 14 Oct 2020 14:37:58 +0000 (UTC) To: Dmitry Kozlyuk , dev@dpdk.org Cc: ci@dpdk.org, Stephen Hemminger , David Marchand , Thomas Monjalon , Neil Horman References: <20200927214732.12783-1-dmitry.kozliuk@gmail.com> <20201004015947.9012-1-dmitry.kozliuk@gmail.com> From: Maxime Coquelin Message-ID: Date: Wed, 14 Oct 2020 16:37:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201004015947.9012-1-dmitry.kozliuk@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH v6 0/3] pmdinfogen: rewrite in Python X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" Archived-At: List-Archive: Hi Dmitry, On 10/4/20 3:59 AM, Dmitry Kozlyuk wrote: > This patchset implements existing pmdinfogen logic in Python, replaces > and removes the old code. The goals of rewriting are: > > * easier maintenance by using a more high-level language, > * simpler build process without host application and libelf, > * foundation for adding Windows support. > > Travis CI script is adjusted to install python3-pyelftools, but other CI > systems may need similar tweaking. Particularly, testing on FreeBSD and > big-endian targets is desired. > > Acked-by: Neil Horman > > --- > Changes in v6: > > 1. Address yapf and pylint warnings (Stephen Hemminger). > 2. Add myself as new implementation maintainer (Thomas Monjalon). > > Dmitry Kozlyuk (3): > pmdinfogen: add Python implementation > build: use Python pmdinfogen > pmdinfogen: remove C implementation > > .travis.yml | 2 +- > MAINTAINERS | 3 +- > buildtools/gen-pmdinfo-cfile.sh | 6 +- > buildtools/meson.build | 1 + > buildtools/pmdinfogen.py | 189 ++++++++++++ > buildtools/pmdinfogen/meson.build | 14 - > buildtools/pmdinfogen/pmdinfogen.c | 456 ----------------------------- > buildtools/pmdinfogen/pmdinfogen.h | 119 -------- > doc/guides/linux_gsg/sys_reqs.rst | 6 + > drivers/meson.build | 2 +- > meson.build | 1 - > 11 files changed, 203 insertions(+), 596 deletions(-) > create mode 100755 buildtools/pmdinfogen.py > delete mode 100644 buildtools/pmdinfogen/meson.build > delete mode 100644 buildtools/pmdinfogen/pmdinfogen.c > delete mode 100644 buildtools/pmdinfogen/pmdinfogen.h > Ninja fails when pyelftools is not installed. Shouldn't meson detect and report it before build time? Thanks, Maxime