DPDK CI discussions
 help / color / mirror / Atom feed
From: "Brandes, Shai" <shaibran@amazon.com>
To: Patrick Robb <probb@iol.unh.edu>, "Atrash, Wajeeh" <atrwajee@amazon.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	"ci@dpdk.org" <ci@dpdk.org>
Subject: RE: AWS lab meson test fails
Date: Thu, 12 Jun 2025 13:06:02 +0000	[thread overview]
Message-ID: <f6bc7651345946609f968d3fd9d49655@amazon.com> (raw)
In-Reply-To: <CAJvnSUCPS3b5BUN6mJAOXAOwNFfU1S+xcG+uNiWz8vKfO8oS7A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2613 bytes --]

Thanks for the detailed response, adding Wajeeh, who maintains the lab

From: Patrick Robb <probb@iol.unh.edu>
Sent: Thursday, June 12, 2025 3:43 PM
To: Brandes, Shai <shaibran@amazon.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>; ci@dpdk.org
Subject: RE: [EXTERNAL] AWS lab meson test fails


CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.


Oh, and of course I'll just raise that if the apply failure comes from pw_maintainers_cli.py having guessed the wrong tree, the submitter can always request a rebase and retest on a particular branch (which they can specify) using the testing recheck framework: https://core.dpdk.org/testing/#requesting-a-patch-retest

On Thu, Jun 12, 2025 at 8:38 AM Patrick Robb <probb@iol.unh.edu<mailto:probb@iol.unh.edu>> wrote:
Hi Shai,

On Thu, Jun 12, 2025 at 6:20 AM Brandes, Shai <shaibran@amazon.com<mailto:shaibran@amazon.com>> wrote:
Hi Patrick,

The failure status appears to be due to an issue applying the patch to the release notes RTS file.
We suspect that the patch may have been applied to the incorrect DPDK tree.
Could you advise if there is any specific metadata we should be using to determine the correct tree for applying the patch?

Here is the script which should be used to determine the tree to apply the patchseries to: https://git.dpdk.org/tools/dpdk-ci/tree/tools/pw_maintainers_cli.py

Even better than using that directly, though, is using this create series artifact script, which will handle running pw_maintainers_cli.py and applying the series from patchwork for you: https://git.dpdk.org/tools/dpdk-ci/tree/tools/create_series_artifact.py

The process create_series_artifact.py uses is:

1. Try to apply to the tree suggested by pw_maintainers_cli.py. If successful, proceed.
2. If there was an apply failure in 1, try to apply again, this time on main. If successful, proceed.
3. If 1 and 2 failed, indicate that there was an apply failure.

Also, if your automation failed to apply the patch, the best thing is to report "_apply patch failure_" in your test_report email, and bail out of running testing (so don't run meson test in this case).

And then as a separate matter, I see you mentioned the same sort of .rst apply failure situation was seen on a patch you submitted recently. We do not currently have a strategy for mitigating this, but perhaps we should develop one. Do you have any ideas? I can also raise this discussion during the CI meeting.

Thanks Shai.

[-- Attachment #2: Type: text/html, Size: 6958 bytes --]

      reply	other threads:[~2025-06-12 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 17:39 Patrick Robb
2025-06-12 10:20 ` Brandes, Shai
2025-06-12 11:59   ` Brandes, Shai
2025-06-12 12:38   ` Patrick Robb
2025-06-12 12:42     ` Patrick Robb
2025-06-12 13:06       ` Brandes, Shai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6bc7651345946609f968d3fd9d49655@amazon.com \
    --to=shaibran@amazon.com \
    --cc=atrwajee@amazon.com \
    --cc=bruce.richardson@intel.com \
    --cc=ci@dpdk.org \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).