Re: [dpdk-ci] [RFC pw-ci] pw_mon: check for recheck requested comments

[Aaron Conole <aconole@redhat.com>]

David Marchand <david.marchand@redhat.com> writes:

> On Wed, May 19, 2021 at 4:18 PM Aaron Conole <aconole@redhat.com> wrote:
>>
>> ENOTREADY: Missing the actual recheck logic... needs some input /
>>            design before committing to anything.
>>
>> When a developer wants to ask for a test case recheck (for example,
>> maybe to rerun the github-actions test suite), we scan for the specific
>> line:
>>
>> ^Recheck-request: .*$
>>
>> The line would break up as:
>>
>>    Recheck-request: [context]
>>
>> where '[context]' is the name of the check (as it appears in the UI).
>> For example, if we look at a patch that has 'github-robot', we can
>> request a recheck of the series by sending an email reply with the line:
>
> It could happen that the tree was broken and we want to rerun all or a
> list of tests.
> Coud we accept multiple ^Recheck-request lines?

I guess we can solve this with the comma separated list.

> Or maybe have a magic "all" context?

That might require more thought, but it's possible.  Do you think it
would be better than doing a comma separated list?

>>
>> Recheck-request: github-robot
>>
>> It is important to use the 'msgid' field to distinguish recheck
>> requests.  Otherwise, we will continuously reparse the same
>> recheck request and loop forever.  Additionally, we've discussed using a
>> counter to limit the recheck requests to a single 'recheck' per test
>> name.
>>
>> As an additional change, we run after the 'superseded' and 'completed'
>> checks, to ensure that we don't bother parsing comments from older
>> series that aren't relevant any longer.
>
> There was also an ask on filtering requesters (only maintainers and
> patch authors can ask for a recheck).