From: Aaron Conole <aconole@redhat.com>
To: Patrick Robb <probb@iol.unh.edu>
Cc: Ali Alnubani <alialnu@nvidia.com>, "ci@dpdk.org" <ci@dpdk.org>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
"ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>
Subject: Re: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff
Date: Wed, 21 Jun 2023 14:38:28 -0400 [thread overview]
Message-ID: <f7ty1kcslsr.fsf@redhat.com> (raw)
In-Reply-To: <CAJvnSUBRT=JGX3NwNdguKPUKJ6SqPuVi+2OsXVa8SWwhDKY03Q@mail.gmail.com> (Patrick Robb's message of "Wed, 21 Jun 2023 11:39:53 -0400")
Patrick Robb <probb@iol.unh.edu> writes:
> Patrick, are [1/3] and [2/3] still needed as well?
>
> Yes please on both. We are currently using 1/3 in our Jenkins process for including tag arguments in creating
> the execution file. Thanks for raising this.
Looks like this slipped my queue. I'll apply it now.
Thanks.
>
>
> On Wed, Jun 21, 2023 at 11:19 AM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> > -----Original Message-----
> > From: Ali Alnubani <alialnu@nvidia.com>
> > Sent: Monday, February 7, 2022 5:56 PM
> > To: ohilyard@iol.unh.edu; ci@dpdk.org
> > Subject: RE: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff
> >
> > > -----Original Message-----
> > > From: ohilyard@iol.unh.edu <ohilyard@iol.unh.edu>
> > > Sent: Monday, February 7, 2022 5:08 PM
> > > To: ci@dpdk.org; Ali Alnubani <alialnu@nvidia.com>
> > > Cc: Owen Hilyard <ohilyard@iol.unh.edu>
> > > Subject: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff
> > >
> > > From: Owen Hilyard <ohilyard@iol.unh.edu>
> > >
> > > A sanity check has been added to find_filenames. Occasionally, due to
> > > how the community lab internally handles getting patches from
> > > patchworks, a patch will result in no diff. This patch adds handling for
> > > this case.
> > >
> > > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> > > ---
> >
> > Thanks Owen.
> >
> > Tested-by: Ali Alnubani <alialnu@nvidia.com>
> > Acked-by: Ali Alnubani <alialnu@nvidia.com>
>
> Hi Thomas and Aaron,
>
> Can we merge this patch? Pull requests can still cause the script to crash because they have an empty
> diff.
>
> Patrick, are [1/3] and [2/3] still needed as well?
>
> Thanks,
> Ali
next prev parent reply other threads:[~2023-06-21 18:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 14:00 [dpdk-ci] [PATCH v2 1/4] create_new_execution_file_from_tags: change tag argument ohilyard
2021-10-13 14:00 ` [dpdk-ci] [PATCH v2 2/4] create_new_execution_file_from_tags: add test argument ohilyard
2021-10-13 14:00 ` [dpdk-ci] [PATCH v2 3/4] guess_git_tree: module doc comment moved ohilyard
2021-10-13 14:00 ` [dpdk-ci] [PATCH v2 4/4] guess_git_tree: fix crash caused by empty diff ohilyard
2022-01-24 11:22 ` [PATCH v2 1/4] create_new_execution_file_from_tags: change tag argument Ali Alnubani
2022-02-01 21:35 ` [PATCH v3 " ohilyard
2022-02-03 13:14 ` Ali Alnubani
2022-02-07 14:19 ` [PATCH v4 " ohilyard
2022-02-07 14:19 ` [PATCH v4 2/4] create_new_execution_file_from_tags: add test argument ohilyard
2022-02-07 14:19 ` [PATCH v4 3/4] pw_maintainers_cli: move module doc comment ohilyard
2022-02-07 14:19 ` [PATCH v4 4/4] pw_maintainers_cli: fix crash caused by empty diff ohilyard
2022-02-07 14:20 ` [PATCH v4 1/4] create_new_execution_file_from_tags: change tag argument Owen Hilyard
2022-02-07 15:08 ` [PATCH v5 1/3] " ohilyard
2022-02-07 15:08 ` [PATCH v5 2/3] pw_maintainers_cli: move module doc comment ohilyard
2022-02-07 15:56 ` Ali Alnubani
2022-02-07 15:08 ` [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff ohilyard
2022-02-07 15:56 ` Ali Alnubani
2023-06-21 15:19 ` Ali Alnubani
2023-06-21 15:39 ` Patrick Robb
2023-06-21 18:38 ` Aaron Conole [this message]
2022-02-07 15:56 ` [PATCH v5 1/3] create_new_execution_file_from_tags: change tag argument Ali Alnubani
2023-06-21 18:41 ` Aaron Conole
2022-02-01 21:35 ` [PATCH v3 2/4] create_new_execution_file_from_tags: add test argument ohilyard
2022-02-01 21:35 ` [PATCH v3 3/4] pw_maintainers_cli: module doc comment moved ohilyard
2022-02-03 13:14 ` Ali Alnubani
2022-02-01 21:35 ` [PATCH v3 4/4] guess_git_tree: fix crash caused by empty diff ohilyard
2022-02-03 13:14 ` Ali Alnubani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ty1kcslsr.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=alialnu@nvidia.com \
--cc=ci@dpdk.org \
--cc=ohilyard@iol.unh.edu \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).