DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 0/3] librte_cmdline: fix parsing initialisation
Date: Mon, 10 Jul 2017 14:09:33 +0200	[thread overview]
Message-ID: <cover.1499687422.git.adrien.mazarguil@6wind.com> (raw)
In-Reply-To: <327b5be12221f51fbf3a6d8e9d155de786992388.1497521374.git.adrien.mazarguil@6wind.com>

Adding a cover letter to keep the same title for that thread, since I took
over the original patch from Bernard, modified it somewhat and made a couple
of additional fixes on top of it.

Olivier's comment [1] and Bernard's feedback about dynamic tokens made me
realize how the interface itself was not only difficult to use but also
broken.

This series starts by fixing the root cause of the original issue reported
by Bernard, then simplifies the interface itself and its only user (testpmd)
and finally fixes an unrelated issue found in testpmd. These fixes target
all stable releases since 17.02.

[1] http://dpdk.org/ml/archives/dev/2017-June/068605.html

Adrien Mazarguil (3):
  cmdline: fix dynamic tokens initialization
  cmdline: fix dynamic tokens interface
  app/testpmd: fix token matching in flow command

 app/test-pmd/cmdline_flow.c        | 36 +++++++-------
 lib/librte_cmdline/cmdline_parse.c | 85 ++++++++++-----------------------
 lib/librte_cmdline/cmdline_parse.h | 50 +++++++++++++++----
 3 files changed, 85 insertions(+), 86 deletions(-)

-- 
2.1.4

  parent reply	other threads:[~2017-07-10 12:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 10:07 [dpdk-dev] [PATCH] " Bernard Iremonger
2017-06-15 10:15 ` [dpdk-dev] [PATCH v2] " Adrien Mazarguil
2017-06-23  9:04   ` Olivier Matz
2017-07-10 12:09   ` Adrien Mazarguil [this message]
2017-07-10 12:09     ` [dpdk-dev] [PATCH v3 1/3] cmdline: fix dynamic tokens initialization Adrien Mazarguil
2017-07-10 12:09     ` [dpdk-dev] [PATCH v3 2/3] cmdline: fix dynamic tokens interface Adrien Mazarguil
2017-07-10 12:09     ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: fix token matching in flow command Adrien Mazarguil
2017-07-20 22:08     ` [dpdk-dev] [PATCH v3 0/3] librte_cmdline: fix parsing initialisation Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1499687422.git.adrien.mazarguil@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).