From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Tonghao Zhang <nic@opencloud.tech>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.
Date: Mon, 26 Jun 2017 10:14:59 +0100 [thread overview]
Message-ID: <d0e1d99d-c8a5-d541-5e27-b72de1d68457@intel.com> (raw)
In-Reply-To: <8278174.tmcXUfVEQA@xps>
On 23/06/2017 14:02, Thomas Monjalon wrote:
> 22/06/2017 17:15, Sergio Gonzalez Monroy:
>> Just fyi, the summary line should be lowercase apart from acronyms (DPDK
>> guidelines).
>>
>> On 11/05/2017 02:56, Tonghao Zhang wrote:
>>> The NUMA node information for PCI devices provided through
>>> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx
>>> on Red Hat Enterprise Linux 6, and VMs on some hypervisors.
>>> It is good to see more checking for valid values.
>>>
>>> Signed-off-by: Tonghao Zhang <nic@opencloud.tech>
>>> ---
>> IMHO the message could be slightly improved by adding some of the
>> replies that you made to your v3.
>> ie. Typical wrong numa node in VMs
>>
>> $ cat /sys/devices/pci0000:00/0000:00:18.6/numa_node
>> -1
> [...]
>> The code changes look fine, so I leave it to Thomas regarding the commit
>> message :)
>>
>> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> Applied, thanks
It looks like some systems have quite a few devices that report -1 as
numa_node value causing lots of warning messages being printed.
Quick fixes that come to mind would be:
1) Change log level to DEBUG
2) Add static var to only print the message once.
I also think that the message itself should show at least the BDF to at
least know which devices are reporting bad numa_node values.
Thoughts?
Sergio
next prev parent reply other threads:[~2017-06-26 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 1:56 Tonghao Zhang
2017-06-22 15:15 ` Sergio Gonzalez Monroy
2017-06-23 13:02 ` Thomas Monjalon
2017-06-26 9:14 ` Sergio Gonzalez Monroy [this message]
2017-06-26 9:39 ` Thomas Monjalon
2017-06-26 12:50 ` Sergio Gonzalez Monroy
2017-06-26 14:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0e1d99d-c8a5-d541-5e27-b72de1d68457@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=nic@opencloud.tech \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).