From: "Etelson, Gregory" <getelson@nvidia.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: "Etelson, Gregory" <getelson@nvidia.com>,
dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net,
stable@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] eal/windows: fix memory management macros usage
Date: Tue, 14 Nov 2023 21:14:38 +0200 (IST) [thread overview]
Message-ID: <d26438ce-43b5-3ade-4e03-fa1ff804e841@nvidia.com> (raw)
In-Reply-To: <20231114182212.GA3681@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Hello Tyler,
>>>
>>> since we are duplicating something that comes from something else that
>>> has been duplicated out of windows WDK here it might be a reasonable
>>> safety check to verify that our duplicated values match our
>>> expectations?
>>
>> MEM_COALESCE_PLACEHOLDERS, MEM_PRESERVE_PLACEHOLDER,
>> MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER
>> are defined in Win32 API.
>>
>> DPDK has no expectations about these values. DPDK needs them as
>> parameters to the VirtualX function calls.
>> It looks like the macros were added to EAL because they were missing
>> in mingw.
>>
>> Once compiler environment was fixed, the proper order was restored.
>
> yes, there is a lag between when names appear in the actual WDK and when
> mingw takes a the snapshot of the headers. so long as the copy they take
> is only from released WDK versions that align with an OS we shouldn't
> expect the values to change but if the duplicated names in dpdk were
> based upon an insider (preview version of SDK) value that later got changed
> there could be a misalignment. unlikely but possible.
>
DPDK matrix works with official OS compiler versions.
Such compilers will not provide bad API.
As for non-official compilers or releases, they come without any warranty.
Regards,
Gregory
next prev parent reply other threads:[~2023-11-14 19:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 17:05 Gregory Etelson
2023-11-14 17:46 ` Tyler Retzlaff
2023-11-14 18:16 ` Etelson, Gregory
2023-11-14 18:22 ` Tyler Retzlaff
2023-11-14 19:14 ` Etelson, Gregory [this message]
2023-11-14 19:19 ` Dmitry Kozlyuk
2023-11-14 19:19 ` Dmitry Kozlyuk
2023-11-22 16:47 ` Thomas Monjalon
2023-11-22 16:56 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26438ce-43b5-3ade-4e03-fa1ff804e841@nvidia.com \
--to=getelson@nvidia.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=mkashani@nvidia.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).