From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Sarosh Arif <sarosh.arif@emumba.com>, sthemmin@microsoft.com
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [v3 PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size
Date: Wed, 10 Feb 2021 17:41:21 +0000 [thread overview]
Message-ID: <d2cf50b8-2554-e804-87a0-5ad23dd436c0@intel.com> (raw)
In-Reply-To: <20210210061605.30648-1-sarosh.arif@emumba.com>
On 10-Feb-21 6:16 AM, Sarosh Arif wrote:
> If user requests a hugepage size which is not supported by the system,
> currently user gets an error message saying that the requested size
> is not a valid system huge page size. In addition to this if we display
> the valid hugepage sizes it will be convenient for the user to request
> the right size next time.
>
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> ---
> v2:
> pass string in sys.exit() to remove pylint warning
> v3:
> modify get_valid_page_sizes()
> ---
>
> usertools/dpdk-hugepages.py | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/usertools/dpdk-hugepages.py b/usertools/dpdk-hugepages.py
> index 70432f9cd..57ae9f391 100755
> --- a/usertools/dpdk-hugepages.py
> +++ b/usertools/dpdk-hugepages.py
> @@ -43,6 +43,12 @@ def is_numa():
> return os.path.exists('/sys/devices/system/node')
>
>
> +def get_valid_page_sizes(path):
> + '''Extract valid hugepage sizes'''
> + dir = os.path.dirname(path)
> + pg_sizes = (d.split("-")[1] for d in os.listdir(dir))
> + return " ".join(pg_sizes)
> +
> def get_hugepages(path):
> '''Read number of reserved pages'''
> with open(path + '/nr_hugepages') as nr_hugepages:
> @@ -59,9 +65,8 @@ def set_hugepages(path, pages):
> except PermissionError:
> sys.exit('Permission denied: need to be root!')
> except FileNotFoundError:
> - filename = os.path.basename(path)
> - size = filename[10:]
> - sys.exit('{} is not a valid system huge page size'.format(size))
> + sys.exit("Invalid page size. Valid page sizes: {}".format(
> + get_valid_page_sizes(path)))
Nitpicking, but i think this indentation wouldn't be OK with a PEP-8
style checker. This should be better:
sys.exit("Invalid page size. Valid page sizes: {}"
.format(get_validpage_sizes(path))
(note the alignment of .format with the quote)
Otherwise, LGTM
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> if get_hugepages(path) != pages:
> sys.exit('Unable to reserve required pages.')
>
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-02-10 17:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:47 [dpdk-dev] [PATCH] " Sarosh Arif
2020-11-30 16:46 ` Stephen Hemminger
2020-11-30 16:47 ` Stephen Hemminger
2020-12-02 11:06 ` [dpdk-dev] [v2 PATCH] " Sarosh Arif
2021-02-05 18:17 ` Thomas Monjalon
2021-02-08 22:12 ` Stephen Hemminger
2021-02-09 11:34 ` Burakov, Anatoly
2021-02-10 6:16 ` [dpdk-dev] [v3 " Sarosh Arif
2021-02-10 17:41 ` Burakov, Anatoly [this message]
2021-02-11 8:20 ` [dpdk-dev] [v4 " Sarosh Arif
2021-02-11 16:26 ` Stephen Hemminger
2021-02-11 21:44 ` Thomas Monjalon
2021-02-11 23:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2cf50b8-2554-e804-87a0-5ad23dd436c0@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=sarosh.arif@emumba.com \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).